Skip to content

Commit a8118d5

Browse files
committed
feat(tests): add requirement for DoS fixed in 10.1.4
- Added internal test case int001 in reqs_conway.py - Updated test_committee.py to include int001 test case - Documented internal test case in chang_user_stories_template.rst
1 parent 462c31f commit a8118d5

File tree

3 files changed

+33
-1
lines changed

3 files changed

+33
-1
lines changed

cardano_node_tests/tests/reqs_conway.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,9 @@ def __dr(id: str) -> requirements.Req:
236236
gr028 = __r("GR028")
237237
gr029 = __r("GR029")
238238

239+
# Internal Test Cases
240+
int001 = __r("R10_1_4")
241+
239242
# DB Sync Conway related tables
240243
# https://github.com/IntersectMBO/cardano-db-sync/blob/master/doc/schema.md
241244
db001 = __dr("drep_hash")

cardano_node_tests/tests/tests_conway/test_committee.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,10 +379,14 @@ def _auth_hot_keys() -> None:
379379
_propose_new_member()
380380
_auth_hot_keys()
381381

382+
reqc.int001.start(url=helpers.get_vcs_link())
383+
subtest_errors = []
382384
for smethod in submit_methods:
383385
for build_method in ("build_raw", "build"):
384386
for scenario in ("all_cc_one_unelected", "all_cc_all_unelected"):
385-
with subtests.test(id=f"{scenario}_{build_method}_{smethod}"):
387+
subtest_id = f"{scenario}_{build_method}_{smethod}"
388+
subtest_errors.append(subtest_id)
389+
with subtests.test(id=subtest_id):
386390
with pytest.raises(
387391
(clusterlib.CLIError, submit_api.SubmitApiError)
388392
) as excinfo:
@@ -397,6 +401,10 @@ def _auth_hot_keys() -> None:
397401
"to cast votes:",
398402
err_str,
399403
), err_str
404+
subtest_errors.pop()
405+
406+
if not subtest_errors:
407+
reqc.int001.success()
400408

401409
@allure.link(helpers.get_vcs_link())
402410
@submit_utils.PARAM_SUBMIT_METHOD

src_docs/chang_user_stories_template.rst

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1230,6 +1230,24 @@ Governance guardrails User Stories
12301230
- As an ADA holder, when submitting an update protocol parameters proposal, the governance guardrail should prevent an unconstitutional value for `poolPledgeInfluence`.
12311231

12321232

1233+
Internal Test Cases
1234+
-------------------
1235+
1236+
.. list-table::
1237+
:widths: 18 53
1238+
:header-rows: 1
1239+
1240+
-
1241+
1242+
- Status for Test Case
1243+
- Description
1244+
-
1245+
1246+
- |image-R10_1_4|
1247+
- Prevent a potential DoS attack. Prevent invalid CC member from voting.
1248+
`<https://github.com/IntersectMBO/cardano-node/releases/tag/10.1.4>`__
1249+
1250+
12331251
DB Sync - Conway related tables
12341252
-------------------------------
12351253

@@ -1721,6 +1739,9 @@ DB Sync - Conway related tables
17211739
.. |image-GR029| image:: https://img.shields.io/badge/GR029-grey
17221740
:target: https://github.com/GR029-404
17231741

1742+
.. |image-R10_1_4| image:: https://img.shields.io/badge/R10_1_4-grey
1743+
:target: https://github.com/R10_1_4-404
1744+
17241745
.. |image-drep_hash| image:: https://img.shields.io/badge/drep_hash-grey
17251746
:target: https://github.com/drep_hash-404
17261747
.. |image-committee_hash| image:: https://img.shields.io/badge/committee_hash-grey

0 commit comments

Comments
 (0)