fix(tests): update error checks for tx id deserialization

mkoura · mkoura · commit ad73bd902d54 · 2025-06-16T14:34:57.000+02:00
Update negative transaction tests to check for "Failed to deserialise"
error messages, reflecting changes in node 10.5.0+. Retain previous
checks for backward compatibility with older error formats.
diff --git a/cardano_node_tests/tests/test_tx_negative.py b/cardano_node_tests/tests/test_tx_negative.py
@@ -1302,7 +1302,8 @@ def test_invalid_length_utxo_hash(
             cluster_obj=cluster, pool_users=pool_users, utxo=utxo_copy, temp_template=temp_template
         )
         assert (
-            "Incorrect transaction id format" in err
+            "Failed to deserialise" in err  # With node 10.5.0+
+            or "Incorrect transaction id format" in err
             or "Failed reading" in err
             or "expecting transaction id (hexadecimal)" in err
         )
@@ -1337,7 +1338,7 @@ def test_build_invalid_length_utxo_hash(
             use_build_cmd=True,
         )
         assert (
-            "Unable to deserialise TxId" in err  # With node 10.5.0+
+            "Failed to deserialise" in err  # With node 10.5.0+
             or "Incorrect transaction id format" in err
             or "Failed reading" in err
             or "expecting transaction id (hexadecimal)" in err

Original file line number	Diff line number	Diff line change
`@@ -1302,7 +1302,8 @@ def test_invalid_length_utxo_hash(`
`1302`	`1302`	`cluster_obj=cluster, pool_users=pool_users, utxo=utxo_copy, temp_template=temp_template`
`1303`	`1303`	`)`
`1304`	`1304`	`assert (`
`1305`		`- "Incorrect transaction id format" in err`
	`1305`	`+ "Failed to deserialise" in err # With node 10.5.0+`
	`1306`	`+ or "Incorrect transaction id format" in err`
`1306`	`1307`	`or "Failed reading" in err`
`1307`	`1308`	`or "expecting transaction id (hexadecimal)" in err`
`1308`	`1309`	`)`
`@@ -1337,7 +1338,7 @@ def test_build_invalid_length_utxo_hash(`
`1337`	`1338`	`use_build_cmd=True,`
`1338`	`1339`	`)`
`1339`	`1340`	`assert (`
`1340`		`- "Unable to deserialise TxId" in err # With node 10.5.0+`
	`1341`	`+ "Failed to deserialise" in err # With node 10.5.0+`
`1341`	`1342`	`or "Incorrect transaction id format" in err`
`1342`	`1343`	`or "Failed reading" in err`
`1343`	`1344`	`or "expecting transaction id (hexadecimal)" in err`