chore: remove pyrefly ignore comments from codebase

mkoura · mkoura · commit b297b0e6dd70 · 2025-12-10T16:48:58.000+01:00
Clean up unnecessary `# pyrefly: ignore` comments throughout the codebase.
This improves code readability and reduces clutter. No functional changes
were made. Also, minor variable renaming for unused values and type
annotations added for clarity.
diff --git a/.github/regression.sh b/.github/regression.sh
@@ -157,6 +157,7 @@ _cleanup() {
   fi
 }
 
+# shellcheck disable=SC2329
 _cleanup_testnet_on_interrupt() {
   [ -z "${BOOTSTRAP_DIR:-""}" ] && return
 
@@ -185,6 +186,7 @@ _cleanup_testnet_on_interrupt() {
 }
 
 # cleanup on Ctrl+C or error
+# shellcheck disable=SC2329
 _interrupted() {
   # Do testnet cleanup only on interrupted testrun. When not interrupted,
   # cleanup is done as part of a testrun.
diff --git a/cardano_node_tests/cardano_cli_coverage.py b/cardano_node_tests/cardano_cli_coverage.py
@@ -101,11 +101,9 @@ def merge_coverage(dict_a: dict, dict_b: dict) -> dict:
     mergeable = (list, set, tuple)
     addable = (int, float)
     for key, value in dict_b.items():
-        # pyrefly: ignore  # invalid-argument
         if key in dict_a and isinstance(value, mergeable) and isinstance(dict_a[key], mergeable):
             new_list = set(dict_a[key]).union(value)
             dict_a[key] = sorted(new_list)
-        # pyrefly: ignore  # invalid-argument
         elif key in dict_a and isinstance(value, addable) and isinstance(dict_a[key], addable):
             dict_a[key] += value
         # Skipped arguments and commands are not in the available commands dict
@@ -124,7 +122,6 @@ def cli(cli_args: tp.Iterable[str]) -> str:
     assert not isinstance(cli_args, str), "`cli_args` must be sequence of strings"
     with subprocess.Popen(list(cli_args), stdout=subprocess.PIPE, stderr=subprocess.PIPE) as p:
         __, stderr = p.communicate()
-    # pyrefly: ignore  # missing-attribute
     return stderr.decode()
 
 
diff --git a/cardano_node_tests/tests/test_mnemonic.py b/cardano_node_tests/tests/test_mnemonic.py
@@ -19,10 +19,8 @@
 LOGGER = logging.getLogger(__name__)
 DATA_DIR = pl.Path(__file__).parent / "data" / "mnemonic_golden"
 
-# pyrefly: ignore  # no-matching-overload
 KEY_TYPES = tuple(clusterlib.KeyType)
 KEY_TYPE_IDS = tuple(k.value.replace("-", "_") for k in KEY_TYPES)
-# pyrefly: ignore  # no-matching-overload
 OUT_FORMATS = tuple(clusterlib.OutputFormat)
 OUT_FORMAT_IDS = tuple(k.value.replace("-", "_") for k in OUT_FORMATS)
 
diff --git a/cardano_node_tests/tests/test_scripts.py b/cardano_node_tests/tests/test_scripts.py
@@ -1608,7 +1608,7 @@ def test_before_future(
         build_method = request.node.callspec.params["fund_script_before_slot_in_future"]
         temp_template = f"{common.get_test_id(cluster)}_{common.unique_time_str()}"
 
-        multisig_script, script_address, script_utxos, tx_output, before_slot = (
+        multisig_script, _script_address, script_utxos, tx_output, before_slot = (
             fund_script_before_slot_in_future
         )
 
@@ -1665,7 +1665,7 @@ def test_after_future(
         build_method = request.node.callspec.params["fund_script_after_slot_in_future"]
         temp_template = f"{common.get_test_id(cluster)}_{common.unique_time_str()}"
 
-        multisig_script, script_address, script_utxos, tx_output, after_slot = (
+        multisig_script, _script_address, script_utxos, tx_output, after_slot = (
             fund_script_after_slot_in_future
         )
 
@@ -1742,7 +1742,7 @@ def test_after_past(
         build_method = request.node.callspec.params["fund_script_after_slot_in_past"]
         temp_template = f"{common.get_test_id(cluster)}_{common.unique_time_str()}"
 
-        multisig_script, script_address, script_utxos, tx_output, after_slot = (
+        multisig_script, _script_address, script_utxos, tx_output, after_slot = (
             fund_script_after_slot_in_past
         )
 
diff --git a/cardano_node_tests/tests/tests_conway/test_constitution.py b/cardano_node_tests/tests/tests_conway/test_constitution.py
@@ -305,7 +305,7 @@ def governance_w_scripts_lg(
     ],
 ) -> governance_utils.GovernanceRecords:
     """Create a governance records with script DReps."""
-    cluster, default_governance = cluster_lock_gov_script
+    _cluster, default_governance = cluster_lock_gov_script
     script_dreps, script_delegators = script_dreps_lg
     return dataclasses.replace(
         default_governance, drep_scripts_reg=script_dreps, drep_scripts_delegators=script_delegators
diff --git a/cardano_node_tests/tests/tests_conway/test_pparam_update.py b/cardano_node_tests/tests/tests_conway/test_pparam_update.py
@@ -696,7 +696,6 @@ def _propose_pparams_update(
             anchor_data = governance_utils.get_default_anchor_data()
             # Increment count for a submitted proposal
             nonlocal submitted_proposal_count
-            # pyrefly: ignore  # unknown-name
             submitted_proposal_count += 1
             return conway_common.propose_pparams_update(
                 cluster_obj=cluster,
diff --git a/cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py b/cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py
@@ -262,9 +262,9 @@ def test_enact_treasury_withdrawals(
         def _cast_vote(
             approve: bool, vote_id: str, add_spo_votes: bool = False
         ) -> governance_utils.VotedVotes:
-            votes_cc = []
-            votes_drep = []
-            votes_spo = []
+            votes_cc: list[clusterlib.VoteCC] = []
+            votes_drep: list[clusterlib.VoteDrep] = []
+            votes_spo: list[clusterlib.VoteSPO] = []
             for action_ix in range(actions_num):
                 votes_cc.extend(
                     [
diff --git a/cardano_node_tests/tests/tests_plutus/test_delegation.py b/cardano_node_tests/tests/tests_plutus/test_delegation.py
@@ -624,8 +624,6 @@ def test_register_deregister(
 
         # Step 3: withdraw rewards and deregister
 
-        reward_error = ""
-
         # Make sure we have enough time to finish deregistration in one epoch
         clusterlib_utils.wait_for_epoch_interval(
             cluster_obj=cluster, start=5, stop=common.EPOCH_STOP_SEC_BUFFER
@@ -647,9 +645,6 @@ def test_register_deregister(
             ),
         )
 
-        if reward_error:
-            raise AssertionError(reward_error)
-
         # Check tx_view of step 2 and step 3
         tx_view.check_tx_view(cluster_obj=cluster, tx_raw_output=tx_raw_output_reg)
         tx_view.check_tx_view(cluster_obj=cluster, tx_raw_output=tx_raw_output_dereg)
diff --git a/cardano_node_tests/tests/tests_plutus/test_mint_build.py b/cardano_node_tests/tests/tests_plutus/test_mint_build.py
@@ -272,7 +272,7 @@ def test_minting_missing_txout(
 
         # Step 1: fund the token issuer and create UTXO for collaterals
 
-        mint_utxos, collateral_utxos, tx_output_step1 = mint_build._fund_issuer(
+        mint_utxos, collateral_utxos, _tx_output_step1 = mint_build._fund_issuer(
             cluster_obj=cluster,
             temp_template=temp_template,
             payment_addr=payment_addr,
diff --git a/cardano_node_tests/tests/tests_plutus_v2/mint_raw.py b/cardano_node_tests/tests/tests_plutus_v2/mint_raw.py
@@ -127,7 +127,7 @@ def check_missing_builtin(
 
     # Step 1: fund the token issuer
 
-    mint_utxos, collateral_utxos, __, tx_raw_output_step1 = _fund_issuer(
+    mint_utxos, collateral_utxos, *__ = _fund_issuer(
         cluster_obj=cluster_obj,
         temp_template=temp_template,
         payment_addr=payment_addr,
diff --git a/cardano_node_tests/tests/tests_plutus_v2/test_mint_build.py b/cardano_node_tests/tests/tests_plutus_v2/test_mint_build.py
@@ -281,7 +281,7 @@ def test_minting_ref_missing_txout(
 
         # Step 1: fund the token issuer and create UTxOs for collaterals and reference script
 
-        mint_utxos, collateral_utxos, reference_utxo, tx_output_step1 = mint_build._fund_issuer(
+        mint_utxos, collateral_utxos, reference_utxo, _tx_output_step1 = mint_build._fund_issuer(
             cluster_obj=cluster,
             temp_template=temp_template,
             payment_addr=payment_addr,
diff --git a/cardano_node_tests/utils/artifacts.py b/cardano_node_tests/utils/artifacts.py
@@ -22,7 +22,6 @@ def save_cli_coverage(
 ) -> pl.Path | None:
     """Save CLI coverage info."""
     cli_coverage_dir = pytest_config.getoption(CLI_COVERAGE_ARG)
-    # pyrefly: ignore  # missing-attribute
     if not (cli_coverage_dir and hasattr(cluster_obj, "cli_coverage") and cluster_obj.cli_coverage):  # pyright: ignore [reportAttributeAccessIssue]
         return None
 
diff --git a/cardano_node_tests/utils/clusterlib_utils.py b/cardano_node_tests/utils/clusterlib_utils.py
@@ -1071,7 +1071,6 @@ def _get_ledger_state_cmd(*, cluster_obj: clusterlib.ClusterLib) -> str:
     if hasattr(cluster_obj, "cli_coverage"):
         custom_clusterlib.record_cli_coverage(
             cli_args=cardano_cli_args,
-            # pyrefly: ignore  # missing-attribute
             coverage_dict=cluster_obj.cli_coverage,  # pyright: ignore [reportAttributeAccessIssue]
         )
 
diff --git a/cardano_node_tests/utils/dbsync_check_tx.py b/cardano_node_tests/utils/dbsync_check_tx.py
@@ -48,7 +48,6 @@ def _get_scripts_hashes(
     for r in records:
         if not r.script_file:
             continue
-        # pyrefly: ignore  # bad-argument-type
         shash = cluster_obj.g_transaction.get_policyid(script_file=r.script_file)
         shash_rec = hashes_db.get(shash)
         if shash_rec is None:
@@ -138,9 +137,7 @@ def _compare_redeemers(
         )
 
         for tx_rec in tx_recs:
-            # pyrefly: ignore  # missing-attribute
             tx_unit_steps = tx_rec.execution_units[0] if tx_rec.execution_units else None
-            # pyrefly: ignore  # missing-attribute
             tx_unit_mem = tx_rec.execution_units[1] if tx_rec.execution_units else None
 
             missing_tx_unit_steps = not (tx_unit_steps and tx_unit_mem)
diff --git a/cardano_node_tests/utils/helpers.py b/cardano_node_tests/utils/helpers.py
@@ -100,14 +100,11 @@ def run_command(
         retcode = p.returncode
 
     if not ignore_fail and retcode != 0:
-        # pyrefly: ignore  # missing-attribute
         err_dec = stderr.decode()
-        # pyrefly: ignore  # missing-attribute
         err_dec = err_dec or stdout.decode()
         msg = f"An error occurred while running `{cmd_str}`: {err_dec}"
         raise RuntimeError(msg)
 
-    # pyrefly: ignore  # bad-return
     return stdout
 
 
@@ -300,16 +297,14 @@ def tool_has(command: str) -> bool:
 
 def flatten(iterable: tp.Iterable, *, ltypes: type[tp.Iterable] | None = None) -> tp.Generator:
     """Flatten an irregular (arbitrarily nested) iterable of iterables."""
-    ltypes = ltypes if ltypes is not None else abc.Iterable
+    ltypes_p = ltypes if ltypes is not None else abc.Iterable
     remainder = iter(iterable)
     while True:
         try:
             first = next(remainder)
         except StopIteration:
             break
-        # pyrefly: ignore  # invalid-argument
-        if isinstance(first, ltypes) and not isinstance(first, str | bytes):
-            # pyrefly: ignore  # bad-argument-type
+        if isinstance(first, ltypes_p) and not isinstance(first, str | bytes):
             remainder = itertools.chain(first, remainder)
         else:
             yield first
diff --git a/doc/smash/smash_tests_and_debugging_examples.md b/doc/smash/smash_tests_and_debugging_examples.md
@@ -71,7 +71,7 @@ select * from delisted_pool;
 
 | id |                          hash_raw
 | -- | -----------------------------------------------------------
-| 1 | \xa5a3ce765f5162548181a44d1ff8c8f8c50018cca59acc0b70a85a41
+| 1  | \xa5a3ce765f5162548181a44d1ff8c8f8c50018cca59acc0b70a85a41
 
 
 ## Reserving a ticker

Original file line number	Diff line number	Diff line change
`@@ -157,6 +157,7 @@ _cleanup() {`
`157`	`157`	`fi`
`158`	`158`	`}`
`159`	`159`
	`160`	`+# shellcheck disable=SC2329`
`160`	`161`	`_cleanup_testnet_on_interrupt() {`
`161`	`162`	`[ -z "${BOOTSTRAP_DIR:-""}" ] && return`
`162`	`163`
`@@ -185,6 +186,7 @@ _cleanup_testnet_on_interrupt() {`
`185`	`186`	`}`
`186`	`187`
`187`	`188`	`# cleanup on Ctrl+C or error`
	`189`	`+# shellcheck disable=SC2329`
`188`	`190`	`_interrupted() {`
`189`	`191`	`# Do testnet cleanup only on interrupted testrun. When not interrupted,`
`190`	`192`	`# cleanup is done as part of a testrun.`
Original file line number	Diff line number	Diff line change
`@@ -1608,7 +1608,7 @@ def test_before_future(`
`1608`	`1608`	`build_method = request.node.callspec.params["fund_script_before_slot_in_future"]`
`1609`	`1609`	`temp_template = f"{common.get_test_id(cluster)}_{common.unique_time_str()}"`
`1610`	`1610`
`1611`		`- multisig_script, script_address, script_utxos, tx_output, before_slot = (`
	`1611`	`+ multisig_script, _script_address, script_utxos, tx_output, before_slot = (`
`1612`	`1612`	`fund_script_before_slot_in_future`
`1613`	`1613`	`)`
`1614`	`1614`
`@@ -1665,7 +1665,7 @@ def test_after_future(`
`1665`	`1665`	`build_method = request.node.callspec.params["fund_script_after_slot_in_future"]`
`1666`	`1666`	`temp_template = f"{common.get_test_id(cluster)}_{common.unique_time_str()}"`
`1667`	`1667`
`1668`		`- multisig_script, script_address, script_utxos, tx_output, after_slot = (`
	`1668`	`+ multisig_script, _script_address, script_utxos, tx_output, after_slot = (`
`1669`	`1669`	`fund_script_after_slot_in_future`
`1670`	`1670`	`)`
`1671`	`1671`
`@@ -1742,7 +1742,7 @@ def test_after_past(`
`1742`	`1742`	`build_method = request.node.callspec.params["fund_script_after_slot_in_past"]`
`1743`	`1743`	`temp_template = f"{common.get_test_id(cluster)}_{common.unique_time_str()}"`
`1744`	`1744`
`1745`		`- multisig_script, script_address, script_utxos, tx_output, after_slot = (`
	`1745`	`+ multisig_script, _script_address, script_utxos, tx_output, after_slot = (`
`1746`	`1746`	`fund_script_after_slot_in_past`
`1747`	`1747`	`)`
`1748`	`1748`