update compatible tests

Author: OlufemiAdeOlusile

cardano_node_tests/tests/tests_conway/test_conway.py

@@ -184,3 +184,61 @@ def test_ratify_state_fields(self, cluster: clusterlib.ClusterLib):
 
         missing = expected_fields - set(ratify_state)
         assert not missing, f"Missing expected fields in ratify-state: {missing}"
+
+
+class TestNegativeLegacyGovernance:
+    @allure.link(helpers.get_vcs_link())
+    @pytest.mark.parametrize("era", ["shelley", "mary", "alonzo", "babbage"])
+    @pytest.mark.smoke
+    def test_mixed_legacy_govaction_and_conway_vote_cert_fails(
+        self,
+        cluster: clusterlib.ClusterLib,
+        pool_user: clusterlib.PoolUser,
+        era: str,
+    ):
+        """Mixing a legacy governance action with a Conway vote-delegation cert must fail."""
+        temp_template = common.get_test_id(cluster)
+
+        payment_rec = pool_user.payment
+        stake_rec = pool_user.stake
+
+        pool_ids = cluster.g_query.get_stake_pools()
+        assert pool_ids, "No stake pools available on this testnet"
+        pool_id = pool_ids[0]
+
+        era_api = getattr(cluster.g_compatible, era)
+        legacy_prop = era_api.governance.action.gen_pparams_update(
+            name=temp_template,
+            epoch=cluster.g_query.get_epoch(),
+            genesis_vkey_file=cluster.g_genesis.genesis_keys.genesis_vkeys[0],
+            cli_args=["--max-block-body-size", "65536"],
+        )
+
+        conway_vote = cluster.g_stake_address.gen_stake_and_vote_delegation_cert(
+            addr_name=f"{temp_template}_vote",
+            stake_vkey_file=stake_rec.vkey_file,
+            stake_pool_id=pool_id,
+            always_abstain=True,
+        )
+
+        tx_files = clusterlib.TxFiles(
+            certificate_files=[legacy_prop, conway_vote],
+            signing_key_files=[payment_rec.skey_file, stake_rec.skey_file],
+        )
+
+        with pytest.raises(clusterlib.CLIError) as excinfo:
+            cluster.g_transaction.send_tx(
+                src_address=payment_rec.address,
+                tx_name=f"{temp_template}_mixed_fail",
+                tx_files=tx_files,
+            )
+
+        err = str(excinfo.value)
+
+        print("\n >>>>> ERROR START")
+        print(err)
+        print(" >>>>> ERROR END\n")
+
+        assert "TextEnvelope type error" in err, err
+        assert "Expected: CertificateConway" in err, err
+        assert "Actual: UpdateProposalShelley" in err, err

cardano_node_tests/tests/tests_conway/test_pparam_update.py

@@ -1433,40 +1433,54 @@ def test_pparam_keys(
         [r.success() for r in (reqc.cip075, reqc.cip076, reqc.cip077, reqc.cip078)]
 
 
+ERA_VALID_PPARAM = {
+    # Allowed in Shelley and mary compatible CLI
+    "shelley": ("--max-block-body-size", 65536, "maxBlockBodySize"),
+    "mary": ("--max-block-body-size", 65536, "maxBlockBodySize"),
+    # Allowed in Alonzo and babbage compatible CLI
+    "alonzo": ("--max-collateral-inputs", 4, "maxCollateralInputs"),
+    "babbage": ("--max-collateral-inputs", 4, "maxCollateralInputs"),
+}
+
+
 class TestLegacyProposals:
     """Tests for legacy update proposals in Conway."""
 
     @allure.link(helpers.get_vcs_link())
     @submit_utils.PARAM_SUBMIT_METHOD
+    @pytest.mark.parametrize("era", ["shelley", "mary", "alonzo", "babbage"])
     @pytest.mark.smoke
     def test_legacy_proposal_submit(
         self,
         cluster: clusterlib.ClusterLib,
         payment_addr: clusterlib.AddressRecord,
         submit_method: str,
+        era: str,
     ):
-        """Test that a compatible Babbage pparam proposal cannot be submitted in Conway era."""
+        """Test a compatible-era (Shelley, Mary, Alonzo, Babbage)."""
         temp_template = common.get_test_id(cluster)
 
+        arg, val, name = ERA_VALID_PPARAM[era]
+
         update_proposals = [
             clusterlib_utils.UpdateProposal(
-                arg="--max-collateral-inputs",
-                value=4,
-                name="maxCollateralInputs",
+                arg=arg,
+                value=val,
+                name=name,
             ),
         ]
 
         cli_args = clusterlib_utils.get_pparams_update_args(update_proposals=update_proposals)
 
-        # NEW: use compatible babbage pparam action
-        action_file = cluster.g_compatible.babbage.governance.action.gen_pparams_update(
+        era_api = getattr(cluster.g_compatible, era)
+
+        action_file = era_api.governance.action.gen_pparams_update(
             name=temp_template,
             epoch=cluster.g_query.get_epoch(),
             genesis_vkey_file=cluster.g_genesis.genesis_keys.genesis_vkeys[0],
             cli_args=cli_args,
         )
 
-        # Submitting a Babbage-era proposal in Conway must fail
         with pytest.raises((clusterlib.CLIError, submit_api.SubmitApiError)) as excinfo:
             clusterlib_utils.build_and_submit_tx(
                 cluster_obj=cluster,
@@ -1483,54 +1497,13 @@ def test_legacy_proposal_submit(
             )
 
         err_str = str(excinfo.value)
-        assert "era" in err_str or "mismatch" in err_str or "TextEnvelope type error" in err_str, (
-            err_str
-        )
-
-    @allure.link(helpers.get_vcs_link())
-    @pytest.mark.smoke
-    def test_legacy_proposal_build(
-        self,
-        cluster: clusterlib.ClusterLib,
-    ):
-        """Test building a legacy update proposal with Conway cardano-cli.
-
-        Expect failure as the legacy update proposals are not supported in Conway.
-        """
-        temp_template = common.get_test_id(cluster)
-
-        update_proposals = [
-            clusterlib_utils.UpdateProposal(
-                arg="--max-collateral-inputs",
-                value=4,
-                name="maxCollateralInputs",
-            ),
-        ]
 
-        cli_args = clusterlib_utils.get_pparams_update_args(update_proposals=update_proposals)
-        out_file = f"{temp_template}_update.proposal"
+        print("\nERROR MESSAGE START")
+        print(err_str)
+        print(" ERROR MESSAGE END\n")
 
-        with pytest.raises(clusterlib.CLIError) as excinfo:
-            cluster.cli(
-                [
-                    "cardano-cli",
-                    "conway",
-                    "governance",
-                    "create-update-proposal",
-                    *cli_args,
-                    "--out-file",
-                    str(out_file),
-                    "--epoch",
-                    str(cluster.g_query.get_epoch()),
-                    *helpers.prepend_flag(
-                        "--genesis-verification-key-file",
-                        cluster.g_genesis.genesis_keys.genesis_vkeys,
-                    ),
-                ],
-                add_default_args=False,
-            )
-        err_str = str(excinfo.value)
-        assert "Invalid argument `create-update-proposal'" in err_str, err_str
+        assert "TextEnvelope type error" in err_str
+        assert "UpdateProposalShelley" in err_str
 
 
 class TestNegativeCostModels: