feat: enable performance checking with ruff

- Added `PERF` to ruff linting rules in `pyproject.toml`
- Refactored code to comply with new performance rules
- Updated exception handling to include `# noqa: PERF203`
- Optimized list comprehensions and `extend` usage

Author: mkoura

cardano_node_tests/tests/test_reconnect.py

@@ -268,7 +268,7 @@ def _assert() -> None:
                 for check_no in range(1, 11):
                     try:
                         _assert()
-                    except AssertionError:
+                    except AssertionError:  # noqa: PERF203
                         if check_no == 10:
                             raise
                         LOGGER.info(f"AssertionError on check {check_no}")

cardano_node_tests/tests/test_staking_rewards.py

@@ -244,9 +244,7 @@ def _get_rew_amount_for_cred_hash(key_hash: str, rec: dict[str, list[dict]]) ->
 def _get_rew_type_for_cred_hash(key_hash: str, rec: dict[str, list[dict]]) -> list[str]:
     """Get reward types for credential hash in ledger state snapshot record."""
     r = rec.get(key_hash) or []
-    rew_types = []
-    for sr in r:
-        rew_types.append(sr["rewardType"])
+    rew_types = [sr["rewardType"] for sr in r]
     return rew_types
 
 

cardano_node_tests/tests/test_tx_mempool.py

@@ -88,7 +88,7 @@ def test_query_mempool_txin(
         for r in range(5):
             try:
                 cluster.g_transaction.submit_tx_bare(tx_file=out_file_signed)
-            except clusterlib.CLIError as exc:
+            except clusterlib.CLIError as exc:  # noqa: PERF203
                 if r == 0 or "(BadInputsUTxO" not in str(exc):
                     raise
                 break

cardano_node_tests/tests/tests_plutus/spend_build.py

@@ -64,17 +64,18 @@ def _build_fund_script(
         clusterlib.TxOut(address=dst_addr.address, amount=redeem_cost.collateral),
     ]
 
-    for token in stokens:
-        txouts.append(dataclasses.replace(script_txout, amount=token.amount, coin=token.coin))
+    txouts.extend(
+        dataclasses.replace(script_txout, amount=token.amount, coin=token.coin) for token in stokens
+    )
 
-    for token in ctokens:
-        txouts.append(
-            clusterlib.TxOut(
-                address=dst_addr.address,
-                amount=token.amount,
-                coin=token.coin,
-            )
+    txouts.extend(
+        clusterlib.TxOut(
+            address=dst_addr.address,
+            amount=token.amount,
+            coin=token.coin,
         )
+        for token in ctokens
+    )
 
     tx_output = cluster_obj.g_transaction.build_tx(
         src_address=payment_addr.address,

cardano_node_tests/tests/tests_plutus/spend_raw.py

@@ -67,17 +67,18 @@ def _fund_script(
         clusterlib.TxOut(address=dst_addr.address, amount=redeem_cost.collateral),
     ]
 
-    for token in stokens:
-        txouts.append(dataclasses.replace(script_txout, amount=token.amount, coin=token.coin))
+    txouts.extend(
+        dataclasses.replace(script_txout, amount=token.amount, coin=token.coin) for token in stokens
+    )
 
-    for token in ctokens:
-        txouts.append(
-            clusterlib.TxOut(
-                address=dst_addr.address,
-                amount=token.amount,
-                coin=token.coin,
-            )
+    txouts.extend(
+        clusterlib.TxOut(
+            address=dst_addr.address,
+            amount=token.amount,
+            coin=token.coin,
         )
+        for token in ctokens
+    )
 
     tx_raw_output = cluster_obj.g_transaction.send_tx(
         src_address=payment_addr.address,

cardano_node_tests/tests/tests_plutus_v2/spend_build.py

@@ -114,14 +114,14 @@ def _build_fund_script(
             )
         )
 
-    for token in tokens_collateral or []:
-        txouts.append(
-            clusterlib.TxOut(
-                address=dst_addr.address,
-                amount=token.amount,
-                coin=token.coin,
-            )
+    txouts.extend(
+        clusterlib.TxOut(
+            address=dst_addr.address,
+            amount=token.amount,
+            coin=token.coin,
         )
+        for token in tokens_collateral or []
+    )
 
     tx_output = cluster.g_transaction.build_tx(
         src_address=payment_addr.address,

cardano_node_tests/tests/tests_plutus_v2/spend_raw.py

@@ -106,14 +106,14 @@ def _fund_script(
             )
         )
 
-    for token in tokens_collateral or []:
-        txouts.append(
-            clusterlib.TxOut(
-                address=dst_addr.address,
-                amount=token.amount,
-                coin=token.coin,
-            )
+    txouts.extend(
+        clusterlib.TxOut(
+            address=dst_addr.address,
+            amount=token.amount,
+            coin=token.coin,
         )
+        for token in tokens_collateral or []
+    )
 
     tx_raw_output = cluster.g_transaction.send_tx(
         src_address=payment_addr.address,

cardano_node_tests/utils/cluster_nodes.py

@@ -410,7 +410,7 @@ def services_action(service_names: list[str], action: str, instance_num: int | N
             helpers.run_command(
                 f"supervisorctl -s http://localhost:{supervisor_port} {action} {service_name}"
             )
-        except Exception as exc:
+        except Exception as exc:  # noqa: PERF203
             msg = f"Failed to {action} service `{service_name}`"
             raise Exception(msg) from exc
 

cardano_node_tests/utils/dbsync_utils.py

@@ -26,37 +26,42 @@ def get_address_reward(
 
     The `epoch_from` and `epoch_to` are epochs where the reward can be spent.
     """
-    rewards = []
-    for db_row in dbsync_queries.query_address_reward(
-        address=address, epoch_from=epoch_from, epoch_to=epoch_to
-    ):
-        rewards.append(
-            dbsync_types.RewardEpochRecord(
-                amount=int(db_row.amount),
-                earned_epoch=db_row.earned_epoch,
-                spendable_epoch=db_row.spendable_epoch,
-                type=db_row.type,
-                pool_id=db_row.pool_id or "",
-            )
+    rewards: list[dbsync_types.RewardEpochRecord] = []
+    rewards.extend(
+        dbsync_types.RewardEpochRecord(
+            amount=int(db_row.amount),
+            earned_epoch=db_row.earned_epoch,
+            spendable_epoch=db_row.spendable_epoch,
+            type=db_row.type,
+            pool_id=db_row.pool_id or "",
+        )
+        for db_row in dbsync_queries.query_address_reward(
+            address=address, epoch_from=epoch_from, epoch_to=epoch_to
         )
+    )
 
-    for db_row in dbsync_queries.query_address_reward_rest(
-        address=address, epoch_from=epoch_from, epoch_to=epoch_to
-    ):
-        rewards.append(
-            dbsync_types.RewardEpochRecord(
-                amount=int(db_row.amount),
-                earned_epoch=db_row.earned_epoch,
-                spendable_epoch=db_row.spendable_epoch,
-                type=db_row.type,
-                pool_id=db_row.pool_id or "",
-            )
+    reward_rest = list(
+        dbsync_queries.query_address_reward_rest(
+            address=address, epoch_from=epoch_from, epoch_to=epoch_to
         )
+    )
+    rewards.extend(
+        dbsync_types.RewardEpochRecord(
+            amount=int(db_row.amount),
+            earned_epoch=db_row.earned_epoch,
+            spendable_epoch=db_row.spendable_epoch,
+            type=db_row.type,
+            pool_id=db_row.pool_id or "",
+        )
+        for db_row in reward_rest
+    )
     if not rewards:
         return dbsync_types.RewardRecord(address=address, reward_sum=0, rewards=[])
 
     reward_sum = functools.reduce(lambda x, y: x + y.amount, rewards, 0)
-    return dbsync_types.RewardRecord(address=db_row.address, reward_sum=reward_sum, rewards=rewards)
+    return dbsync_types.RewardRecord(
+        address=reward_rest[-1].address, reward_sum=reward_sum, rewards=rewards
+    )
 
 
 def check_address_reward(
@@ -796,7 +801,7 @@ def check_plutus_costs(
     for db_record, cost_record in zip(sorted_db, sorted_costs):
         try:
             check_plutus_cost(redeemer_record=db_record, cost_record=cost_record)
-        except AssertionError as err:
+        except AssertionError as err:  # noqa: PERF203
             errors.append(f"{db_record.script_hash}:\n{err}")
 
     if errors:

cardano_node_tests/utils/governance_utils.py

@@ -448,9 +448,9 @@ def _get_cvkey_hash(member: clusterlib.CCMember) -> str:
             cvkey_hash = _get_cvkey_hash(member=_m)
             added_members[f"keyHash-{cvkey_hash}"] = _m.epoch
 
-        removed_members = []
-        for _m in action_data.rem_cc_members:
-            removed_members.append({"keyHash": _get_cvkey_hash(member=_m)})
+        removed_members = [
+            {"keyHash": _get_cvkey_hash(member=_m)} for _m in action_data.rem_cc_members
+        ]
 
         gov_action = {
             "contents": [