Skip to content

Commit ec88255

Browse files
mkouraCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
1 parent 91f0b35 commit ec88255

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

cardano_node_tests/utils/governance_setup.py

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ def _cast_vote(
8181

8282
out_utxos = cluster_obj.g_query.get_utxo(tx_raw_output=tx_output)
8383
expected_balance = clusterlib.calculate_utxos_balance(tx_output.txins) - tx_output.fee
84-
actual_balance = clusterlib.filter_utxos(utxos=out_utxos, address=payment_addr.address)[
85-
0
86-
].amount
84+
filtered_utxos = clusterlib.filter_utxos(utxos=out_utxos, address=payment_addr.address)
85+
if not filtered_utxos:
86+
err = f"No UTXOs found for address `{payment_addr.address}`"
87+
raise RuntimeError(err)
88+
actual_balance = filtered_utxos[0].amount
8789
if actual_balance != expected_balance:
8890
err = f"Incorrect balance for source address `{payment_addr.address}`"
8991
raise RuntimeError(err)
@@ -427,8 +429,12 @@ def auth_cc_members(
427429
)
428430

429431
reg_out_utxos = cluster_obj.g_query.get_utxo(tx_raw_output=tx_output)
432+
filtered_utxos = clusterlib.filter_utxos(utxos=reg_out_utxos, address=payment_addr.address)
433+
if not filtered_utxos:
434+
msg = f"No UTXOs found for address `{payment_addr.address}`."
435+
raise RuntimeError(msg)
430436
if (
431-
clusterlib.filter_utxos(utxos=reg_out_utxos, address=payment_addr.address)[0].amount
437+
filtered_utxos[0].amount
432438
!= clusterlib.calculate_utxos_balance(tx_output.txins) - tx_output.fee
433439
):
434440
msg = f"Incorrect balance for source address `{payment_addr.address}`."
@@ -491,8 +497,12 @@ def reinstate_committee(
491497
)
492498

493499
out_utxos_action = cluster_obj.g_query.get_utxo(tx_raw_output=tx_output_action)
500+
filtered_utxos = clusterlib.filter_utxos(utxos=out_utxos_action, address=pool_user.payment.address)
501+
if not filtered_utxos:
502+
msg = f"No UTXOs found for address `{pool_user.payment.address}`."
503+
raise RuntimeError(msg)
494504
if (
495-
clusterlib.filter_utxos(utxos=out_utxos_action, address=pool_user.payment.address)[0].amount
505+
filtered_utxos[0].amount
496506
!= clusterlib.calculate_utxos_balance(tx_output_action.txins)
497507
- tx_output_action.fee
498508
- deposit_amt

0 commit comments

Comments
 (0)