feat(makefile): add test-env target for test setup (#3213)

Add a `test-env` Makefile target to streamline local test environment
setup using `scripts/setup_test_env.sh`. Update README to document the
new workflow, clarify terminology by consistently referring to the
persistent environment as a "testnet cluster," and improve step-by-step
instructions for repeated testing workflows.

Author: mkoura

Makefile

@@ -17,6 +17,15 @@ reinstall-editable:
 	fi
 	@./scripts/clusterlib_reinstall_editable.sh "$(repo)"
 
+# set up test environment
+.PHONY: test-env
+test-env:
+	@if [ -z "$(era)" ]; then \
+		echo "Usage: make test-env era=conway" >&2; \
+		exit 1; \
+	fi
+	@./scripts/setup_test_env.sh "$(era)"
+
 # initialize linters
 .PHONY: init_lint
 init_lint:

README.md

@@ -41,7 +41,7 @@ Run tests easily using GitHub Actions:
   ./.github/regression.sh
   ```
 
-> ℹ️ **NOTE:** Using `CI_BYRON_CLUSTER` will cause the local cluster to progress from Byron ➝ Conway, which takes approximately 40 minutes.
+> ℹ️ **NOTE:** Using `CI_BYRON_CLUSTER` will cause the local testnet cluster to progress from Byron ➝ Conway, which takes approximately 40 minutes.
 
 ---
 
@@ -65,49 +65,49 @@ Run tests easily using GitHub Actions:
 
 ---
 
-## 🔁 Persistent Local Cluster for Repeated Testing
+## 🔁 Persistent Local Testnet for Repeated Testing
 
-For workflows requiring repeated test runs on a persistent cluster:
+For workflows requiring repeated test runs on a persistent testnet cluster:
 
 1. Start a Nix shell:
 
   ```sh
   nix flake update --accept-flake-config --override-input cardano-node github:IntersectMBO/cardano-node/master
   nix develop --accept-flake-config
+  /bin/bash --login  # fresh shell needed
   ```
 
-2. Prepare the test environment:
+2. Set up the local test environment:
+
+  ```sh
+  make test-env era=conway
+  ```
+
+3. Activate the environment:
 
   ```sh
-  ./scripts/setup_test_env.sh conway
   source ./dev_workdir/.source
   ```
 
-3. Launch the cluster:
+4. Launch the local testnet cluster:
 
   ```sh
   ./dev_workdir/conway_fast/start-cluster
   ```
 
-4. Run your tests:
+5. Run your tests:
 
   ```sh
   pytest -s -k test_minting_one_token cardano_node_tests/tests/tests_plutus
   pytest -s --log-level=debug -k test_minting_one_token cardano_node_tests/tests/tests_plutus
   ```
 
-5. Stop the cluster:
+6. Stop the testnet cluster:
 
   ```sh
   ./dev_workdir/conway_fast/stop-cluster
   ```
 
-To reuse the same environment in another shell:
-
-```sh
-source ./dev_workdir/.source
-```
-
 ---
 
 ## ⚙️ Test Configuration Variables
@@ -186,7 +186,7 @@ cd ../cardano-node-tests
 source .source.dev
 ```
 
-### 🧱 Start Development Cluster
+### 🧱 Start Development Testnet Cluster
 
 ```sh
 prepare-cluster-scripts -c -d dev_workdir/conway_fast -t conway_fast

scripts/setup_test_env.sh

@@ -54,8 +54,8 @@ export DEV_CLUSTER_RUNNING=1
 export CLUSTERS_COUNT=1
 export FORBID_RESTART=1
 export NO_ARTIFACTS=1
-export CLUSTER_ERA="${CLUSTER_ERA:-""}"
-export COMMAND_ERA="${COMMAND_ERA:-""}"
+export CLUSTER_ERA="${CLUSTER_ERA:-}"
+export COMMAND_ERA="${COMMAND_ERA:-}"
 EoF
 
 # shellcheck disable=SC1091