fix: remove buffer #103
Merged
fix: remove buffer #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes all Node.js Buffer usage from the codebase and replaces it with the cross-platform Bytes utility module, improving browser compatibility.
- Replaces
Buffer.from(data, "hex")withBytes.fromHex(data) - Replaces
Buffer.from(data).toString("hex")withBytes.toHex(data) - Adds necessary imports for the
Bytesmodule in all affected files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/evolution/src/sdk/provider/internal/Ogmios.ts |
Replaced Buffer.from().toString("hex") with Bytes.toHex() for datum hash conversion |
packages/evolution/src/sdk/provider/internal/MaestroEffect.ts |
Replaced Buffer.from(hex) with Bytes.fromHex() for transaction CBOR conversion |
packages/evolution/src/sdk/provider/internal/KupmiosEffects.ts |
Replaced Buffer.from(hex) with Bytes.fromHex() for datum hash and script bytes decoding |
packages/evolution/src/sdk/builders/TxBuilderImpl.ts |
Replaced Buffer.from().toString("hex") with Bytes.toHex() for key hash hex conversion in fake witness set building |
packages/evolution/src/core/Assets/index.ts |
Replaced Buffer.from(hex) with Bytes.fromHex() for policy ID and asset name decoding |
.changeset/remove-buffer-usage.md |
Added changeset documentation describing the changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.