Address feedback from Audit 6 #665
Description
Audit 6
Conway Ledger July 30, 2024 - Review 6 (Sec 12)
Goals.
- Compare March 2024 version of Conway ledger with the July 30th version and list and summarise each difference. Go through each of the differences and:
- Check against CIP-1694 (https://cips.cardano.org/cip/CIP-1694)
- Check for possible issues
General questions and comments about the differences.
-
Definitions for NewEpochEnv and NewEpochState removed from Fig 37 (previously Fig 31).
-
Addition of applyRUpd in p40 (outside of any Figures)
-
Since the wording in p40 has not changed, are the removal of NewEpochEnv and NewEpochState from Fig 37 intentional?
-
Similarly, is applyRUpd meant to be outside of figures? Suggestion Add clarifying text on Fig 37 and applyRUpd.
-
Fig 38 (Functions for computing stake distributions) is added.
-
Fig 39: trWithdrawals/totWithdrawals moved from being evaluated before removedGovActions and govActionReturns to being evaluated after these two.
-
Fig 39: In computation of treasury amounts ("treasury = acnt.treasury..."), "fees" is no longer added to the treasury.
-
Fig 39: Some other changes that seem syntactic rather than semantic.
-
Currently there is no explanation for Fig 38 int he text. Suggestion to add such an explanation. Is the only difference here that the proposal deposits should also be counted as stake?
-
Possible issue/Suggestion. It would help clarify to add an explanation to why "fees" (from UTxOState) is no longer added to the computation of the treasury in Fig 39.
- The previous version's Sec 13 (Blockchain layer) and Sec 14 (Properties) have been removed.
New Appendices: Appendix B and Appendix C
-
In sentence "To form an EnactState, some governance action IDs need to be provided." Is the reason some governance action IDs need to be provided because of prevAction needing an ID to hash?
-
Possible issue/clarification question. In bootstrapping the governance system (App C), who will be part of the constitution committee, if only TriggerHF, ChangeParams, and Info are allowed (and UpdateCommittee is not allowed)? It seems that unless there is already a CC, this might be a problem since TriggerHF and ChangeParams both need the CC to approve. Suggestion. Describe where the initial CC comes from in App C.