Skip to content

Commit 1a5ba54

Browse files
Merge pull request #247 from IntersectMBO/fix---Proposal-budget-submission]-Missing-test-IDs
fix/ [Proposal budget submission] Missing test IDs (#3339)
2 parents 64301e5 + ffddd68 commit 1a5ba54

File tree

2 files changed

+112
-59
lines changed

2 files changed

+112
-59
lines changed

pdf-ui/CHANGELOG.md

Lines changed: 106 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -10,138 +10,188 @@ changes.
1010

1111
## [v0.7.0-beta-27](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.7.0-beta-27) 2025-05-14
1212

13-
- feat: [Disable interactions on budget proposals](https://github.com/IntersectMBO/govtool/issues/3614)
14-
- fix: [Fix “Save Draft” Button Disabled When Valid Guardrails Script is Provided in Constitution Proposal](https://github.com/IntersectMBO/govtool/issues/3531)
15-
- fix: [Budget Submission Allows Negative Values & Restricts String](https://github.com/IntersectMBO/govtool/issues/3477)
16-
- fix: [Username Modal Incorrectly Pops Up on Wallet Disconnect State](https://github.com/IntersectMBO/govtool/issues/3187)
17-
- fix: [Bug: "Other" Contracting Method Details Not Displayed in Review](https://github.com/IntersectMBO/govtool/issues/3553)
18-
- fix: [Missing Test IDs for PDF components](https://github.com/IntersectMBO/govtool/issues/2988)
13+
- feat: [Disable interactions on budget proposals](https://github.com/IntersectMBO/govtool/issues/3614)
14+
- fix: [Fix “Save Draft” Button Disabled When Valid Guardrails Script is Provided in Constitution Proposal](https://github.com/IntersectMBO/govtool/issues/3531)
15+
- fix: [Budget Submission Allows Negative Values & Restricts String](https://github.com/IntersectMBO/govtool/issues/3477)
16+
- fix: [Username Modal Incorrectly Pops Up on Wallet Disconnect State](https://github.com/IntersectMBO/govtool/issues/3187)
17+
- fix: [Bug: "Other" Contracting Method Details Not Displayed in Review](https://github.com/IntersectMBO/govtool/issues/3553)
18+
- fix: [Missing Test IDs for PDF components](https://github.com/IntersectMBO/govtool/issues/2988)
19+
- fix: [Proposal budget submission Missing test IDs] (https://github.com/IntersectMBO/govtool/issues/3339)
1920

2021
## [v0.7.0](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.7.0) 2025-03-31
21-
### Add Budget Discussion functionality [Proposal discussion expansion for DReps](https://github.com/IntersectMBO/govtool/issues/3196)
2222

23+
### Add Budget Discussion functionality [Proposal discussion expansion for DReps](https://github.com/IntersectMBO/govtool/issues/3196)
2324

2425
## [v0.6.3](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.6.3) 2025-02-24
25-
### Fixed
26-
- [Fixed reply on comments #3067](https://github.com/IntersectMBO/govtool/issues/3067)
27-
- [Fixed saving drafts on create proposal page](https://github.com/IntersectMBO/govtool/issues/3045)
2826

27+
### Fixed
28+
29+
- [Fixed reply on comments #3067](https://github.com/IntersectMBO/govtool/issues/3067)
30+
- [Fixed saving drafts on create proposal page](https://github.com/IntersectMBO/govtool/issues/3045)
2931

3032
## [v0.6.2](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.6.2) 2025-02-19
31-
### Fixed
32-
- [Fix Inaccurate Validation and UI Issues in Constitution Type Proposal Form](https://github.com/IntersectMBO/govtool/issues/2965)
33-
- [Fixed stucking After Deselecting Guardrails Script with Invalid URL](https://github.com/IntersectMBO/govtool/issues/2992)
34-
- [Fixed reflection of Updated Constitution URL, Gradual Script Hash, and URL on Proposal Edit](https://github.com/IntersectMBO/govtool/issues/2967)
35-
- [Added test IDs for PDF components](https://github.com/IntersectMBO/govtool/issues/2988)
36-
- [Fixed Cursor Jumping to End & No Soft Line Breaks](https://github.com/IntersectMBO/govtool/issues/3019)
3733

34+
### Fixed
35+
36+
- [Fix Inaccurate Validation and UI Issues in Constitution Type Proposal Form](https://github.com/IntersectMBO/govtool/issues/2965)
37+
- [Fixed stucking After Deselecting Guardrails Script with Invalid URL](https://github.com/IntersectMBO/govtool/issues/2992)
38+
- [Fixed reflection of Updated Constitution URL, Gradual Script Hash, and URL on Proposal Edit](https://github.com/IntersectMBO/govtool/issues/2967)
39+
- [Added test IDs for PDF components](https://github.com/IntersectMBO/govtool/issues/2988)
40+
- [Fixed Cursor Jumping to End & No Soft Line Breaks](https://github.com/IntersectMBO/govtool/issues/3019)
3841

39-
- [Sign data is not executed](https://github.com/IntersectMBO/govtool/issues/3392)
42+
- [Sign data is not executed](https://github.com/IntersectMBO/govtool/issues/3392)
4043

4144
## [v0.6.1](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.6.1) 2025-02-12
42-
### Fixed
43-
- [Test ID for Sort Button](https://github.com/IntersectMBO/govtool/issues/2838)
44-
- [Fix Show all proposal Details on Details Page](https://github.com/IntersectMBO/govtool/issues/2831)
45-
- Added new type Constitution in proposal
45+
46+
### Fixed
47+
48+
- [Test ID for Sort Button](https://github.com/IntersectMBO/govtool/issues/2838)
49+
- [Fix Show all proposal Details on Details Page](https://github.com/IntersectMBO/govtool/issues/2831)
50+
- Added new type Constitution in proposal
4651

4752
## [v0.6.0](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.12) 2025-02-07
48-
### Added
49-
- Propose New Constitution or Guardrails Script Governance Action for an offchain discussion and submit it as a governance action [Issue #2258](https://github.com/IntersectMBO/govtool/issues/2833)
50-
### Fixed
51-
- Removed unnecessary fields [Issue #2258](https://github.com/IntersectMBO/govtool/issues/2833)
53+
54+
### Added
55+
56+
- Propose New Constitution or Guardrails Script Governance Action for an offchain discussion and submit it as a governance action [Issue #2258](https://github.com/IntersectMBO/govtool/issues/2833)
57+
58+
### Fixed
59+
60+
- Removed unnecessary fields [Issue #2258](https://github.com/IntersectMBO/govtool/issues/2833)
5261

5362
## [v0.5.11](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.11) 2025-01-29
54-
### Fixed
55-
- Proposal rendering fix
63+
64+
### Fixed
65+
66+
- Proposal rendering fix
5667

5768
## [v0.5.10](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.10) 2025-01-29
58-
### Fixed
59-
- Some typo fixes.
69+
70+
### Fixed
71+
72+
- Some typo fixes.
6073

6174
## [v0.5.9](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.9) 2025-01-28
62-
### Fixed
63-
- Added "Read More" on proposal page if Character Count is bigger den 500 [Issue #2649](https://github.com/IntersectMBO/govtool/issues/2649)
75+
76+
### Fixed
77+
78+
- Added "Read More" on proposal page if Character Count is bigger den 500 [Issue #2649](https://github.com/IntersectMBO/govtool/issues/2649)
6479

6580
## [v0.5.8](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.8) 2025-01-27
81+
6682
### Added -
67-
### Fixed
68-
- Temporaly fix for Sorting Icon [Issue #2650](https://github.com/IntersectMBO/govtool/issues/2650)
83+
84+
### Fixed
85+
86+
- Temporaly fix for Sorting Icon [Issue #2650](https://github.com/IntersectMBO/govtool/issues/2650)
6987

7088
## [v0.5.7](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.7) 2025-01-19
89+
7190
### Added -
72-
### Fixed
73-
- Search Field Bug, Searches Fail with Trailing Spaces [Issue #2472](https://github.com/IntersectMBO/govtool/issues/2471)
74-
- Markdown Styling Issues in Proposal Formatting [Issue #2651](https://github.com/IntersectMBO/govtool/issues/2651)
91+
92+
### Fixed
93+
94+
- Search Field Bug, Searches Fail with Trailing Spaces [Issue #2472](https://github.com/IntersectMBO/govtool/issues/2471)
95+
- Markdown Styling Issues in Proposal Formatting [Issue #2651](https://github.com/IntersectMBO/govtool/issues/2651)
7596

7697
## [v0.5.6](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.6) 2025-01-09
98+
7799
### Added -
78-
### Fixed
79-
- Changed copy on landing page [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2544)
80-
- Fixed support for IPFS [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2495)
100+
101+
### Fixed
102+
103+
- Changed copy on landing page [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2544)
104+
- Fixed support for IPFS [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2495)
81105

82106
### Changed -
83-
### Removed -
84107

108+
### Removed -
85109

86110
## [v0.5.5](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.5) 2024-12-06
87111

88112
### Added -
113+
89114
### Fixed -
90-
- Fix display Stake Address and Amount in Draft [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2438)
91-
- Fix Test Id names in review form [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
115+
116+
- Fix display Stake Address and Amount in Draft [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2438)
117+
- Fix Test Id names in review form [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
118+
92119
### Changed -
120+
93121
### Removed -
94122

95123
## [v0.5.4](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.4) 2024-12-05
96124

97125
### Added -
126+
98127
### Fixed -
99-
- Fix display Stake Address and Amount in Draft [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2438)
100-
- Fix Test Id names in review form [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
101-
- Fix #2357 Display only last Inactive pool [Issue #2357](https://github.com/IntersectMBO/govtool/issues/2357)
128+
129+
- Fix display Stake Address and Amount in Draft [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2438)
130+
- Fix Test Id names in review form [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
131+
- Fix #2357 Display only last Inactive pool [Issue #2357](https://github.com/IntersectMBO/govtool/issues/2357)
132+
102133
### Changed -
134+
103135
### Removed -
104136

105137
## [v0.5.3](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.3) 2024-12-04
106138

107139
### Added -
140+
108141
### Fixed -
109-
- Changed input field test id for multiple addresses and amount. [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
142+
143+
- Changed input field test id for multiple addresses and amount. [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
144+
110145
### Changed -
146+
111147
### Removed -
112148

113149
## [v0.5.2](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.2) 2024-12-02
114150

115151
### Added -
152+
116153
### Fixed -
117-
- Changed params for submitting GA so now it is change to multiple addresses. [issue #2447](https://github.com/IntersectMBO/govtool/issues/2447)
118-
- After successful submission of GA modal close button will redirect to dashboard instead of allowing to submit again.[issue #2264](https://github.com/IntersectMBO/govtool/issues/2264)
154+
155+
- Changed params for submitting GA so now it is change to multiple addresses. [issue #2447](https://github.com/IntersectMBO/govtool/issues/2447)
156+
- After successful submission of GA modal close button will redirect to dashboard instead of allowing to submit again.[issue #2264](https://github.com/IntersectMBO/govtool/issues/2264)
157+
119158
### Changed -
159+
120160
### Removed -
121161

122162
## [v0.5.1](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.1) 2024-11-29
123163

124164
### Added -
165+
125166
### Fixed -
126-
- Added validation for Receiving Stake Address and Amount on creating Treasury Proposal [Issue #2435](https://github.com/IntersectMBO/govtool/issues/2435)
127-
- Fixed test id to match suggested format [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
128-
- Fixed review Stake Addresses and Amounts in Treasury Proposal Review Step and Draft [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2438)
129-
- Fixed edit Stake Addresses and Amounts in Treasury Proposal Review edit form
167+
168+
- Added validation for Receiving Stake Address and Amount on creating Treasury Proposal [Issue #2435](https://github.com/IntersectMBO/govtool/issues/2435)
169+
- Fixed test id to match suggested format [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
170+
- Fixed review Stake Addresses and Amounts in Treasury Proposal Review Step and Draft [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2438)
171+
- Fixed edit Stake Addresses and Amounts in Treasury Proposal Review edit form
172+
130173
### Changed -
174+
131175
### Removed -
132176

133177
## [v0.5.0](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.1) 2024-11-26
134178

135179
### Added -
180+
136181
### Fixed -
137-
### Changed
138-
- Allows withdrawal of Ada funds from the Cardano treasury to one or many reward accounts (reward/stake addresses) [Issue #2378](https://github.com/IntersectMBO/govtool/issues/2378)
182+
183+
### Changed
184+
185+
- Allows withdrawal of Ada funds from the Cardano treasury to one or many reward accounts (reward/stake addresses) [Issue #2378](https://github.com/IntersectMBO/govtool/issues/2378)
186+
139187
### Removed -
140188

141189
## [tag-xxxx](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/xxxx) 202x-xx-xx
142190

143-
### Added -
191+
### Added -
192+
144193
### Fixed -
194+
145195
### Changed -
146-
### Removed -
147196

197+
### Removed -

pdf-ui/src/components/CommentCard/UsernameSection/index.jsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const UsernameSection = ({ drepData, comment }) => {
1818
{comment?.attributes?.user_is_validated === true ? (
1919
<ValidationCheckmark />
2020
) : null}
21-
{drepData?.view && <Chip label='DRep' />}
21+
{drepData?.view && <Chip data-testid='dRep-tag' label='DRep' />}
2222
</Box>
2323

2424
<Box
@@ -34,7 +34,10 @@ const UsernameSection = ({ drepData, comment }) => {
3434
target='_blank'
3535
rel='noopener noreferrer'
3636
>
37-
<Typography variant='caption'>
37+
<Typography
38+
variant='caption'
39+
data-testid='dRep-given-name'
40+
>
3841
{drepData?.givenName || ''}
3942
</Typography>
4043
</Link>
@@ -46,7 +49,7 @@ const UsernameSection = ({ drepData, comment }) => {
4649
target='_blank'
4750
rel='noopener noreferrer'
4851
>
49-
<Typography variant='caption'>
52+
<Typography variant='caption' data-testid='dRep-id'>
5053
{drepData?.view?.slice(0, 26) + '...' || ''}
5154
</Typography>
5255
</Link>

0 commit comments

Comments
 (0)