Allow Opening Governance Actions in New Tab from Live Voting Page

Author: Adam Tomaszczyk

govtool/frontend/src/App.tsx

@@ -63,28 +63,44 @@ export default () => {
   }, []);
 
   const checkTheWalletIsActive = useCallback(() => {
-    const hrefCondition =
-      window.location.pathname === PATHS.home ||
-      window.location.pathname === PATHS.governanceActions ||
-      window.location.pathname === PATHS.governanceActionsAction;
+    const isWalletAvailable = () =>
+        window.cardano && walletName && Object.keys(window.cardano).includes(walletName);
 
-    const walletName = getItemFromLocalStorage(`${WALLET_LS_KEY}_name`);
-    if (window.cardano) {
-      const walletExtensions = Object.keys(window.cardano);
-      if (walletName && walletExtensions.includes(walletName)) {
-        enable(walletName);
-        return;
+    const cleanUpWalletData = () => {
+      removeItemFromLocalStorage(`${WALLET_LS_KEY}_name`);
+      removeItemFromLocalStorage(`${WALLET_LS_KEY}_stake_key`);
+    };
+
+    const waitForWalletExtension = async () => {
+      const timeout = 5000;
+      const interval = 100;
+      const startTime = Date.now();
+
+      while (Date.now() - startTime < timeout) {
+        if (isWalletAvailable()) {
+          enable(walletName);
+          return;
+        }
+        await new Promise(resolve => setTimeout(resolve, interval));
       }
-    }
-    if (
-      (!window.cardano && walletName) ||
-      (walletName && !Object.keys(window.cardano).includes(walletName))
-    ) {
-      if (!hrefCondition) {
+
+      if (!isOnAllowedPage) {
         navigate(PATHS.home);
       }
-      removeItemFromLocalStorage(`${WALLET_LS_KEY}_name`);
-      removeItemFromLocalStorage(`${WALLET_LS_KEY}_stake_key`);
+      cleanUpWalletData();
+    };
+
+    const isOnAllowedPage = [PATHS.home, PATHS.governanceActions, PATHS.governanceActionsAction]
+        .includes(window.location.pathname);
+
+    const walletName = getItemFromLocalStorage(`${WALLET_LS_KEY}_name`);
+
+    if (!walletName) return;
+
+    if (isWalletAvailable()) {
+      enable(walletName);
+    } else {
+      waitForWalletExtension();
     }
   }, []);
 

govtool/frontend/src/components/molecules/GovernanceActionCard.tsx

@@ -1,5 +1,6 @@
 import { FC } from "react";
 import { Box, Skeleton } from "@mui/material";
+import { Link, useLocation } from "react-router-dom";
 
 import { Button } from "@atoms";
 import {
@@ -39,7 +40,6 @@ export const GovernanceActionCard: FC<ActionTypeProps> = ({
   inProgress = false,
   expiryDate,
   expiryEpochNo,
-  onClick,
   createdDate,
   createdEpochNo,
   txHash,
@@ -58,6 +58,8 @@ export const GovernanceActionCard: FC<ActionTypeProps> = ({
     bech32Prefix: "gov_action",
   });
 
+  const location = useLocation();
+
   return (
     <Box
       sx={{
@@ -150,7 +152,8 @@ export const GovernanceActionCard: FC<ActionTypeProps> = ({
           <Skeleton width="100%" height="40px" sx={{ borderRadius: "20px" }} />
         ) : (
           <Button
-            onClick={onClick}
+            component={Link}
+            to={`${location.pathname}/${govActionId}`}
             variant={inProgress ? "outlined" : "contained"}
             size="large"
             sx={{

govtool/frontend/src/components/organisms/GovernanceActionsToVote.tsx

@@ -1,12 +1,10 @@
-import { useNavigate, generatePath } from "react-router-dom";
 import { Box } from "@mui/material";
 
 import { Typography } from "@atoms";
-import { PATHS } from "@consts";
 import { useCardano } from "@context";
 import { useScreenDimension, useTranslation } from "@hooks";
 import { ProposalData } from "@models";
-import { getProposalTypeTitle, getFullGovActionId } from "@utils";
+import { getProposalTypeTitle } from "@utils";
 import { Slider, ValidatedGovernanceActionCard } from "@organisms";
 
 type GovernanceActionsToVoteProps = {
@@ -25,7 +23,6 @@ export const GovernanceActionsToVote = ({
   sorting,
 }: GovernanceActionsToVoteProps) => {
   const { pendingTransaction } = useCardano();
-  const navigate = useNavigate();
   const { isMobile, pagePadding } = useScreenDimension();
   const { t } = useTranslation();
 
@@ -64,29 +61,6 @@ export const GovernanceActionsToVote = ({
                         pendingTransaction.vote?.resourceId ===
                           `${action.txHash ?? ""}${action.index ?? ""}`
                       }
-                      onClick={() => {
-                        navigate(
-                          onDashboard
-                            ? generatePath(
-                                PATHS.dashboardGovernanceActionsAction,
-                                {
-                                  proposalId: getFullGovActionId(
-                                    action.txHash,
-                                    action.index,
-                                  ),
-                                },
-                              )
-                            : PATHS.governanceActionsAction.replace(
-                                ":proposalId",
-                                getFullGovActionId(action.txHash, action.index),
-                              ),
-                          {
-                            state: {
-                              proposal: action,
-                            },
-                          },
-                        );
-                      }}
                     />
                   </div>
                 ))}

govtool/frontend/src/components/organisms/Slider.tsx

@@ -1,5 +1,5 @@
-import { useCallback, useEffect, useMemo, useState } from "react";
-import { generatePath, useNavigate } from "react-router-dom";
+import { useEffect, useMemo, useState } from "react";
+import { generatePath, Link } from "react-router-dom";
 import { Box } from "@mui/material";
 import { KeenSliderOptions } from "keen-slider";
 import "keen-slider/keen-slider.min.css";
@@ -39,7 +39,6 @@ export const Slider = ({
   const [isSliderInitialized, setIsSliderInitialized] = useState(false);
 
   const { isMobile, screenWidth } = useScreenDimension();
-  const navigate = useNavigate();
   const { pendingTransaction } = useCardano();
   const { t } = useTranslation();
 
@@ -77,19 +76,6 @@ export const Slider = ({
     instanceRef.current?.moveToIdx(0);
   };
 
-  const onClickShowAll = useCallback(() => {
-    navigate(
-      generatePath(
-        onDashboard
-          ? PATHS.dashboardGovernanceActionsCategory
-          : PATHS.governanceActionsCategory,
-        {
-          category: navigateKey,
-        },
-      ),
-    );
-  }, [navigate, onDashboard]);
-
   useEffect(() => {
     if (instanceRef.current) {
       setIsSliderInitialized(true);
@@ -129,6 +115,15 @@ export const Slider = ({
           <Typography variant="title2">{title}</Typography>
           {(notSlicedDataLength > 6 || (isMobile && isShowAll)) && (
             <Button
+              component={Link}
+              to={`${generatePath(
+                  onDashboard
+                      ? PATHS.dashboardGovernanceActionsCategory
+                      : PATHS.governanceActionsCategory,
+                  {
+                    category: navigateKey,
+                  },
+              )}`}
               variant="contained"
               size="medium"
               sx={{
@@ -139,7 +134,6 @@ export const Slider = ({
                 minWidth: 93,
                 "&:hover": { backgroundColor: arcticWhite },
               }}
-              onClick={onClickShowAll}
             >
               {t("slider.showAll")}
             </Button>

govtool/frontend/src/components/organisms/ValidatedGovernanceActionCard.tsx

@@ -2,7 +2,7 @@ import { useState, useEffect } from "react";
 
 import { useValidateMutation } from "@/hooks/mutations";
 import { MetadataStandard, ProposalData } from "@/models";
-import { GovernanceActionCard } from "../molecules";
+import { GovernanceActionCard } from "@molecules";
 
 type ActionTypeProps = Omit<
   ProposalData,
@@ -14,7 +14,6 @@ type ActionTypeProps = Omit<
   | "rationale"
   | "motivation"
 > & {
-  onClick?: () => void;
   inProgress?: boolean;
 };
 export const ValidatedGovernanceActionCard = (props: ActionTypeProps) => {