Skip to content

Commit 1097c02

Browse files
authored
Merge pull request #3883 from IntersectMBO/3879-parameters-page-on-live-voting-broken-p0
(fix#3879): broken parameters on Live Voting page
2 parents b8b6687 + 897a21a commit 1097c02

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

govtool/frontend/src/components/molecules/GovernanceActionNewCommitteeDetailsTabContent.tsx

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@ type CCMember = {
1313
newExpirationEpoch?: number;
1414
};
1515

16+
function isArrayOfStrings(value: unknown): value is string[] {
17+
return (
18+
Array.isArray(value) && value.every((item) => typeof item === "string")
19+
);
20+
}
21+
1622
export const GovernanceActionNewCommitteeDetailsTabContent = ({
1723
details,
1824
}: Pick<ProposalData, "details">) => {
@@ -38,6 +44,10 @@ export const GovernanceActionNewCommitteeDetailsTabContent = ({
3844
newExpirationEpoch: member.newExpirationEpoch,
3945
}));
4046

47+
const membersToBeRemoved = isArrayOfStrings(details?.membersToBeRemoved)
48+
? details.membersToBeRemoved
49+
: [];
50+
4151
return (
4252
<Box>
4353
{membersToBeAdded.length > 0 && (
@@ -78,7 +88,7 @@ export const GovernanceActionNewCommitteeDetailsTabContent = ({
7888
))}
7989
</Box>
8090
)}
81-
{(details?.membersToBeRemoved as string[]).length > 0 && (
91+
{membersToBeRemoved.length > 0 && (
8292
<Box mb="32px">
8393
<Typography
8494
sx={{
@@ -93,8 +103,8 @@ export const GovernanceActionNewCommitteeDetailsTabContent = ({
93103
>
94104
{t("govActions.membersToBeRemoved")}
95105
</Typography>
96-
{(details?.membersToBeRemoved as string[]).map((hash) => (
97-
<Box display="flex" flexDirection="row">
106+
{membersToBeRemoved.map((hash) => (
107+
<Box display="flex" flexDirection="row" key={hash}>
98108
<Typography
99109
sx={{
100110
fontSize: 16,

govtool/frontend/src/components/organisms/DrawerMobile.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ export const DrawerMobile = ({
9090
<MenuNavItem
9191
closeDrawer={() => setIsDrawerOpen(false)}
9292
navItem={navItem}
93+
key={navItem.label}
9394
/>
9495
);
9596
}

0 commit comments

Comments
 (0)