feat: update proposal tests to include hardfork proposal

JosephRana11 · kneerose · commit 160aaf18ff05 · 2025-06-26T10:25:57.000+05:45
diff --git a/tests/govtool-frontend/playwright/lib/constants/auth.ts b/tests/govtool-frontend/playwright/lib/constants/auth.ts
@@ -20,6 +20,7 @@ export const proposal06AuthFile = ".auth/proposal06.json";
 export const proposal07AuthFile = ".auth/proposal07.json";
 export const proposal08AuthFile = ".auth/proposal08.json";
 export const proposal09AuthFile = ".auth/proposal09.json";
+export const proposal10AuthFile = '.auth/proposal10.json';
 
 export const proposalSubmissionAuthFile = ".auth/proposalSubmission.json";
 
diff --git a/tests/govtool-frontend/playwright/lib/constants/staticWallets.ts b/tests/govtool-frontend/playwright/lib/constants/staticWallets.ts
@@ -25,12 +25,13 @@ export const proposal06Wallet: StaticWallet = staticWallets[15];
 export const proposal07Wallet: StaticWallet = staticWallets[16];
 export const proposal08Wallet: StaticWallet = staticWallets[17];
 export const proposal09Wallet: StaticWallet = staticWallets[18];
+export const proposal10Wallet: StaticWallet = staticWallets[19]
 
-export const budgetProposal01Wallet: StaticWallet = staticWallets[19];
-export const budgetProposal02Wallet: StaticWallet = staticWallets[20];
-export const budgetProposal03Wallet: StaticWallet = staticWallets[21];
-export const budgetProposal04Wallet: StaticWallet = staticWallets[22];
-export const budgetProposal05Wallet: StaticWallet = staticWallets[23];
+export const budgetProposal01Wallet: StaticWallet = staticWallets[20];
+export const budgetProposal02Wallet: StaticWallet = staticWallets[21];
+export const budgetProposal03Wallet: StaticWallet = staticWallets[22];
+export const budgetProposal04Wallet: StaticWallet = staticWallets[23];
+export const budgetProposal05Wallet: StaticWallet = staticWallets[24];
 
 export const adaHolderWallets = [
   adaHolder01Wallet,
diff --git a/tests/govtool-frontend/playwright/lib/helpers/auth.ts b/tests/govtool-frontend/playwright/lib/helpers/auth.ts
@@ -13,12 +13,14 @@ import {
   proposal07Wallet,
   proposal08Wallet,
   proposal09Wallet,
+  proposal10Wallet,
 } from "@constants/staticWallets";
 import {
   proposal05AuthFile,
   proposal07AuthFile,
   proposal08AuthFile,
   proposal09AuthFile,
+  proposal10AuthFile,
 } from "@constants/auth";
 
 interface CreateUserProps {
@@ -122,5 +124,10 @@ export const getDraftProposalWalletAndState = (proposalType: string) => {
         storageState: proposal09AuthFile,
         wallet: proposal09Wallet,
       };
+    case ProposalType.hardFork:
+      return {
+        storageState : proposal10AuthFile,
+        wallet: proposal10Wallet
+      }
   }
 };
diff --git a/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts b/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts
@@ -30,6 +30,8 @@ const formErrors = {
   constitutionalUrl: "prop-constitution-url-text-error",
   guardrailsScriptUrl: "prop-guardrails-script-url-input-error",
   link: "link-0-url-input-error",
+  majorError : "major-error",
+  minorError : "minor-error"
 };
 
 export default class ProposalSubmissionPage {
@@ -61,6 +63,9 @@ export default class ProposalSubmissionPage {
   readonly motionOfNoConfidenceBtn = this.page.getByTestId(
     "motion of no confidence-button"
   );
+  readonly hardForkBtn = this.page.getByTestId(
+    "hard fork-button"
+  )
   readonly editSubmissionButton = this.page.getByTestId(
     "edit-submission-button"
   );
@@ -129,6 +134,8 @@ export default class ProposalSubmissionPage {
   );
   readonly linkTextContent = this.page.getByTestId("link-0-text-content");
   readonly linkUrlContent = this.page.getByTestId("link-0-url-content");
+  readonly majorVersionContent = this.page.getByTestId("major-version-content")
+  readonly minorVersionContent = this.page.getByTestId("minor-version-content")
 
   constructor(private readonly page: Page) {}
 
@@ -176,9 +183,15 @@ export default class ProposalSubmissionPage {
     if (governanceProposal.proposal_links != null) {
       await this.fillProposalLinks(governanceProposal.proposal_links);
     }
+
+    if(governanceProposal.gov_action_type_id == 4){
+      await this.fillHardForkFields(governanceProposal)
+    } 
   }
 
   async fillupForm(governanceProposal: ProposalCreateRequest) {
+
+    console.log(governanceProposal.gov_action_type_id)
     await this.governanceActionType.click();
 
     if (governanceProposal.gov_action_type_id === 0) {
@@ -190,8 +203,10 @@ export default class ProposalSubmissionPage {
       if (governanceProposal.has_guardrails) {
         await this.guardrailsScriptCheckbox.click();
       }
-    } else {
+    } else if (governanceProposal.gov_action_type_id === 3) {
       await this.motionOfNoConfidenceBtn.click();
+    } else {
+      await this.hardForkBtn.click()
     }
 
     await this.fillupFormWithTypeSelected(governanceProposal);
@@ -242,6 +257,11 @@ export default class ProposalSubmissionPage {
     }
   }
 
+  async fillHardForkFields(hardForkProposal : ProposalCreateRequest){
+    await this.minorInput.fill(hardForkProposal.prop_min_version.toString())
+    await this.majorInput.fill(hardForkProposal.prop_major_version.toString())
+  }
+
   async getAllDrafts() {
     await expect(
       this.page.locator('[data-testid^="draft-"][data-testid$="-card"]')
@@ -349,6 +369,27 @@ export default class ProposalSubmissionPage {
       }).toBeHidden();
     }
 
+    if (governanceProposal.gov_action_type_id === 4) {
+      const isMajorErrorVisible = await this.page
+        .getByTestId(formErrors.majorError)
+        .isVisible();
+      const isMinorErrorVisible = await this.page
+        .getByTestId(formErrors.minorError)
+        .isVisible();
+
+      await expect(this.page.getByTestId(formErrors.majorError), {
+        message: isMajorErrorVisible 
+          ? 'Major version error should be hidden'
+          : 'Major version error is correctly hidden'
+      }).toBeHidden();
+
+      await expect(this.page.getByTestId(formErrors.minorError), {
+        message: isMinorErrorVisible 
+          ? 'Minor version error should be hidden'
+          : 'Minor version error is correctly hidden'
+      }).toBeHidden();
+    }
+
     await expect(this.page.getByTestId(formErrors.link), {
       message:
         isLinkErrorVisible &&
@@ -461,6 +502,11 @@ export default class ProposalSubmissionPage {
       }).toBeVisible();
     }
 
+    if (governanceProposal.gov_action_type_id === 4){
+      await expect(this.page.getByTestId(formErrors.majorError)).toBeVisible()
+      await expect(this.page.getByTestId(formErrors.minorError)).toBeVisible()
+    }
+
     await expect(this.continueBtn).toBeDisabled();
   }
 
@@ -516,6 +562,11 @@ export default class ProposalSubmissionPage {
         }
       }
     }
+    if (proposalType == ProposalType.hardFork){
+      proposal.prop_min_version = faker.number.float({min:0 , max:100}).toString()
+      proposal.prop_major_version = faker.number.float({min:0 , max:100}).toString()
+    }
+
     return proposal;
   }
 
@@ -550,6 +601,13 @@ export default class ProposalSubmissionPage {
       proposal.prop_guardrails_script_url = invalid.url();
       proposal.prop_guardrails_script_hash = faker.string.alphanumeric(64);
     }
+
+    if (proposalType === ProposalType.hardFork){
+      proposal.prop_min_version = invalid.amount()
+      proposal.prop_major_version = invalid.amount()
+    }
+
+
     return proposal;
   }
 
diff --git a/tests/govtool-frontend/playwright/lib/types.ts b/tests/govtool-frontend/playwright/lib/types.ts
@@ -196,6 +196,8 @@ export type ProposalCreateRequest = {
   prop_guardrails_script_hash?: string;
   has_guardrails?: boolean;
   is_draft: boolean;
+  prop_min_version? : string;
+  prop_major_version? : string;
 };
 export type ProposedGovAction = {
   id: number;
diff --git a/tests/govtool-frontend/playwright/package.json b/tests/govtool-frontend/playwright/package.json
@@ -44,7 +44,7 @@
     "test:headless:usersnap": "npx playwright test userSnap.spec.ts",
     "test:headless:misc": "npx playwright test miscellaneous",
     "format": "prettier . --write",
-    "generate-wallets": "ts-node ./generate_wallets.ts 24",
+    "generate-wallets": "ts-node ./generate_wallets.ts 25",
     "generate-faucet-wallet": "ts-node ./generate_faucet_wallet.ts"
   },
   "dependencies": {
diff --git a/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.pd.spec.ts b/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.pd.spec.ts
@@ -188,9 +188,18 @@ test.describe("Proposal created logged state", () => {
           ).toHaveText(proposal.prop_guardrails_script_hash);
         }
 
+        if (type == ProposalType.hardFork){
+          await expect(
+            proposalSubmissionPage.majorVersionContent
+          ).toHaveText(proposal.prop_major_version)
+          await expect(
+            proposalSubmissionPage.minorVersionContent
+          ).toHaveText(proposal.prop_min_version)
+        }
         // cleanup
         await proposalDetailsPage.deleteProposal();
       });
+      
     });
   });
 
@@ -256,6 +265,16 @@ test.describe("Proposal created logged state", () => {
             proposalSubmissionPage.guardrailsScriptHashContent
           ).toHaveText(proposal.prop_guardrails_script_hash);
         }
+
+           if (type === ProposalType.hardFork){
+            await expect(
+              proposalSubmissionPage.minorVersionContent
+            ).toHaveText(proposal.prop_min_version);
+            await expect(
+              proposalSubmissionPage.majorVersionContent
+            ).toHaveText(proposal.prop_major_version)
+        }
+
       });
     });
   });
@@ -435,6 +454,15 @@ test.describe("Proposal Draft", () => {
       ).toHaveValue(proposalFormValue.prop_guardrails_script_hash);
     }
 
+    if (createProposalType === ProposalType.hardFork) {
+      await expect(proposalSubmissionPage.majorInput).toHaveValue(
+        proposalFormValue.prop_major_version
+      )
+      await expect(proposalSubmissionPage.minorInput).toHaveValue(
+        proposalFormValue.prop_min_version
+      )
+    }
+
     await expect(proposalSubmissionPage.linkUrlInput).toHaveValue(
       proposalFormValue.proposal_links[0].prop_link
     );
@@ -518,6 +546,15 @@ test.describe("Proposal Draft", () => {
           proposalSubmissionPage.guardrailsScriptHashContent
         ).toHaveText(proposalFormValue.prop_guardrails_script_hash);
       }
+
+      if (proposalType === ProposalType.hardFork) {
+        await expect(proposalSubmissionPage.majorVersionContent).toHaveText(
+          proposalFormValue.prop_major_version
+        )
+        await expect(proposalSubmissionPage.minorVersionContent).toHaveText(
+          proposalFormValue.prop_min_version
+        )
+    }
     });
   });
 
diff --git a/tests/govtool-frontend/playwright/tests/proposal-discussion.auth.setup.ts b/tests/govtool-frontend/playwright/tests/proposal-discussion.auth.setup.ts
@@ -11,6 +11,7 @@ import {
   proposal07Wallet,
   proposal08Wallet,
   proposal09Wallet,
+  proposal10Wallet,
 } from "@constants/staticWallets";
 import {
   proposal01AuthFile,
@@ -22,6 +23,7 @@ import {
   proposal07AuthFile,
   proposal08AuthFile,
   proposal09AuthFile,
+  proposal10AuthFile,
 } from "@constants/auth";
 
 setup.beforeEach(async () => {
@@ -39,6 +41,7 @@ const proposalSetups = [
   { name: "Proposal 07", wallet: proposal07Wallet, auth: proposal07AuthFile },
   { name: "Proposal 08", wallet: proposal08Wallet, auth: proposal08AuthFile },
   { name: "Proposal 09", wallet: proposal09Wallet, auth: proposal09AuthFile },
+  { name: "Proposal 10", wallet: proposal10Wallet, auth: proposal10AuthFile }
 ];
 
 for (const { name, wallet, auth } of proposalSetups) {
