Merge pull request #3164 from IntersectMBO/fix/locator-visibility-on-filter

Check locator visibility before validate

Author: kneerose

tests/govtool-frontend/playwright/lib/helpers/transaction.ts

@@ -77,7 +77,7 @@ export async function waitForTxConfirmation(
         .getByTestId("alert-warning")
         .getByText("Transaction in progress", { exact: false })
     ).toBeVisible({
-      timeout: 16_000,
+      timeout: 60_000,
     });
     const url = (await transactionStatusPromise).url();
     const regex = /\/transaction\/status\/([^\/]+)$/;
@@ -90,7 +90,7 @@ export async function waitForTxConfirmation(
       await pollTransaction(transactionHash);
       await expect(
         page.getByText("In Progress", { exact: true }).first() //FIXME: Only one element needs to be displayed
-      ).not.toBeVisible({ timeout: 20_000 });
+      ).not.toBeVisible({ timeout: 60_000 });
     }
   } catch (error) {
     Logger.fail(error.message);

tests/govtool-frontend/playwright/lib/pages/dRepDetailsPage.ts

@@ -1,4 +1,4 @@
-import { Page } from "@playwright/test";
+import { expect, Page } from "@playwright/test";
 
 export default class DRepDetailsPage {
   readonly copyIdBtn = this.page.getByTestId("copy-drep-id-button");
@@ -12,7 +12,22 @@ export default class DRepDetailsPage {
   }
 
   async shareLink() {
-    await this.shareBtn.click();
-    await this.page.getByTestId("copy-link-from-share-button").click();
+    const isShareButtonVisible = await this.page
+      .waitForSelector(`[data-testid="share-button"]`, { timeout: 60_000 })
+      .then(() => true)
+      .catch(() => false);
+
+    if (isShareButtonVisible) {
+      await this.shareBtn.click();
+    } else {
+      expect(false, "Share button not found").toBeTruthy();
+    }
+
+    await this.page
+      .getByTestId("copy-link-from-share-button")
+      .click()
+      .catch(() => {
+        expect(false, "Copy link button not found").toBeTruthy();
+      });
   }
 }

tests/govtool-frontend/playwright/lib/pages/dRepDirectoryPage.ts

@@ -96,15 +96,20 @@ export default class DRepDirectoryPage {
       }
 
       for (const dRep of dRepList) {
-        const hasFilter = await this._validateTypeFiltersInDRep(dRep, filters);
-        const actualFilter = await dRep
-          .locator('[data-testid$="-pill"]')
-          .textContent();
-        if (!hasFilter) {
-          const errorMessage = `${actualFilter} pill does not match with any of the ${filters}`;
-          throw new Error(errorMessage);
+        if (await dRep.isVisible()) {
+          const hasFilter = await this._validateTypeFiltersInDRep(
+            dRep,
+            filters
+          );
+          const actualFilter = await dRep
+            .locator('[data-testid$="-pill"]')
+            .textContent();
+          if (!hasFilter) {
+            const errorMessage = `${actualFilter} pill does not match with any of the ${filters}`;
+            throw new Error(errorMessage);
+          }
+          expect(hasFilter).toBe(true);
         }
-        expect(hasFilter).toBe(true);
       }
     });
   }

tests/govtool-frontend/playwright/lib/pages/governanceActionsPage.ts

@@ -110,14 +110,17 @@ export default class GovernanceActionsPage {
       const proposalCards = await this.getAllProposals();
 
       for (const proposalCard of proposalCards) {
-        const hasFilter = await this._validateFiltersInProposalCard(
-          proposalCard,
-          filters
-        );
-        expect(
-          hasFilter,
-          `A proposal card does not contain any of the ${filters}`
-        ).toBe(true);
+        if (await proposalCard.isVisible()) {
+          const hasFilter = await this._validateFiltersInProposalCard(
+            proposalCard,
+            filters
+          );
+          expect(
+            hasFilter,
+            hasFilter == false &&
+              `A proposal card does not contain any of the ${filters}`
+          ).toBe(true);
+        }
       }
     });
   }

tests/govtool-frontend/playwright/lib/pages/outcomesPage.ts

@@ -105,16 +105,18 @@ export default class OutComesPage {
       async () => {
         const proposalCards = await this.getAllOutcomes();
         for (const proposalCard of proposalCards) {
-          const type = await proposalCard
-            .locator('[data-testid$="-type"]')
-            .textContent();
-          const outcomeType = type.replace(/^.*Type/, "");
-          const hasFilter = await validateFunction(proposalCard, filters);
-          if (!hasFilter) {
-            const errorMessage = `A outcomne type ${outcomeType} does not contain on ${filters}`;
-            throw errorMessage;
+          if (await proposalCard.isVisible()) {
+            const type = await proposalCard
+              .locator('[data-testid$="-type"]')
+              .textContent();
+            const outcomeType = type.replace(/^.*Type/, "");
+            const hasFilter = await validateFunction(proposalCard, filters);
+            if (!hasFilter) {
+              const errorMessage = `An outcome type ${outcomeType} does not contain on ${filters}`;
+              throw errorMessage;
+            }
+            expect(hasFilter).toBe(true);
           }
-          expect(hasFilter).toBe(true);
         }
       },
       {

tests/govtool-frontend/playwright/tests/3-drep-registration/dRepRegistration.dRep.spec.ts

@@ -30,25 +30,29 @@ test.describe("Logged in DReps", () => {
     await page.goto("/");
 
     await expect(page.getByTestId("voting-power-chips")).toBeVisible({
-      timeout: 20_000,
+      timeout: 60_000,
     });
 
     await expect(
       page.getByTestId("dRep-id-display-card-dashboard")
-    ).toContainText(dRep01Wallet.dRepId, { timeout: 20_000 });
+    ).toContainText(dRep01Wallet.dRepId, { timeout: 60_000 });
 
     const governanceActionsPage = new GovernanceActionsPage(page);
 
     await governanceActionsPage.goto();
 
-    await expect(page.getByText(/info action/i).first()).toBeVisible();
+    await expect(page.getByText(/info action/i).first()).toBeVisible({
+      timeout: 60_000,
+    });
 
     const governanceActionDetailsPage =
       await governanceActionsPage.viewFirstProposalByGovernanceAction(
         GovernanceActionType.InfoAction
       );
 
-    await expect(governanceActionDetailsPage.voteBtn).toBeVisible();
+    await expect(governanceActionDetailsPage.voteBtn).toBeVisible({
+      timeout: 60_000,
+    });
   });
 
   test("3H. Should Update DRep data", async ({ page }, testInfo) => {

tests/govtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts

@@ -319,7 +319,7 @@ test.describe("Bootstrap phase", () => {
         if (governanceActionDetailsPage) {
           await expect(
             dRepPage.getByTestId("governance-action-details-card-header")
-          ).toBeVisible();
+          ).toBeVisible({ timeout: 60_000 });
           await expect(
             governanceActionDetailsPage.yesVoteRadio
           ).not.toBeVisible();

tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.spec.ts

@@ -139,19 +139,30 @@ test("8D. Should show the view-all categorized proposed governance actions.", as
 
       const proposalDiscussionPage = new ProposalDiscussionPage(page);
       await proposalDiscussionPage.goto();
-
-      await page
-        .getByTestId(
-          proposalType.toLowerCase().replace(/ /g, "-") + "-show-all-button"
+      const isShowAllButtonVisible = await page
+        .waitForSelector(
+          `[data-testid="${proposalType.toLowerCase().replace(/ /g, "-")}-show-all-button"]`,
+          { timeout: 60_000 }
         )
-        .click();
-
-      const proposalCards = await proposalDiscussionPage.getAllProposals();
-
-      for (const proposalCard of proposalCards) {
-        await expect(
-          proposalCard.getByTestId("governance-action-type")
-        ).toHaveText(proposalType, { timeout: 60_000 });
+        .then(() => true)
+        .catch(() => false);
+
+      if (isShowAllButtonVisible) {
+        await page
+          .getByTestId(
+            proposalType.toLowerCase().replace(/ /g, "-") + "-show-all-button"
+          )
+          .click();
+
+        const proposalCards = await proposalDiscussionPage.getAllProposals();
+
+        for (const proposalCard of proposalCards) {
+          await expect(
+            proposalCard.getByTestId("governance-action-type")
+          ).toHaveText(proposalType, { timeout: 60_000 });
+        }
+      } else {
+        expect(true, `No ${proposalType} found`).toBeTruthy();
       }
     })
   );

tests/govtool-frontend/playwright/tests/9-outcomes/outcomes.spec.ts

@@ -208,18 +208,18 @@ test("9C_2. Should sort Governance Action Type on outcomes page", async ({
   test.slow();
 
   const outcomePage = new OutComesPage(page);
-  await outcomePage.goto();
+  await outcomePage.goto({ sort: "oldestFirst" });
 
   await outcomePage.sortBtn.click();
 
   await outcomePage.sortAndValidate(
-    SortOption.OldestFirst,
-    (p1, p2) => p1.expiry_date <= p2.expiry_date
+    SortOption.NewestFirst,
+    (p1, p2) => p1.expiry_date >= p2.time
   );
 
   await outcomePage.sortAndValidate(
-    SortOption.NewestFirst,
-    (p1, p2) => p1.expiry_date >= p2.time
+    SortOption.OldestFirst,
+    (p1, p2) => p1.expiry_date <= p2.expiry_date
   );
 
   await outcomePage.sortAndValidate(