Merge pull request #3685 from IntersectMBO/fix/drep_teardown

fix: update dRep registration to use dRep keys instead of stake keys

Author: kneerose

tests/govtool-frontend/playwright/lib/helpers/transaction.ts

@@ -126,8 +126,8 @@ export async function registerDRepForWallet(wallet: ShelleyWallet) {
     wallet: wallet.json(),
   };
   const registrationRes = await kuberService.dRepRegistration(
-    convertBufferToHex(wallet.stakeKey.private),
-    convertBufferToHex(wallet.stakeKey.pkh),
+    convertBufferToHex(wallet.dRepKey.private),
+    convertBufferToHex(wallet.dRepKey.pkh),
     metadataAnchorAndWallet
   );
   await pollTransaction(registrationRes.txId, registrationRes.lockInfo);

tests/govtool-frontend/playwright/lib/services/kuberService.ts

@@ -237,8 +237,8 @@ const kuberService = {
   },
 
   dRepRegistration: (
-    stakeSigningKey: string,
-    pkh: string,
+    dRepSigningKey: string,
+    dRepPkh: string,
     metadata: WalletAndAnchorType
   ) => {
     const kuber = new Kuber(
@@ -247,12 +247,12 @@ const kuberService = {
     );
 
     const req = {
-      certificates: [Kuber.generateCert("registerdrep", pkh, metadata)],
+      certificates: [Kuber.generateCert("registerdrep", dRepPkh, metadata)],
       selections: [
         {
           type: "PaymentSigningKeyShelley_ed25519",
           description: "Stake Signing Key",
-          cborHex: `5820${stakeSigningKey}`,
+          cborHex: `5820${dRepSigningKey}`,
         },
       ],
     };
@@ -261,15 +261,15 @@ const kuberService = {
   dRepDeRegistration: (
     addr: string,
     signingKey: string,
-    stakePrivateKey: string,
+    dRepPrivateKey: string,
     pkh: string
   ) => {
     const kuber = new Kuber(addr, signingKey);
     const selections = [
       {
         type: "PaymentSigningKeyShelley_ed25519",
         description: "Payment Signing Key",
-        cborHex: "5820" + stakePrivateKey,
+        cborHex: "5820" + dRepPrivateKey,
       },
     ];
     const req = {
@@ -287,13 +287,13 @@ const kuberService = {
     );
     const req = {
       certificates: wallets.map((wallet) =>
-        Kuber.generateCert("deregisterdrep", wallet.stake.pkh)
+        Kuber.generateCert("deregisterdrep", wallet.dRep.pkh)
       ),
       selections: wallets.map((wallet) => {
         return {
           type: "PaymentSigningKeyShelley_ed25519",
           description: "Stake Signing Key",
-          cborHex: `5820${wallet.stake.private}`,
+          cborHex: `5820${wallet.dRep.private}`,
         };
       }),
       inputs: getWalletConfigForFaucet().address,

tests/govtool-frontend/playwright/tests/2-delegation/delegationFunctionality.delegation.spec.ts

@@ -63,9 +63,9 @@ test.describe("Delegate to others", () => {
     await dRepDirectoryPage.delegateToDRep(dRepId);
 
     // Verify dRepId in dRep directory
-    await expect(
-      page.getByTestId(`${dRepId}-delegate-button`)
-    ).not.toBeVisible();
+    await expect(page.getByTestId(`${dRepId}-delegate-button`)).not.toBeVisible(
+      { timeout: 60_000 }
+    );
 
     await expect(page.getByTestId(`${dRepId}-delegated-card`)).toBeVisible();
     await expect(
@@ -123,7 +123,7 @@ test.describe("Change delegation", () => {
     await dRepDirectoryPage.delegateToDRep(dRepIdSecond);
     await expect(
       page.getByTestId(`${dRepIdSecond}-delegated-card`)
-    ).toBeVisible();
+    ).toBeVisible({ timeout: 60_000 });
     await expect(
       page
         .getByTestId(`${dRepIdSecond}-delegated-card`)