Merge pull request #3139 from IntersectMBO/fix/report-344-flaky-test

Fix: Report 344 flaky/failing test

Author: mesudip

tests/govtool-frontend/playwright/lib/forms/dRepForm.ts

@@ -174,7 +174,7 @@ export default class DRepForm {
       .getByTestId(formErrors.paymentAddress)
       .isVisible();
 
-    expect(await this.objectivesInput.textContent(), {
+    expect(await this.objectivesInput.textContent({ timeout: 60_000 }), {
       message:
         objectivesInputText !== dRepInfo.objectives &&
         `${dRepInfo.objectives} is not equal to ${await this.objectivesInput.textContent()}`,
@@ -255,7 +255,7 @@ export default class DRepForm {
       message:
         !isPaymentAddressErrorVisible &&
         `${dRepInfo.paymentAddress} is a valid paymentAddress`,
-    }).toBeVisible();
+    }).toBeVisible({ timeout: 60_000 });
 
     expect(await this.objectivesInput.textContent(), {
       message:

tests/govtool-frontend/playwright/lib/pages/dRepDirectoryPage.ts

@@ -45,6 +45,10 @@ export default class DRepDirectoryPage {
 
   constructor(private readonly page: Page) {}
 
+  get currentPage(): Page {
+    return this.page;
+  }
+
   async goto() {
     await this.page.goto(
       `${environments.frontendUrl}/connected/drep_directory`
@@ -184,7 +188,7 @@ export default class DRepDirectoryPage {
   }
 
   async getAllListedDReps() {
-    await expect(this.searchInput).toBeVisible({ timeout: 10_000 });
+    await expect(this.searchInput).toBeVisible({ timeout: 60_000 });
 
     await waitedLoop(async () => {
       return (

tests/govtool-frontend/playwright/lib/pages/proposalDiscussionPage.ts

@@ -131,15 +131,17 @@ export default class ProposalDiscussionPage {
       const proposalCards = await this.getAllProposals();
 
       for (const proposalCard of proposalCards) {
-        const type = await proposalCard
-          .getByTestId("governance-action-type")
-          .textContent();
-        const hasFilter = await validateFunction(proposalCard, filters);
-        if (!hasFilter) {
-          const errorMessage = `A governance action type ${type} does not contain on ${filters}`;
-          throw errorMessage;
+        if (await proposalCard.isVisible()) {
+          const type = await proposalCard
+            .getByTestId("governance-action-type")
+            .textContent();
+          const hasFilter = await validateFunction(proposalCard, filters);
+          if (!hasFilter) {
+            const errorMessage = `A governance action type ${type} does not contain on ${filters}`;
+            throw errorMessage;
+          }
+          expect(hasFilter).toBe(true);
         }
-        expect(hasFilter).toBe(true);
       }
     });
   }

tests/govtool-frontend/playwright/lib/types.ts

@@ -291,9 +291,9 @@ export interface outcomeProposal {
 }
 
 export interface outcomeMetadata {
-  authors: any[];
-  hashAlgorithm: string;
-  body: outcomeMetadataBody;
+  metadataStatus: string;
+  metadataValid: boolean;
+  data: outcomeMetadataBody;
 }
 
 interface outcomeMetadataBody {

tests/govtool-frontend/playwright/tests/2-delegation/delegation.loggedin.spec.ts

@@ -92,7 +92,7 @@ test.describe("DRep dependent tests", () => {
     await page.getByTestId(`${dRepId}-delegate-button`).click();
 
     await expect(dRepDirectoryPage.delegationErrorModal).toBeVisible({
-      timeout: 10_000,
+      timeout: 60_000,
     });
     await expect(dRepDirectoryPage.delegationErrorModal).toHaveText(
       /UTxO Balance Insufficient/
@@ -102,7 +102,7 @@ test.describe("DRep dependent tests", () => {
   test("2I. Should check validity of DRep Id", async () => {
     await dRepDirectoryPage.searchInput.fill(dRepId);
     await expect(dRepDirectoryPage.getDRepCard(dRepId)).toBeVisible({
-      timeout: 20_000,
+      timeout: 60_000,
     });
 
     const wallet = await ShelleyWallet.generate();

tests/govtool-frontend/playwright/tests/2-delegation/delegation.spec.ts

@@ -215,7 +215,7 @@ test.describe("DRep dependent tests", () => {
     await dRepDirectoryPage.searchInput.fill(dRepId);
     await page.getByTestId(`${dRepId}-copy-id-button`).click();
     await expect(page.getByText("Copied to clipboard")).toBeVisible({
-      timeout: 10_000,
+      timeout: 60_000,
     });
     const copiedTextDRepDirectory = await page.evaluate(() =>
       navigator.clipboard.readText()

tests/govtool-frontend/playwright/tests/2-delegation/delegationFunctionality.delegation.spec.ts

@@ -59,7 +59,7 @@ test.describe("Delegate to others", () => {
         .getByTestId(`${dRepId}-delegated-card`)
         .getByTestId(`${dRepId}-copy-id-button`)
     ).toHaveCount(1, {
-      timeout: 20_000,
+      timeout: 60_000,
     });
 
     // Verify dRepId in dashboard
@@ -103,7 +103,7 @@ test.describe("Change delegation", () => {
       page
         .getByTestId(`${dRepIdFirst}-delegated-card`)
         .getByTestId(`${dRepIdFirst}-copy-id-button`)
-    ).toHaveText(`(CIP-105) ${dRepIdFirst}`, { timeout: 20_000 });
+    ).toHaveText(`(CIP-105) ${dRepIdFirst}`, { timeout: 60_000 });
 
     // verify delegation
     await dRepDirectoryPage.delegateToDRep(dRepIdSecond);
@@ -114,7 +114,7 @@ test.describe("Change delegation", () => {
       page
         .getByTestId(`${dRepIdSecond}-delegated-card`)
         .getByTestId(`${dRepIdSecond}-copy-id-button`)
-    ).toHaveText(`(CIP-105) ${dRepIdSecond}`, { timeout: 20_000 });
+    ).toHaveText(`(CIP-105) ${dRepIdSecond}`, { timeout: 60_000 });
   });
 });
 
@@ -145,13 +145,13 @@ test.describe("Register DRep state", () => {
     await dRepPage.getByTestId("continue-button").click();
     await expect(
       dRepPage.getByTestId("registration-transaction-submitted-modal")
-    ).toBeVisible({ timeout: 15_000 });
+    ).toBeVisible({ timeout: 60_000 });
     await dRepPage.getByTestId("confirm-modal-button").click();
     await waitForTxConfirmation(dRepPage);
 
     // Checks in dashboard
     await expect(dRepPage.getByText("You are a Direct Voter")).toBeVisible({
-      timeout: 20_000,
+      timeout: 60_000,
     });
     await expect(
       dRepPage.getByTestId("register-as-sole-voter-button")
@@ -168,11 +168,11 @@ test.describe("Register DRep state", () => {
     await dRepPage.getByTestId("continue-button").click();
     await expect(
       dRepPage.getByTestId("registration-transaction-submitted-modal")
-    ).toBeVisible({ timeout: 15_000 });
+    ).toBeVisible({ timeout: 60_000 });
     await dRepPage.getByTestId("confirm-modal-button").click();
     await waitForTxConfirmation(dRepPage);
     await expect(dRepPage.getByText("You are a Direct Voter")).toBeVisible({
-      timeout: 20_000,
+      timeout: 60_000,
     });
 
     const dRepDirectoryPage = new DRepDirectoryPage(dRepPage);
@@ -183,12 +183,11 @@ test.describe("Register DRep state", () => {
 
     await expect(
       dRepPage.getByText("You Have Retired as a Direct")
-    ).toBeVisible({ timeout: 20_000 });
+    ).toBeVisible({ timeout: 60_000 });
   });
 });
 
 test("2G. Should delegate to myself", async ({ page, browser }, testInfo) => {
-  test.skip();
   test.setTimeout(testInfo.timeout + environments.txTimeOut);
 
   const wallet = await walletManager.popWallet("registeredDRep");
@@ -207,14 +206,13 @@ test("2G. Should delegate to myself", async ({ page, browser }, testInfo) => {
   await dRepDirectoryPage.delegateToDRep(dRepId);
 
   await expect(
-    dRepPage.getByTestId(`${dRepId}-delegate-button')`)
-  ).not.toBeVisible();
-  await expect(dRepPage.getByTestId(`${dRepId}-copy-id-button`)).toHaveCount(
-    1,
-    {
-      timeout: 20_000,
-    }
-  );
+    dRepDirectoryPage.currentPage.getByTestId(`${dRepId}-delegate-button`)
+  ).not.toBeVisible({ timeout: 60_000 });
+  await expect(
+    dRepDirectoryPage.currentPage.getByTestId(`${dRepId}-copy-id-button`)
+  ).toHaveCount(1, {
+    timeout: 60_000,
+  });
 });
 
 test.describe("Multiple delegations", () => {
@@ -233,14 +231,14 @@ test.describe("Multiple delegations", () => {
 
     await page.getByTestId(`${dRep01Wallet.dRepId}-delegate-button`).click();
     await expect(page.getByTestId("alert-warning")).toHaveText(/in progress/i, {
-      timeout: 15_000,
+      timeout: 60_000,
     });
 
     await dRepDirectoryPage.searchInput.fill(dRep02Wallet.dRepId);
     await page.getByTestId(`${dRep02Wallet.dRepId}-delegate-button`).click();
 
     await expect(page.getByTestId("transaction-inprogress-modal")).toBeVisible({
-      timeout: 15_000,
+      timeout: 60_000,
     });
   });
 });

tests/govtool-frontend/playwright/tests/3-drep-registration/dRepRegistration.loggedin.spec.ts

@@ -196,7 +196,7 @@ test("3F. Should create proper DRep registration request, when registered with d
   await dRepRegistrationPage.registerWithoutTxConfirmation({ name: "Test" });
   await expect(
     page.getByTestId("registration-transaction-error-modal")
-  ).toBeVisible({ timeout: 10_000 });
+  ).toBeVisible({ timeout: 60_000 });
 });
 
 test("3O. Should reject invalid dRep registration metadata", async ({

tests/govtool-frontend/playwright/tests/3-drep-registration/editDRep.dRep.spec.ts

@@ -73,7 +73,7 @@ test.describe("Validation of edit dRep Form", () => {
     const editDRepPage = new EditDRepPage(page);
     await editDRepPage.goto();
 
-    await expect(editDRepPage.nameInput).toBeVisible({ timeout: 20_000 }); // assert to wait for the page to load
+    await expect(editDRepPage.nameInput).toBeVisible({ timeout: 60_000 }); // assert to wait for the page to load
 
     for (let i = 0; i < 100; i++) {
       await editDRepPage.inValidateForm({

tests/govtool-frontend/playwright/tests/4-proposal-visibility/proposalVisibility.dRep.spec.ts

@@ -45,7 +45,7 @@ test.describe("Logged in DRep", () => {
 
     await expect(page.getByTestId("voting-power-chips-value")).toHaveText(
       `₳ ${lovelaceToAda(votingPower)}`,
-      { timeout: 20_000 }
+      { timeout: 60_000 }
     );
   });
 
@@ -57,7 +57,7 @@ test.describe("Logged in DRep", () => {
 
       // assert to wait until the loading button is hidden
       await expect(page.getByTestId("to-vote-tab")).toBeVisible({
-        timeout: 20_000,
+        timeout: 60_000,
       });
 
       govActionDetailsPage = (await isBootStrapingPhase())