feat: add validation test for constitution proposal

Author: kneerose

tests/govtool-frontend/playwright/lib/_mock/index.ts

@@ -80,6 +80,15 @@ export const invalid = {
     return " ";
   },
 
+  constitutionUrl : () => {
+    const choice = faker.number.int({ min: 1, max: 2 });
+    if (choice === 1) {
+      return invalid.url();
+    }
+    // empty invalid
+    return " ";
+  },
+
   paragraph: (maxCharacter: number) => {
     const choice = faker.number.int({ min: 1, max: 2 });
     if (choice === 1) {

tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts

@@ -23,6 +23,8 @@ const formErrors = {
   rationale: "rationale-helper-error",
   receivingAddress: "receiving-address-0-text-error",
   amount: "amount-0-text-error",
+  constitutionalUrl: "prop=constitution-url-text-error", // BUG wrong test id
+  guardrailsScriptUrl: "prop-guardrails-script-url-input-error",
   link: "link-0-url-input-error",
 };
 
@@ -155,6 +157,10 @@ export default class ProposalSubmissionPage {
     if (governanceProposal.gov_action_type_id === 2) {
       await this.fillUpdateTheConstitutionFields(governanceProposal);
     }
+
+    if (governanceProposal.proposal_links != null) {
+      await this.fillProposalLinks(governanceProposal.proposal_links);
+    }
   }
 
   async fillupForm(governanceProposal: ProposalCreateRequest) {
@@ -167,9 +173,7 @@ export default class ProposalSubmissionPage {
     } else {
       await this.updateTheConstitutionBtn.click();
     }
-    if (governanceProposal.proposal_links != null) {
-      await this.fillProposalLinks(governanceProposal.proposal_links);
-    }
+
     await this.fillupFormWithTypeSelected(governanceProposal);
   }
 
@@ -194,8 +198,6 @@ export default class ProposalSubmissionPage {
       governanceProposal.prop_constitution_url
     );
 
-    await this.guardrailsScriptCheckbox.click();
-
     await this.guardrailsScriptUrlInput.fill(
       governanceProposal.prop_guardrails_script_url
     );
@@ -278,6 +280,16 @@ export default class ProposalSubmissionPage {
       }
     }
 
+    if (governanceProposal.gov_action_type_id === 2) {
+      await expect(
+        this.page.getByTestId(formErrors.constitutionalUrl)
+      ).toBeHidden();
+
+      await expect(
+        this.page.getByTestId(formErrors.guardrailsScriptUrl)
+      ).toBeHidden();
+    }
+
     await expect(this.page.getByTestId(formErrors.link)).toBeHidden();
 
     await expect(this.continueBtn).toBeEnabled();
@@ -332,6 +344,16 @@ export default class ProposalSubmissionPage {
       await expect(this.page.getByTestId(formErrors.amount)).toBeVisible();
     }
 
+    if (governanceProposal.gov_action_type_id === 2) {
+      await expect(
+        this.page.getByTestId(formErrors.constitutionalUrl)
+      ).toBeVisible();
+
+      await expect(
+        this.page.getByTestId(formErrors.guardrailsScriptUrl)
+      ).toBeVisible();
+    }
+
     await expect(this.continueBtn).toBeDisabled();
   }
 
@@ -385,14 +407,20 @@ export default class ProposalSubmissionPage {
           prop_link_text: invalid.name(),
         },
       ],
-      gov_action_type_id: proposalType === ProposalType.info ? 0 : 1,
+      gov_action_type_id: Object.values(ProposalType).indexOf(proposalType),
       is_draft: false,
     };
 
     if (proposalType === ProposalType.treasury) {
       (proposal.prop_receiving_address = faker.location.streetAddress()),
         (proposal.prop_amount = invalid.amount());
     }
+
+    if (proposalType === ProposalType.updatesToTheConstitution) {
+      proposal.prop_constitution_url = invalid.constitutionUrl();
+      proposal.prop_guardrails_script_url = invalid.url();
+      proposal.prop_guardrails_script_hash = faker.string.alphanumeric(64);
+    }
     return proposal;
   }
 

tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts

@@ -54,6 +54,10 @@ test.describe("Proposal created logged state", () => {
         await page.getByTestId(`${type.toLocaleLowerCase()}-button`).click();
         await proposalSubmissionPage.addLinkBtn.click();
 
+        if (type === ProposalType.updatesToTheConstitution) {
+          await proposalSubmissionPage.guardrailsScriptCheckbox.click();
+        }
+
         for (let i = 0; i < 50; i++) {
           const rewardAddressBech32 = (
             await ShelleyWallet.generate()
@@ -106,6 +110,10 @@ test.describe("Proposal created logged state", () => {
         await page.getByTestId(`${type.toLocaleLowerCase()}-button`).click();
         await proposalSubmissionPage.addLinkBtn.click();
 
+        if (type === ProposalType.updatesToTheConstitution) {
+          await proposalSubmissionPage.guardrailsScriptCheckbox.click();
+        }
+
         for (let i = 0; i < 50; i++) {
           const formFields: ProposalCreateRequest =
             proposalSubmissionPage.generateInValidProposalFormFields(type);