chore: refactor fillupForm method to use BudgetProposalStageEnum for stage management

Author: kneerose

tests/govtool-frontend/playwright/lib/pages/budgetDiscussionSubmissionPage.ts

@@ -11,6 +11,7 @@ import {
   BudgetProposalOwnershipProps,
   BudgetProposalProblemStatementAndBenefitProps,
   BudgetProposalProps,
+  BudgetProposalStageEnum,
   CommitteeAlignmentEnum,
   CompanyEnum,
   LocationEnum,
@@ -440,25 +441,28 @@ export default class BudgetDiscussionSubmissionPage {
     await this.continueBtn.click();
   }
 
-  async fillupForm(budgetProposal: BudgetProposalProps, stage = 7) {
+  async fillupForm(
+    budgetProposal: BudgetProposalProps,
+    stage: BudgetProposalStageEnum = BudgetProposalStageEnum.AdministrationAndAuditing
+  ) {
     await this.fillupProposalOwnershipForm(budgetProposal.proposalOwnership);
 
-    if (stage > 2) {
+    if (stage > BudgetProposalStageEnum.ProposalOwnership) {
       await this.fillupProblemStatementAndBenefitsForm(
         budgetProposal.problemStatementAndBenefits
       );
     }
 
-    if (stage > 3) {
+    if (stage > BudgetProposalStageEnum.ProblemStatementAndBenefits) {
       await this.fillupProposalDetailsForm(budgetProposal.proposalDetails);
     }
-    if (stage > 4) {
+    if (stage > BudgetProposalStageEnum.ProposalDetails) {
       await this.fillupCostingForm(budgetProposal.costing);
     }
-    if (stage > 5) {
+    if (stage > BudgetProposalStageEnum.Costing) {
       await this.fillupFurtherInformation(budgetProposal.furtherInformation);
     }
-    if (stage > 6) {
+    if (stage > BudgetProposalStageEnum.FurtherInformation) {
       await this.intersectNamedAdministratorSelect.click();
 
       await this.page

tests/govtool-frontend/playwright/lib/types.ts

@@ -508,3 +508,13 @@ export interface BudgetProposalProps {
   furtherInformation: Array<ProposalLink>;
   administrationAndAuditing: AdministrationAndAuditingProps;
 }
+
+export enum BudgetProposalStageEnum {
+  ProposalOwnership = 1,
+  ProblemStatementAndBenefits = 2,
+  ProposalDetails = 3,
+  Costing = 4,
+  FurtherInformation = 5,
+  AdministrationAndAuditing = 6,
+  Review = 7,
+}

tests/govtool-frontend/playwright/tests/12-proposal-budget-submission/proposalBudgetSubmission.loggedin.spec.ts

@@ -13,6 +13,7 @@ import { expect } from "@playwright/test";
 import {
   BudgetProposalOwnershipProps,
   BudgetProposalProps,
+  BudgetProposalStageEnum,
   CompanyEnum,
 } from "@types";
 import { allure } from "allure-playwright";
@@ -115,7 +116,10 @@ test.describe("Budget proposal 01 wallet", () => {
       test("12D_3. Should verify all field of “proposal details” section", async () => {
         const proposalInformation =
           budgetProposalSubmissionPage.generateValidBudgetProposalInformation();
-        await budgetProposalSubmissionPage.fillupForm(proposalInformation, 3);
+        await budgetProposalSubmissionPage.fillupForm(
+          proposalInformation,
+          BudgetProposalStageEnum.ProblemStatementAndBenefits
+        );
 
         await expect(
           budgetProposalSubmissionPage.proposalNameInput
@@ -143,7 +147,10 @@ test.describe("Budget proposal 01 wallet", () => {
       test("12D_4. Should verify all field of “costing” section", async () => {
         const proposalInformation =
           budgetProposalSubmissionPage.generateValidBudgetProposalInformation();
-        await budgetProposalSubmissionPage.fillupForm(proposalInformation, 4);
+        await budgetProposalSubmissionPage.fillupForm(
+          proposalInformation,
+          BudgetProposalStageEnum.ProposalDetails
+        );
 
         await expect(budgetProposalSubmissionPage.adaAmountInput).toBeVisible();
         await expect(
@@ -163,7 +170,10 @@ test.describe("Budget proposal 01 wallet", () => {
       test("12D_5. Should verify all field of “further information” section", async () => {
         const proposalInformation =
           budgetProposalSubmissionPage.generateValidBudgetProposalInformation();
-        await budgetProposalSubmissionPage.fillupForm(proposalInformation, 5);
+        await budgetProposalSubmissionPage.fillupForm(
+          proposalInformation,
+          BudgetProposalStageEnum.Costing
+        );
 
         await expect(budgetProposalSubmissionPage.linkTextInput).toBeVisible();
         await expect(budgetProposalSubmissionPage.linkUrlInput).toBeVisible();
@@ -173,7 +183,10 @@ test.describe("Budget proposal 01 wallet", () => {
       test("12D_6. Should verify all field of “administration and auditing” section", async () => {
         const proposalInformation =
           budgetProposalSubmissionPage.generateValidBudgetProposalInformation();
-        await budgetProposalSubmissionPage.fillupForm(proposalInformation, 6);
+        await budgetProposalSubmissionPage.fillupForm(
+          proposalInformation,
+          BudgetProposalStageEnum.FurtherInformation
+        );
 
         await expect(
           budgetProposalSubmissionPage.intersectNamedAdministratorSelect