refactor: replace hardcoded proposal type filters with dynamic values from ProposalType

Author: kneerose

tests/govtool-frontend/playwright/lib/constants/index.ts

@@ -11,11 +11,6 @@ export const SECURITY_RELEVANT_PARAMS_MAP: Record<string, string> = {
   minFeeRefScriptCostPerByte: "min_fee_ref_script_cost_per_byte",
 };
 
-export const PROPOSAL_TYPE_FILTERS = [
-  "Info Action",
-  "Treasury requests",
-  "Updates to the Constitution",
-];
 export const BOOTSTRAP_PROPOSAL_TYPE_FILTERS = ["Info Action"];
 
 export const PROPOSAL_STATUS_FILTER = ["Submitted for vote", "Active proposal"];

tests/govtool-frontend/playwright/lib/pages/proposalDiscussionPage.ts

@@ -1,8 +1,7 @@
 import { expect, Locator, Page } from "@playwright/test";
-import { ProposalCreateRequest, ProposedGovAction } from "@types";
+import { ProposalCreateRequest, ProposalType, ProposedGovAction } from "@types";
 import environments from "lib/constants/environments";
 import ProposalDiscussionDetailsPage from "./proposalDiscussionDetailsPage";
-import { PROPOSAL_TYPE_FILTERS } from "@constants/index";
 
 export default class ProposalDiscussionPage {
   // Buttons
@@ -111,7 +110,7 @@ export default class ProposalDiscussionPage {
 
   async clickRadioButtonsByNames(names: string[]) {
     for (const name of names) {
-      const testId = PROPOSAL_TYPE_FILTERS.includes(name)
+      const testId = Object.values(ProposalType).includes(name as ProposalType)
         ? name.toLowerCase()
         : name.toLowerCase().replace(/ /g, "-");
       await this.page.getByTestId(`${testId}-radio`).click();

tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.spec.ts

@@ -2,7 +2,6 @@ import environments from "@constants/environments";
 import {
   BOOTSTRAP_PROPOSAL_TYPE_FILTERS,
   PROPOSAL_STATUS_FILTER,
-  PROPOSAL_TYPE_FILTERS,
 } from "@constants/index";
 import { faker } from "@faker-js/faker";
 import { test } from "@fixtures/proposal";
@@ -50,7 +49,9 @@ test.describe("Filter and sort proposals", () => {
 
     // proposal type filter
     await proposalDiscussionPage.applyAndValidateFilters(
-      isBootStraping ? BOOTSTRAP_PROPOSAL_TYPE_FILTERS : PROPOSAL_TYPE_FILTERS,
+      isBootStraping
+        ? BOOTSTRAP_PROPOSAL_TYPE_FILTERS
+        : Object.values(ProposalType),
       proposalDiscussionPage._validateTypeFiltersInProposalCard
     );