Skip to content

Commit b4384c9

Browse files
authored
Merge pull request #3180 from IntersectMBO/staging
hotfix: fix ada handle and payment address validation order
2 parents d6ccd39 + 8280b1f commit b4384c9

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@ changes.
1414

1515
### Fixed
1616

17+
- hotfix for ada handle and payment address validation order [Issue 3155](https://github.com/IntersectMBO/govtool/issues/3155)
18+
1719
### Changed
1820

1921
### Removed
2022

2123
## [v2.0.15](https://github.com/IntersectMBO/govtool/releases/tag/v2.0.15) 2025-03-11
2224

23-
2425
### Added
2526

2627
- Add support for ada handle in drep payment address [Issue 3155](https://github.com/IntersectMBO/govtool/issues/3155)

govtool/frontend/src/utils/isValidFormat.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,18 @@ export async function isReceivingAddress(address?: string) {
4949
return true;
5050
}
5151

52-
const receivingAddress = Address.from_bech32(address);
53-
if (receivingAddress) {
54-
return true;
55-
}
52+
// Validation for ada handles needs to go first as
53+
// handles might be shorter then bech32 addresses
5654
const isValidAdaHandle = await adaHandleService.isValidAdaHandle(address);
5755

5856
if (isValidAdaHandle) {
5957
return true;
6058
}
6159

60+
const receivingAddress = Address.from_bech32(address);
61+
if (receivingAddress) {
62+
return true;
63+
}
6264
return i18n.t("forms.errors.mustBeReceivingAddress");
6365
} catch (e) {
6466
return i18n.t("forms.errors.mustBeReceivingAddress");

0 commit comments

Comments
 (0)