Skip to content

Commit b5ac058

Browse files
authored
Merge pull request #2529 from IntersectMBO/staging
fix: fix wrong DRep voting conditions
2 parents 042caa0 + 81b3b7c commit b5ac058

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ changes.
3838
- Fix scaling gov action votes on lower resolutions
3939
- Fix storing url missing length validation [Issue 2044](https://github.com/IntersectMBO/govtool/issues/2044)
4040
- Fix governance action details page crash on missing data [Issue 2511](https://github.com/IntersectMBO/govtool/issues/2511)
41+
- Fix wrong voting conditions for drep
4142

4243
### Changed
4344

govtool/frontend/src/context/featureFlag.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ describe("FeatureFlagProvider", () => {
124124
).toBe(true);
125125
});
126126

127-
it("should hide DRep vote totals for MotionNoConfidence in full governance", () => {
127+
it("should show DRep vote totals for MotionNoConfidence in full governance", () => {
128128
mockUseAppContext.mockReturnValue({
129129
...mockUseAppContextReturnValue,
130130
isAppInitializing: false,
@@ -140,7 +140,7 @@ describe("FeatureFlagProvider", () => {
140140
result.current.areDRepVoteTotalsDisplayed(
141141
GovernanceActionType.NoConfidence,
142142
),
143-
).toBe(false);
143+
).toBe(true);
144144
});
145145
});
146146

govtool/frontend/src/context/featureFlag.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,10 @@ const FeatureFlagProvider = ({ children }: PropsWithChildren) => {
7777
!isSecurityGroup)
7878
);
7979
}
80-
if (isFullGovernance) {
81-
return ![
82-
GovernanceActionType.NoConfidence,
83-
GovernanceActionType.NewCommittee,
84-
GovernanceActionType.NewConstitution,
85-
].includes(governanceActionType);
86-
}
80+
8781
return true;
8882
},
89-
[isAppInitializing, isInBootstrapPhase, isFullGovernance],
83+
[isAppInitializing, isInBootstrapPhase],
9084
);
9185

9286
/**

0 commit comments

Comments
 (0)