(fix): duplications in pool_stat table in db-sync

Author: Ciabas

govtool/backend/sql/get-network-total-stake.sql

@@ -67,8 +67,16 @@ TotalStakeControlledByActiveDReps AS (
         AND COALESCE(rd.deposit, 0) >= 0
         AND ((DRepActivity.epoch_no - GREATEST(COALESCE(lve.epoch_no, 0), COALESCE(rd.epoch_no, 0))) <= DRepActivity.drep_activity)
 ),
+-- it's a fix for duplication issue https://github.com/IntersectMBO/cardano-db-sync/issues/1986
+LatestPoolStat AS (
+    SELECT DISTINCT ON (pool_hash_id) *
+    FROM
+        pool_stat
+    WHERE
+        epoch_no = (SELECT MAX(no) FROM epoch)
+),
 TotalStakeControlledBySPOs AS (
-    SELECT SUM(ps.stake)::bigint AS total FROM pool_stat ps WHERE ps.epoch_no = (SELECT no FROM CurrentEpoch)
+    SELECT SUM(ps.stake)::bigint AS total FROM LatestPoolStat ps WHERE ps.epoch_no = (SELECT no FROM CurrentEpoch)
 ),
 AlwaysAbstainVotingPower AS (
     SELECT COALESCE((SELECT amount FROM drep_hash
@@ -90,4 +98,4 @@ SELECT
 FROM TotalStakeControlledByActiveDReps
 LEFT JOIN TotalStakeControlledBySPOs ON TRUE
 LEFT JOIN AlwaysAbstainVotingPower ON TRUE
-LEFT JOIN AlwaysNoConfidenceVotingPower ON TRUE
+LEFT JOIN AlwaysNoConfidenceVotingPower ON TRUE

govtool/backend/sql/list-proposals.sql

@@ -1,5 +1,5 @@
 WITH ActiveProposals AS (
-    SELECT id 
+    SELECT id
     FROM gov_action_proposal
     WHERE expiration > (SELECT MAX(no) FROM epoch)
     AND ratified_epoch IS NULL
@@ -97,11 +97,11 @@ EnrichedCurrentMembers AS (
     FROM
         ProcessedCurrentMembers pcm
     LEFT JOIN json_array_elements(pcm.current_members) AS member ON true
-    LEFT JOIN CommitteeData cm 
-        ON (CASE 
-            WHEN (member->>'hash') ~ '^[0-9a-fA-F]+$' 
-            THEN encode(decode(member->>'hash', 'hex'), 'hex') 
-            ELSE NULL 
+    LEFT JOIN CommitteeData cm
+        ON (CASE
+            WHEN (member->>'hash') ~ '^[0-9a-fA-F]+$'
+            THEN encode(decode(member->>'hash', 'hex'), 'hex')
+            ELSE NULL
         END) = cm.hash
     GROUP BY
         pcm.id
@@ -113,15 +113,23 @@ RankedPoolVotes AS (
         vp.vote
     FROM
         voting_procedure vp
-    WHERE 
+    WHERE
         vp.pool_voter IS NOT NULL
         AND vp.gov_action_proposal_id IN (SELECT id FROM ActiveProposals)
-    ORDER BY 
-        vp.pool_voter, 
-        vp.gov_action_proposal_id, 
+    ORDER BY
+        vp.pool_voter,
+        vp.gov_action_proposal_id,
         vp.tx_id DESC,
         vp.id DESC
 ),
+-- it's a fix for duplication issue https://github.com/IntersectMBO/cardano-db-sync/issues/1986
+LatestPoolStat AS (
+    SELECT DISTINCT ON (pool_hash_id) *
+    FROM
+        pool_stat
+    WHERE
+        epoch_no = (SELECT MAX(no) FROM epoch)
+),
 PoolVotes AS (
     SELECT
         rpv.gov_action_proposal_id,
@@ -132,10 +140,10 @@ PoolVotes AS (
         SUM(CASE WHEN rpv.vote = 'Yes' THEN ps.voting_power ELSE 0 END) AS poolYesVotes,
         SUM(CASE WHEN rpv.vote = 'No' THEN ps.voting_power ELSE 0 END) AS poolNoVotes,
         SUM(CASE WHEN rpv.vote = 'Abstain' THEN ps.voting_power ELSE 0 END) AS poolAbstainVotes
-    FROM 
+    FROM
         RankedPoolVotes rpv
-    JOIN 
-        pool_stat ps
+    JOIN
+        LatestPoolStat ps
         ON rpv.pool_voter = ps.pool_hash_id
     WHERE
         ps.epoch_no = (SELECT MAX(no) FROM epoch)
@@ -147,29 +155,29 @@ RankedDRepVotes AS (
         vp.gov_action_proposal_id,
         vp.drep_voter,
         vp.vote
-    FROM 
+    FROM
         voting_procedure vp
-    WHERE 
+    WHERE
         vp.drep_voter IS NOT NULL
         AND vp.gov_action_proposal_id IN (SELECT id FROM ActiveProposals)
-    ORDER BY 
-        vp.drep_voter, 
-        vp.gov_action_proposal_id, 
+    ORDER BY
+        vp.drep_voter,
+        vp.gov_action_proposal_id,
         vp.tx_id DESC,
         vp.id DESC
 ),
 RankedDRepRegistration AS (
     SELECT DISTINCT ON (dr.drep_hash_id)
         dr.*
-    FROM 
+    FROM
         drep_registration dr
-    ORDER BY 
+    ORDER BY
         dr.drep_hash_id,
         dr.tx_id DESC,
         dr.id DESC
 ),
 CommitteeVotes AS (
-    SELECT 
+    SELECT
         vp.gov_action_proposal_id,
         SUM(CASE WHEN vp.vote = 'Yes' THEN 1 ELSE 0 END) AS ccYesVotes,
         SUM(CASE WHEN vp.vote = 'No' THEN 1 ELSE 0 END) AS ccNoVotes,
@@ -182,13 +190,13 @@ CommitteeVotes AS (
         FROM voting_procedure
         WHERE committee_voter IS NOT NULL
         AND gov_action_proposal_id IN (SELECT id FROM ActiveProposals)
-        ORDER BY 
-            committee_voter, 
-            gov_action_proposal_id, 
+        ORDER BY
+            committee_voter,
+            gov_action_proposal_id,
             tx_id DESC,
             id DESC
     ) vp
-    GROUP BY 
+    GROUP BY
         vp.gov_action_proposal_id
 )
 SELECT
@@ -215,13 +223,13 @@ SELECT
 
             WHEN gov_action_proposal.type::text = 'HardForkInitiation' THEN
             json_build_object(
-                'major', (gov_action_proposal.description->'contents'->1->>'major')::int, 
+                'major', (gov_action_proposal.description->'contents'->1->>'major')::int,
                 'minor', (gov_action_proposal.description->'contents'->1->>'minor')::int
             )
 
             WHEN gov_action_proposal.type::text = 'NoConfidence' THEN
             json_build_object('data', gov_action_proposal.description->'contents')
-    
+
             WHEN gov_action_proposal.type::text = 'ParameterChange' THEN
             json_build_object('data', gov_action_proposal.description->'contents')
 
@@ -237,12 +245,12 @@ SELECT
                         'tag', pd.tag,
                         'members', em.enriched_members,
                         'membersToBeRemoved', mtr.members_to_be_removed,
-                        'threshold', 
-                            CASE 
-                                WHEN (pd.threshold->>'numerator') IS NOT NULL 
-                                AND (pd.threshold->>'denominator') IS NOT NULL 
+                        'threshold',
+                            CASE
+                                WHEN (pd.threshold->>'numerator') IS NOT NULL
+                                AND (pd.threshold->>'denominator') IS NOT NULL
                                 THEN (pd.threshold->>'numerator')::float / (pd.threshold->>'denominator')::float
-                                ELSE NULL 
+                                ELSE NULL
                             END
                     )
                 FROM
@@ -260,9 +268,9 @@ SELECT
     , '{}'::JSON) AS description,
 	CASE
         WHEN meta.network_name::text = 'mainnet' OR meta.network_name::text = 'preprod' THEN
-            latest_epoch.start_time + (gov_action_proposal.expiration - latest_epoch.no)::bigint * INTERVAL '5 days' 
+            latest_epoch.start_time + (gov_action_proposal.expiration - latest_epoch.no)::bigint * INTERVAL '5 days'
         ELSE
-            latest_epoch.start_time + (gov_action_proposal.expiration - latest_epoch.no)::bigint * INTERVAL '1 day' 
+            latest_epoch.start_time + (gov_action_proposal.expiration - latest_epoch.no)::bigint * INTERVAL '1 day'
     END AS expiry_date,
     gov_action_proposal.expiration,
     creator_block.time,
@@ -271,7 +279,7 @@ SELECT
     encode(voting_anchor.data_hash, 'hex') data_hash,
     jsonb_set(
         ROW_TO_JSON(proposal_params)::jsonb,
-        '{cost_model}', 
+        '{cost_model}',
         CASE
             WHEN cost_model.id IS NOT NULL THEN
                 ROW_TO_JSON(cost_model)::jsonb
@@ -339,7 +347,7 @@ FROM
     LEFT JOIN LatestDrepDistr ldd_drep ON ldd_drep.hash_id = rdr.drep_hash_id
         AND ldd_drep.epoch_no = latest_epoch.no
     LEFT JOIN gov_action_proposal AS prev_gov_action ON gov_action_proposal.prev_gov_action_proposal = prev_gov_action.id
-    LEFT JOIN tx AS prev_gov_action_tx ON prev_gov_action.tx_id = prev_gov_action_tx.id   
+    LEFT JOIN tx AS prev_gov_action_tx ON prev_gov_action.tx_id = prev_gov_action_tx.id
 WHERE
     (COALESCE(?, '') = '' OR
     off_chain_vote_gov_action_data.title ILIKE ? OR

govtool/backend/src/VVA/Config.hs

@@ -185,4 +185,4 @@ getServerPort = asks (serverPort . getter)
 getServerHost ::
   (Has VVAConfig r, MonadReader r m) =>
   m Text
-getServerHost = asks (serverHost . getter)
+getServerHost = asks (serverHost . getter)