Skip to content

Commit d28ccc0

Browse files
authored
Merge pull request #3387 from IntersectMBO/fix/report-377-issue
Fix: report 377 issue
2 parents 87ce23c + ca8d2e5 commit d28ccc0

File tree

3 files changed

+22
-9
lines changed

3 files changed

+22
-9
lines changed

tests/govtool-frontend/playwright/lib/services/kuberService.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,10 @@ const kuberService = {
211211
},
212212

213213
multipleDRepRegistration: (metadataAndWallets: WalletAndAnchorType[]) => {
214-
const kuber = new Kuber(faucetWallet.address, faucetWallet.payment.private);
214+
const kuber = new Kuber(
215+
proposalFaucetWallet.address,
216+
proposalFaucetWallet.payment.private
217+
);
215218
const req = {
216219
certificates: metadataAndWallets.map((metadataAndWallet) =>
217220
Kuber.generateCert(

tests/govtool-frontend/playwright/tests/11-proposal-budget/proposalBudget.loggedin.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ test.describe("Budget proposal logged in state", () => {
4949
});
5050

5151
test("11I. Should comments on any proposal", async ({}) => {
52-
const comment = faker.lorem.paragraph(2);
52+
const comment = faker.lorem.paragraph(1);
5353
await budgetDiscussionDetailsPage.addComment(comment);
5454
await expect(
5555
budgetDiscussionDetailsPage.currentPage
@@ -59,7 +59,7 @@ test.describe("Budget proposal logged in state", () => {
5959
});
6060

6161
test("11J. Should reply to any comments", async ({}) => {
62-
const randComment = faker.lorem.paragraph(2);
62+
const randComment = faker.lorem.paragraph(1);
6363
const randReply = faker.lorem.words(5);
6464

6565
await budgetDiscussionDetailsPage.addComment(randComment);

tests/govtool-frontend/playwright/tests/11-proposal-budget/proposalBudget.spec.ts

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ test("11E. Should view comments with count indications on a budget proposal", as
187187
page,
188188
}) => {
189189
let responsePromise = page.waitForResponse((response) =>
190-
response.url().includes(`/api/comments`)
190+
response.url().includes(`/api/bds/`)
191191
);
192192

193193
const budgetDiscussionPage = new BudgetDiscussionPage(page);
@@ -197,13 +197,23 @@ test("11E. Should view comments with count indications on a budget proposal", as
197197
await budgetDiscussionPage.viewFirstProposal();
198198
const response = await responsePromise;
199199

200-
const comments: CommentResponse[] = (await response.json()).data;
200+
const proposalResponse = await response.json();
201201

202-
await responsePromise;
202+
const actualTotalComments =
203+
await budgetDiscussionDetailsPage.totalComments.textContent();
204+
const expectedTotalComments =
205+
proposalResponse.data.attributes.prop_comments_number.toString();
206+
const isEqual = actualTotalComments === expectedTotalComments;
203207

204-
await expect(budgetDiscussionDetailsPage.totalComments).toHaveText(
205-
comments.length.toString()
206-
);
208+
const currentPageUrl = budgetDiscussionDetailsPage.currentPage.url();
209+
210+
const proposalId = extractProposalIdFromUrl(currentPageUrl);
211+
212+
await expect(
213+
budgetDiscussionDetailsPage.totalComments,
214+
!isEqual &&
215+
`Total comments do not match in ${environments.frontendUrl}/budget_discussion/${proposalId}`
216+
).toHaveText(expectedTotalComments);
207217
});
208218

209219
test.describe("Restricted access to interact budget proposal", () => {

0 commit comments

Comments
 (0)