fix: refactor transaction polling to use functionWaitedAssert for improved error handling

Author: kneerose

tests/govtool-frontend/playwright/lib/helpers/transaction.ts

@@ -7,6 +7,7 @@ import { ShelleyWallet } from "./crypto";
 import { uploadMetadataAndGetJsonHash } from "./metadata";
 import { WalletAndAnchorType } from "@types";
 import { Logger } from "@helpers/logger";
+import { functionWaitedAssert } from "./waitedLoop";
 
 /**
  * Polls the transaction status until it's resolved or times out.
@@ -16,43 +17,48 @@ export async function pollTransaction(
   txHash: string,
   lockInfo?: LockInterceptorInfo
 ) {
-  try {
-    Logger.info(`Waiting for tx completion: ${txHash}`);
-    await expect
-      .poll(
-        async () => {
-          const response = await kuberService.getTransactionDetails(txHash);
-          const data = await response.json();
-          return data.length;
-        },
-        {
-          timeout: environments.txTimeOut,
-        }
-      )
-      .toBeGreaterThan(0);
+  await functionWaitedAssert(
+    async () => {
+      try {
+        Logger.info(`Waiting for tx completion: ${txHash}`);
+        await expect
+          .poll(
+            async () => {
+              const response = await kuberService.getTransactionDetails(txHash);
+              const data = await response.json();
+              return data.length;
+            },
+            {
+              timeout: environments.txTimeOut,
+            }
+          )
+          .toBeGreaterThan(0);
 
-    Logger.success("Tx completed");
+        Logger.success("Tx completed");
 
-    if (!lockInfo) return;
+        if (!lockInfo) return;
 
-    await LockInterceptor.releaseLock(
-      lockInfo.initiator,
-      lockInfo.lockId,
-      `Task completed for:${lockInfo.lockId}`
-    );
-  } catch (err) {
-    if (lockInfo) {
-      const errorMessage = { lockInfo, error: JSON.stringify(err) };
-
-      await LockInterceptor.releaseLock(
-        lockInfo.initiator,
-        lockInfo.lockId,
-        `Task failure: \n${JSON.stringify(errorMessage)}`
-      );
-    }
+        await LockInterceptor.releaseLock(
+          lockInfo.initiator,
+          lockInfo.lockId,
+          `Task completed for:${lockInfo.lockId}`
+        );
+      } catch (err) {
+        if (lockInfo) {
+          const errorMessage = { lockInfo, error: JSON.stringify(err) };
 
-    throw err;
-  }
+          await LockInterceptor.releaseLock(
+            lockInfo.initiator,
+            lockInfo.lockId,
+            `Task failure: \n${JSON.stringify(errorMessage)}`
+          );
+        }
+        Logger.fail(`Failed due to ${err}`);
+        throw err;
+      }
+    },
+    { timeout: environments.txTimeOut + 60_000, name: "pollTransaction" }
+  );
 }
 
 export async function waitForTxConfirmation(