feat: add support for CIP129 in governance actions

Author: Ciabas

CHANGELOG.md

@@ -11,6 +11,7 @@ changes.
 ## [Unreleased]
 
 ### Added
+- Add CIP-129 support for gov_actions hashes in Live Voting (governance actions) [Issue 3619](https://github.com/IntersectMBO/govtool/issues/3619)
 
 ### Fixed
 

govtool/frontend/src/components/organisms/DashboardGovernanceActionDetails.tsx

@@ -99,8 +99,8 @@ export const DashboardGovernanceActionDetails = () => {
 
   useEffect(() => {
     const isProposalNotFound =
-      (error as AxiosError)?.response?.data ===
-      `Proposal with id: ${fullProposalId} not found`;
+      error instanceof AxiosError &&
+      error.response?.data.match(/Proposal with id: .* not found/);
     if (isProposalNotFound && fullProposalId) {
       navigate(
         OUTCOMES_PATHS.governanceActionOutcomes.replace(":id", fullProposalId),

govtool/frontend/src/pages/GovernanceActionDetails.tsx

@@ -94,8 +94,8 @@ export const GovernanceActionDetails = () => {
 
   useEffect(() => {
     const isProposalNotFound =
-      (error as AxiosError)?.response?.data ===
-      `Proposal with id: ${fullProposalId} not found`;
+      error instanceof AxiosError &&
+      error.response?.data.match(/Proposal with id: .* not found/);
     if (isProposalNotFound && fullProposalId) {
       navigate(
         OUTCOMES_PATHS.governanceActionOutcomes.replace(":id", fullProposalId),

govtool/frontend/src/services/requests/getProposal.ts

@@ -7,10 +7,10 @@ export const getProposal = async (
   proposalId: string,
   drepId?: string,
 ): Promise<VotedProposal> => {
-  const isCIP129Identifier = proposalId.includes("gov_action");
+  const isCIP129Identifier = proposalId.startsWith("gov_action");
   if (isCIP129Identifier) {
-    const { txID } = decodeCIP129Identifier(proposalId);
-    proposalId = txID;
+    const { txID, index } = decodeCIP129Identifier(proposalId);
+    proposalId = `${txID}#${parseInt(index, 16)}`;
   }
 
   const encodedHash = encodeURIComponent(proposalId);

govtool/frontend/src/utils/getGovActionId.ts

@@ -9,8 +9,10 @@ export const getShortenedGovActionId = (
   const firstPart = txHash.slice(0, 4);
   const lastPart = txHash.slice(-4);
 
-  return `${firstPart}...${lastPart}#${index}`;
+  return txHash.startsWith("gov_action")
+    ? `${firstPart}...${lastPart}`
+    : `${firstPart}...${lastPart}#${index}`;
 };
 
 export const getFullGovActionId = (txHash: string, index: number | string) =>
-  `${txHash}#${index}`;
+  (txHash.startsWith("gov_action") ? txHash : `${txHash}#${index}`);

govtool/frontend/src/utils/tests/getGovActionId.test.ts

@@ -28,6 +28,13 @@ describe("getShortenedGovActionId", () => {
     const result = getShortenedGovActionId(txHash, index);
     expect(result).toBe("#1");
   });
+
+  it("should handle a hash starting with 'gov_action' correctly", () => {
+    const txHash = "gov_action_1234567890abcdef";
+    const index = 7;
+    const result = getShortenedGovActionId(txHash, index);
+    expect(result).toBe("gov_...cdef");
+  });
 });
 
 describe("getFullGovActionId", () => {
@@ -37,4 +44,11 @@ describe("getFullGovActionId", () => {
     const result = getFullGovActionId(txHash, index);
     expect(result).toBe("1234567890abcdef1234567890abcdef#10");
   });
+
+  it("should return the full id without index if txHash starts with 'gov_action'", () => {
+    const txHash = "gov_action_1234567890abcdef";
+    const index = 5;
+    const result = getFullGovActionId(txHash, index);
+    expect(result).toBe("gov_action_1234567890abcdef");
+  });
 });