Skip to content

πŸ› Governance action references break withipfs://Β #2711

@Ryun1

Description

@Ryun1

Area

Voting Pillar

Domain

gov.tools

Which wallet were you using?

No response

Context

  • When a governance action has references with files hosted on ipfs
  • and the user tries to go to external link the new tab is opened to https://ipfs//xxxx
  • The https:// is being mistakenly added to the URI
  • and the : is removed

This could also happen with a new constitution URI

Steps to reproduce

  1. Go to https://preview.gov.tools/governance_actions/949b57c802a51273793b49381f192757d4e2b764632ac97a205be88b6b1fa53b#0
  2. Try to go to new tab of reference files
scrnli_X43h49hucxGdgx.webm

Actual behavior

  • Tab opened with https:// added causing error

Expected behavior

There is two solutions we could do here

  1. have the new tabs open with the raw IPFS URI
  • this is fine, if the user has a local node running (like me!)
  1. OR if a IPFS URI is detected, WHEN opening a new tab a gateway is added so the link should work even if the user doesnt have a node setup

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions