QLS tests: label the per-run number of actions

Both success, failing and total.

Initial results:
      Actions total (100 in total):
      55% NumActions "10 <= n < 100"
      36% NumActions "1 <= n < 10"
       7% NumActions "n == 0"
       2% NumActions "100 <= n < 1000"

      Actions that succeeded total (100 in total):
      52% NumActions "10 <= n < 100"
      38% NumActions "1 <= n < 10"
       9% NumActions "n == 0"
       1% NumActions "100 <= n < 1000"

      Actions that failed total (100 in total):
      68% NumActions "1 <= n < 10"
      22% NumActions "n == 0"
      10% NumActions "10 <= n < 100"

As we can see, there's a surprising number of runs with no actions at
all (7%) or no successful actions (9%).

While it's important to get coverage of failing actions, we don't need
lots of coverage since the reasons are always the same ones. There are
not a lot of complex interactions in these cases. So we're wasting run
actions on them.

Author: dcoutts

test/Test/Database/LSMTree/Normal/StateMachine.hs

@@ -1306,9 +1306,11 @@ data Stats = Stats {
   , snapshotted        :: Set R.SnapshotName
     -- === Final tags (per action sequence, across all tables)
     -- | Number of succesful lookups and their results
-  , numLookupsResults  :: (Int, Int, Int) -- (NotFound, Found, FoundWithBlob)
+  , numLookupsResults  :: {-# UNPACK #-} !(Int, Int, Int)
+                          -- (NotFound, Found, FoundWithBlob)
     -- | Number of succesful updates
-  , numUpdates         :: (Int, Int, Int) -- (Insert, InsertWithBlob, Delete)
+  , numUpdates         :: {-# UNPACK #-} !(Int, Int, Int)
+                          -- (Insert, InsertWithBlob, Delete)
     -- | Actions that succeeded
   , successActions     :: [String]
     -- | Actions that failed with an error
@@ -1604,6 +1606,8 @@ data FinalTag =
     -- (this includes submissions through both 'Class.updates' and
     -- 'Class.deletes')
   | NumDeletes String
+    -- | Total number of actions (failing, succeeding, either)
+  | NumActions String
     -- | Which actions succeded
   | ActionSuccess String
     -- | Which actions failed
@@ -1623,6 +1627,7 @@ tagFinalState' :: Lockstep (ModelState h) -> [(String, [FinalTag])]
 tagFinalState' (getModel -> ModelState finalState finalStats) = concat [
       tagNumLookupsResults
     , tagNumUpdates
+    , tagNumActions
     , tagSuccessActions
     , tagFailActions
     , tagNumTables
@@ -1644,6 +1649,16 @@ tagFinalState' (getModel -> ModelState finalState finalStats) = concat [
         ]
       where (i, iwb, d) = numUpdates finalStats
 
+    tagNumActions =
+        [ let n = length (successActions finalStats) in
+          ("Actions that succeeded total", [NumActions (showPowersOf 10 n)])
+        , let n = length (failActions finalStats) in
+          ("Actions that failed total", [NumActions (showPowersOf 10 n)])
+        , let n = length (successActions finalStats)
+                + length (failActions finalStats) in
+          ("Actions total", [NumActions (showPowersOf 10 n)])
+        ]
+
     tagSuccessActions =
         [ ("Actions that succeeded", [ActionSuccess c])
         | c <- successActions finalStats ]