Remove snapshot TODOs from public API

Author: jorisdral

src/Database/LSMTree/Common.hs

@@ -205,9 +205,6 @@ class Labellable a where
 -- Exceptions:
 --
 -- * Deleting a snapshot that doesn't exist is an error.
---
--- TODO: this function currently has a temporary implementation until we have
--- proper snapshots.
 deleteSnapshot ::
      IOLike m
   => Session m
@@ -219,9 +216,6 @@ deleteSnapshot (Internal.Session' sesh) = Internal.deleteSnapshot sesh
      Session IO
   -> IO [Internal.SnapshotName] #-}
 -- | List snapshots by name.
---
--- TODO: this function currently has a temporary implementation until we have
--- proper snapshots.
 listSnapshots ::
      IOLike m
   => Session m

src/Database/LSMTree/Monoidal.hs

@@ -123,7 +123,7 @@ module Database.LSMTree.Monoidal (
 
 import           Control.DeepSeq
 import           Control.Exception (assert)
-import           Control.Monad (void, (<$!>))
+import           Control.Monad ((<$!>))
 import           Data.Bifunctor (Bifunctor (..))
 import           Data.Coerce (coerce)
 import           Data.Kind (Type)
@@ -559,7 +559,7 @@ createSnapshot :: forall m k v.
   -> Table m k v
   -> m ()
 createSnapshot snap (Internal.MonoidalTable t) =
-    void $ Internal.createSnapshot (resolve @v Proxy) snap label Internal.SnapMonoidalTable t
+    Internal.createSnapshot (resolve @v Proxy) snap label Internal.SnapMonoidalTable t
   where
     label = Internal.SnapshotLabel $ Common.makeSnapshotLabel (Proxy @(k, v))
 

src/Database/LSMTree/Normal.hs

@@ -669,14 +669,6 @@ retrieveBlobs (Internal.Session' (sesh :: Internal.Session m h)) refs =
 --
 -- * It is safe to concurrently make snapshots from any table, provided that
 --   the snapshot names are distinct (otherwise this would be a race).
---
--- TODO: this function currently has a temporary implementation until we have
--- proper snapshots. The temporary snapshot consists of a small file in the
--- snapshots directory that lists: (i) the runs that are used by a specific
--- snapshot, and (ii) its table configuration. We don't have to copy run files
--- as part of the snapshot because run files aren't (yet) deleted when runs are
--- closed. The write buffer is also persisted to disk as part of the snapshot,
--- but the original table remains unchanged.
 createSnapshot :: forall m k v blob.
      ( IOLike m
      , SerialiseKey k
@@ -688,7 +680,7 @@ createSnapshot :: forall m k v blob.
   -> Table m k v blob
   -> m ()
 createSnapshot snap (Internal.NormalTable t) =
-    void $ Internal.createSnapshot const snap label Internal.SnapNormalTable t
+    Internal.createSnapshot const snap label Internal.SnapNormalTable t
   where
     label = Internal.SnapshotLabel $ Common.makeSnapshotLabel (Proxy @(k, v, blob))
 
@@ -720,9 +712,6 @@ createSnapshot snap (Internal.NormalTable t) =
 --   'createSnapshot' "intTable" t
 --   'openSnapshot' \@IO \@Bool \@Bool \@Bool session "intTable"
 -- @
---
--- TODO: this function currently has a temporary implementation until we have
--- proper snapshots. See 'createSnapshot'.
 openSnapshot :: forall m k v blob.
      ( IOLike m
      , SerialiseKey k