Skip to content

Commit 3a1e4c3

Browse files
Niolsnfrisby
authored andcommitted
Enrich comment about disabled mustReplyTimeout
Co-authored-by: Nicolas Frisby <[email protected]>
1 parent d53d14e commit 3a1e4c3

File tree

1 file changed

+6
-0
lines changed
  • ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup

1 file changed

+6
-0
lines changed

ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup/GenChains.hs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,12 @@ chainSyncTimeouts =
188188
-- chains are finite, and therefore an honest peer can only serve it all,
189189
-- then send 'MsgAwaitReply' (therefore entering 'StMustReply'), and then
190190
-- stall forever, and it must not be killed for it.
191+
--
192+
-- Note that this allows the adversaries to stall us forever in that same
193+
-- situation. However, that peer is only allowed to send 'MsgAwaitReply'
194+
-- when they have served their tip, which leaves them fully vulnerable to
195+
-- the Genesis Density Disconnection (GDD) logic. A bug related to this
196+
-- disabled timeout is in fact either a bug in the GDD or in the tests.
191197
mustReplyTimeout :: Maybe DiffTime
192198
mustReplyTimeout = Nothing
193199

0 commit comments

Comments
 (0)