mempool-bench: move more pre-calculation into withResource #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #1175 makes a change that alters the cost of the size of the pre-generated txs. This PR pre-emptively removes that cost from the benchmarked section of code.
nfrisby
requested review from
RenateEilers,
amesgen,
dnadales,
fraser-iohk and
jasagredo
as code owners
jasagredo
approved these changes
Aug 26, 2024
Contributor
jasagredo
left a comment
jasagredo
left a comment
There was a problem hiding this comment.
Changes in benchmarks and tests do not need a corresponding changelog entry
amesgen
approved these changes
Aug 26, 2024
Member
amesgen
left a comment
amesgen
left a comment
There was a problem hiding this comment.
I think this will be superseded by #1102 (#1095 (comment)) by moving the entire mempool construction out of the measurement, but I see no reason not to merge this PR now.
dnadales
approved these changes
Aug 26, 2024
nfrisby
force-pushed
the
nfrisby/mempool-bench-refine-prep
branch
from
238f4df to
671001c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1175 makes a change that alters the cost of the size of the pre-generated txs. This PR pre-emptively removes that cost from the benchmarked section of code.