Improved connection manager transition tests #5026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn the unenforced property tests into enforced unit tests. Also improve the transition coverage test to cover two sources of transition events: from `traceTVar` installed in `newMutableConnState` and a transition tracer.
coot
added
testing
connection-manager
Reinstanciate it, without it some tests are not effective.
coot
force-pushed
the
coot/testnet-connection-manager-transition-tracer
branch
2 times, most recently
from
cbab13f to
7fb0adf
Compare
bolt12
approved these changes
Dec 17, 2024
A global `ConnIdSupply` allows to to distinguish all connections based on their `ConnId`.
coot
force-pushed
the
coot/testnet-connection-manager-transition-tracer
branch
from
7fb0adf to
cb000e8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #5021 & #5017.
Checklist
Quality
Maintenance
ouroboros-networkproject.