Skip to content

Commit 6184806

Browse files
authored
Create issues for a few FIXMEs (#7257)
1 parent e047551 commit 6184806

File tree

5 files changed

+9
-5
lines changed
  • plutus-core
  • plutus-ledger-api/src/PlutusLedgerApi/Common
  • plutus-tx-plugin/test/Strictness
  • plutus-tx/src/PlutusTx

5 files changed

+9
-5
lines changed

plutus-core/plutus-core/test/CostModelSafety/Spec.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ genArgs semvar bn = case meaning of
199199
meaning :: BuiltinMeaning Term (CostingPart DefaultUni DefaultFun)
200200
meaning = toBuiltinMeaning semvar bn
201201

202-
-- FIXME: this doesn't work in some cases: for example if we have a costing
202+
-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1733):
203+
-- this doesn't work in some cases: for example if we have a costing
203204
-- function 10-2*size we'll only test it on for a small value of size (0 or 1)
204205
-- so we won't spot that it can give you a negative result. We do want to check
205206
-- small sizes, but we should also check larger ones.
@@ -247,4 +248,3 @@ test_costModelSafety =
247248
]
248249
in testGroup "Cost model safety test" $
249250
map mkTest $ enumerate @(BuiltinSemanticsVariant DefaultFun)
250-

plutus-core/plutus-ir/src/PlutusIR/Error.hs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ instance (PLC.PrettyUni uni, Pretty ann) =>
5252
instance (PLC.PrettyUni uni, Pretty fun, Pretty ann) => Show (Error uni fun ann) where
5353
show = show . PP.pretty
5454

55-
-- FIXME: we get rid of this when our TestLib stops using rethrow
55+
-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1732): we get rid of this
56+
-- when our TestLib stops using rethrow
5657
deriving anyclass instance
5758
(PLC.ThrowableBuiltins uni fun, PP.Pretty ann, Typeable ann) => Exception (Error uni fun ann)
5859

plutus-ledger-api/src/PlutusLedgerApi/Common/Eval.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ mkDynEvaluationContext ll toCaser semVars toSemVar newCMP = do
191191
machPars <- mkMachineVariantParametersFor semVars newCMP
192192
pure $ EvaluationContext ll toCaser toSemVar machPars
193193

194-
-- FIXME: remove this function
194+
-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1726): remove this function
195195
assertWellFormedCostModelParams :: MonadError CostModelApplyError m => Plutus.CostModelParams -> m ()
196196
assertWellFormedCostModelParams = void . Plutus.applyCostModelParams Plutus.defaultCekCostModelForTesting
197197

plutus-tx-plugin/test/Strictness/Spec.hs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,23 @@ tests =
2121
, goldenPirReadable "lambda-default" lambdaDefault
2222
, goldenUPlcReadable "lambda-default" lambdaDefault
2323
, -- FIXME: This should not crash, but it currently does.
24+
-- https://github.com/IntersectMBO/plutus-private/issues/1728
2425
goldenEvalCekCatchBudget "lambda-nonstrict" $ lambdaNonStrict `unsafeApplyCode` bot
2526
, goldenPirReadable "lambda-nonstrict" lambdaNonStrict
2627
, goldenUPlcReadable "lambda-nonstrict" lambdaNonStrict
2728
, goldenEvalCekCatchBudget "lambda-strict" $ lambdaStrict `unsafeApplyCode` bot
2829
, goldenPirReadable "lambda-strict" lambdaStrict
2930
, goldenUPlcReadable "lambda-strict" lambdaStrict
3031
, -- FIXME: This should crash (because the `Strict` extension is on), but it currently doesn't.
32+
-- https://github.com/IntersectMBO/plutus-private/issues/1728
3133
goldenEvalCekCatchBudget "let-default" $ letDefault `unsafeApplyCode` one
3234
, goldenPirReadable "let-default" letDefault
3335
, goldenUPlcReadable "let-default" letDefault
3436
, goldenEvalCekCatchBudget "let-nonstrict" $ letNonStrict `unsafeApplyCode` one
3537
, goldenPirReadable "let-nonstrict" letNonStrict
3638
, goldenUPlcReadable "let-nonstrict" letNonStrict
3739
, -- FIXME: This should crash, but it currently doesn't.
40+
-- https://github.com/IntersectMBO/plutus-private/issues/1728
3841
goldenEvalCekCatchBudget "let-strict" $ letStrict `unsafeApplyCode` one
3942
, goldenPirReadable "let-strict" letStrict
4043
, goldenUPlcReadable "let-strict" letStrict

plutus-tx/src/PlutusTx/Prelude.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ modulo :: Integer -> Integer -> Integer
233233
modulo = Builtins.modInteger
234234
{-# INLINEABLE modulo #-}
235235

236-
-- | FIXME
236+
-- | FIXME (https://github.com/IntersectMBO/plutus-private/issues/1729)
237237
expMod :: Integer -> Integer -> Integer -> Integer
238238
expMod = Builtins.expModInteger
239239
{-# INLINEABLE expMod #-}

0 commit comments

Comments
 (0)