Add fixme issues (#7381)

Author: zliu41

plutus-core/plutus-ir/src/PlutusIR/Compiler/Datatype.hs

@@ -323,7 +323,8 @@ For a (self-)recursive datatype we have to change three things:
 mkScottTy :: MonadQuote m => ann -> Datatype TyName Name uni ann -> m (Type TyName uni ann)
 mkScottTy ann d@(Datatype _ _ _ _ constrs) = do
    res <- resultTypeName d
-   -- FIXME: normalize datacons' types also here
+   -- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1875):
+   -- normalize datacons' types also here
    let caseTys = fmap (constructorCaseType ann (TyVar ann res)) constrs
    pure $
       -- forall res.
@@ -389,7 +390,7 @@ mkConstructorType :: Datatype TyName Name uni (Provenance a) -> VarDecl TyName N
 -- this type appears *inside* the scope of the abstraction for the datatype so we can just reference the name and
 -- we don't need to do anything to the declared type
 -- see Note [Abstract data types]
--- FIXME: normalize constructors also here
+-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1875): normalize constructors also here
 mkConstructorType (Datatype _ _ tvs _ _) constr = PIR.mkIterTyForall tvs $ _varDeclType constr
 
 -- See Note [Encoding of datatypes]
@@ -421,7 +422,7 @@ mkConstructor opts dty d@(Datatype ann _ tvs _ constrs) index = do
     argsAndTypes <- do
         -- these types appear *outside* the scope of the abstraction for the datatype, so we need to use the concrete datatype here
         -- see Note [Abstract data types]
-        -- FIXME: normalize datacons' types also here
+        -- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1875): normalize datacons' types also here
         let argTypes = unveilDatatype (getType dty) d <$> constructorArgTypes thisConstr
         -- we don't have any names for these things, we just had the type, so we call them "arg_i
         argNames <- for [0..(length argTypes -1)] (\i -> safeFreshName $ "arg_" <> showText i)
@@ -445,7 +446,7 @@ mkConstructor opts dty d@(Datatype ann _ tvs _ constrs) index = do
             casesAndTypes <- do
                   -- these types appear *outside* the scope of the abstraction for the datatype, so we need to use the concrete datatype here
                   -- see Note [Abstract data types]
-                  -- FIXME: normalize datacons' types also here
+                  -- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1875): normalize datacons' types also here
                   let caseTypes = unveilDatatype (getType dty) d <$> fmap (constructorCaseType ann (TyVar ann resultType)) constrs
                   caseArgNames <- for constrs (\c -> safeFreshName $ "case_" <> T.pack (varDeclNameString c))
                   pure $ zipWith (VarDecl ann) caseArgNames caseTypes
@@ -506,7 +507,7 @@ mkDestructor opts dty d@(Datatype ann _ tvs _ constrs) = do
             caseVars <- for constrs $ \c -> do
                 -- these types appear *outside* the scope of the abstraction for the datatype, so we need to use the concrete datatype here
                 -- see Note [Abstract data types]
-                -- FIXME: normalize datacons' types also here
+                -- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1875): normalize datacons' types also here
                 let caseType = constructorCaseType ann (TyVar ann resultType) c
                     unveiledCaseType = unveilDatatype (getType dty) d caseType
                 caseArgName <- safeFreshName $ "case_" <> T.pack (varDeclNameString c)

plutus-core/plutus-ir/test/PlutusIR/Compiler/Let/Tests.hs

@@ -27,7 +27,8 @@ test_lets =
         , goldenPlcFromPir pTermAsProg "letDep"
         ]
 
--- FIXME: this fails because some of the let passes expect certain things to be
+-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1876):
+-- this fails because some of the let passes expect certain things to be
 -- gone, e.g. non-strict bindings. We should a) add pre-/post-conditions for these,
 -- and b) set up the tests to establish what is needed
 test_propLets :: TestTree

plutus-core/plutus-ir/test/PlutusIR/Transform/DeadCode/Tests.hs

@@ -38,7 +38,8 @@ test_deadCode =
             , "pruneDatatype"
             ]
 
--- FIXME this test sometimes fails so ignoring it to make CI pass.
+-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1877):
+-- this test sometimes fails so ignoring it to make CI pass.
 typecheckRemoveDeadBindingsProp :: BuiltinSemanticsVariant DefaultFun -> Property
 typecheckRemoveDeadBindingsProp biVariant =
   withMaxSuccess (3 * numTestsForPassProp) $

plutus-core/untyped-plutus-core/src/UntypedPlutusCore/Evaluation/Machine/Cek/Internal.hs

@@ -857,7 +857,8 @@ enterComputeCek = computeCek
     returnCek (FrameAwaitFunTerm argVarEnv arg ctx) fun =
         computeCek (FrameAwaitArg fun ctx) argVarEnv arg
     -- s , [(lam x (M,ρ)) _] ◅ V  ↦  s ; ρ [ x  ↦  V ] ▻ M
-    -- FIXME: add rule for VBuiltin once it's in the specification.
+    -- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1878):
+    -- add rule for VBuiltin once it's in the specification.
     returnCek (FrameAwaitArg fun ctx) arg =
         applyEvaluate ctx fun arg
     -- s , [_ V] ◅ lam x (M,ρ) ↦ s ; ρ [ x  ↦  V ] ▻ M

plutus-core/untyped-plutus-core/src/UntypedPlutusCore/Evaluation/Machine/SteppableCek/Internal.hs

@@ -175,7 +175,8 @@ returnCek (FrameAwaitFunTerm _funAnn argVarEnv arg ctx) fun =
     -- MAYBE: perhaps it is worth here to merge the _funAnn with argAnn
     pure $ Computing (FrameAwaitArg (termAnn arg) fun ctx) argVarEnv arg
 -- s , [(lam x (M,ρ)) _] ◅ V  ↦  s ; ρ [ x  ↦  V ] ▻ M
--- FIXME: add rule for VBuiltin once it's in the specification.
+-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1878):
+-- add rule for VBuiltin once it's in the specification.
 returnCek (FrameAwaitArg _ fun ctx) arg =
     applyEvaluate ctx fun arg
 -- s , [_ V1 .. Vn] ◅ lam x (M,ρ)  ↦  s , [_ V2 .. Vn]; ρ [ x  ↦  V1 ] ▻ M
@@ -411,7 +412,8 @@ lenContext = go 0
 
 
 -- * Duplicated functions from Cek.Internal module
--- FIXME: share these functions with Cek.Internal
+-- FIXME (https://github.com/IntersectMBO/plutus-private/issues/1879):
+-- share these functions with Cek.Internal
 -- preliminary testing shows that sharing slows down original cek
 
 cekStepCost :: CekMachineCosts -> StepKind -> ExBudget