feat: update parameter names and test expectations for Value builtins

Unisay · Unisay · commit a8326dfd4a07 · 2025-10-14T10:49:28.000+02:00
Adds cost model parameter names for LookupCoin, ValueContains, ValueData,
and UnValueData builtins (11 new parameters per ledger API version). Updates
parameter count expectations to reflect the expanded parameter set.

Updates golden type signatures and conformance test budget expectations to
reflect the refined ValueLogOuterOrMaxInner type signature, ensuring accurate
cost accounting for Value-based operations.
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/lookupCoin/absent/absent.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/lookupCoin/absent/absent.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000112100
-| mem: 100000000800})
+({cpu: 338744
+| mem: 801})
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/lookupCoin/present/present.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/lookupCoin/present/present.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000112100
-| mem: 100000000800})
+({cpu: 338744
+| mem: 801})
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/ccy-missing/ccy-missing.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/ccy-missing/ccy-missing.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000080100
-| mem: 100000000600})
+({cpu: 269422
+| mem: 601})
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/empty/empty.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/empty/empty.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000080100
-| mem: 100000000600})
+({cpu: 81100
+| mem: 601})
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/multi-insufficient/multi-insufficient.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/multi-insufficient/multi-insufficient.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000080100
-| mem: 100000000600})
+({cpu: 269422
+| mem: 601})
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/multi-sufficient/multi-sufficient.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/multi-sufficient/multi-sufficient.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000080100
-| mem: 100000000600})
+({cpu: 269422
+| mem: 601})
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/reflexive/reflexive.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/reflexive/reflexive.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000080100
-| mem: 100000000600})
+({cpu: 269422
+| mem: 601})
diff --git a/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/token-missing/token-missing.uplc.budget.expected b/plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/valueContains/token-missing/token-missing.uplc.budget.expected
@@ -1,2 +1,2 @@
-({cpu: 100000080100
-| mem: 100000000600})
+({cpu: 175261
+| mem: 601})
diff --git a/plutus-core/plutus-core/test/TypeSynthesis/Golden/Signatures/DefaultFun/LookupCoin.golden.sig b/plutus-core/plutus-core/test/TypeSynthesis/Golden/Signatures/DefaultFun/LookupCoin.golden.sig
@@ -1 +1 @@
-ByteString -> ByteString -> Value -> Integer
+ByteString -> ByteString -> ValueLogOuterOrMaxInner -> Integer
diff --git a/plutus-core/plutus-core/test/TypeSynthesis/Golden/Signatures/DefaultFun/ValueContains.golden.sig b/plutus-core/plutus-core/test/TypeSynthesis/Golden/Signatures/DefaultFun/ValueContains.golden.sig
@@ -1 +1 @@
-Value -> Value -> BuiltinResult Bool
+ValueLogOuterOrMaxInner -> ValueTotalSize -> BuiltinResult Bool
diff --git a/plutus-ledger-api/src/PlutusLedgerApi/V1/ParamName.hs b/plutus-ledger-api/src/PlutusLedgerApi/V1/ParamName.hs
@@ -318,6 +318,17 @@ data ParamName =
   | Bls12_381_G2_multiScalarMul'cpu'arguments'intercept
   | Bls12_381_G2_multiScalarMul'cpu'arguments'slope
   | Bls12_381_G2_multiScalarMul'memory'arguments
+  | LookupCoin'cpu'arguments'intercept
+  | LookupCoin'cpu'arguments'slope
+  | LookupCoin'memory'arguments
+  | ValueContains'cpu'arguments'intercept
+  | ValueContains'cpu'arguments'slope
+  | ValueContains'memory'arguments
+  | ValueData'cpu'arguments
+  | ValueData'memory'arguments
+  | UnValueData'cpu'arguments'intercept
+  | UnValueData'cpu'arguments'slope
+  | UnValueData'memory'arguments
     deriving stock (Eq, Ord, Enum, Ix, Bounded, Generic)
     deriving IsParamName via (GenericParamName ParamName)
 
diff --git a/plutus-ledger-api/src/PlutusLedgerApi/V2/ParamName.hs b/plutus-ledger-api/src/PlutusLedgerApi/V2/ParamName.hs
@@ -320,5 +320,16 @@ data ParamName =
   | Bls12_381_G2_multiScalarMul'cpu'arguments'intercept
   | Bls12_381_G2_multiScalarMul'cpu'arguments'slope
   | Bls12_381_G2_multiScalarMul'memory'arguments
+  | LookupCoin'cpu'arguments'intercept
+  | LookupCoin'cpu'arguments'slope
+  | LookupCoin'memory'arguments
+  | ValueContains'cpu'arguments'intercept
+  | ValueContains'cpu'arguments'slope
+  | ValueContains'memory'arguments
+  | ValueData'cpu'arguments
+  | ValueData'memory'arguments
+  | UnValueData'cpu'arguments'intercept
+  | UnValueData'cpu'arguments'slope
+  | UnValueData'memory'arguments
     deriving stock (Eq, Ord, Enum, Ix, Bounded, Generic)
     deriving IsParamName via (GenericParamName ParamName)
diff --git a/plutus-ledger-api/src/PlutusLedgerApi/V3/ParamName.hs b/plutus-ledger-api/src/PlutusLedgerApi/V3/ParamName.hs
@@ -336,5 +336,16 @@ data ParamName =
   | Bls12_381_G2_multiScalarMul'cpu'arguments'intercept
   | Bls12_381_G2_multiScalarMul'cpu'arguments'slope
   | Bls12_381_G2_multiScalarMul'memory'arguments
+  | LookupCoin'cpu'arguments'intercept
+  | LookupCoin'cpu'arguments'slope
+  | LookupCoin'memory'arguments
+  | ValueContains'cpu'arguments'intercept
+  | ValueContains'cpu'arguments'slope
+  | ValueContains'memory'arguments
+  | ValueData'cpu'arguments
+  | ValueData'memory'arguments
+  | UnValueData'cpu'arguments'intercept
+  | UnValueData'cpu'arguments'slope
+  | UnValueData'memory'arguments
     deriving stock (Eq, Ord, Enum, Ix, Bounded, Generic)
     deriving IsParamName via (GenericParamName ParamName)
diff --git a/plutus-ledger-api/test/Spec/CostModelParams.hs b/plutus-ledger-api/test/Spec/CostModelParams.hs
@@ -28,9 +28,9 @@ tests =
     "CostModelParams"
     "costModelParams"
     [ embed $ testCase "length" do
-        301 @=? length v1_ParamNames
-        301 @=? length v2_ParamNames
-        319 @=? length v3_ParamNames
+        312 @=? length v1_ParamNames
+        312 @=? length v2_ParamNames
+        330 @=? length v3_ParamNames
     , embed $ testCase "tripping paramname" do
         for_ v1_ParamNames \p ->
           assertBool "tripping v1 cm params failed" $
diff --git a/plutus-ledger-api/test/Spec/Data/CostModelParams.hs b/plutus-ledger-api/test/Spec/Data/CostModelParams.hs
@@ -28,9 +28,9 @@ tests =
     "CostModelParams"
     "costModelParams"
     [ embed $ testCase "length" do
-        301 @=? length v1_ParamNames
-        301 @=? length v2_ParamNames
-        319 @=? length v3_ParamNames
+        312 @=? length v1_ParamNames
+        312 @=? length v2_ParamNames
+        330 @=? length v3_ParamNames
     , embed $ testCase "tripping paramname" do
         for_ v1_ParamNames \p ->
           assertBool "tripping v1 cm params failed" $

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-ByteString -> ByteString -> Value -> Integer`
	`1`	`+ByteString -> ByteString -> ValueLogOuterOrMaxInner -> Integer`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-Value -> Value -> BuiltinResult Bool`
	`1`	`+ValueLogOuterOrMaxInner -> ValueTotalSize -> BuiltinResult Bool`