Revert "[Builtins] Disable 'writeBits' for changPlus1 (#6536)" (#6554)

This reverts commit 9eba5de.

Author: kwxm

plutus-ledger-api/src/PlutusLedgerApi/Common/Versions.hs

@@ -122,12 +122,12 @@ builtinsIntroducedIn = Map.fromList [
           ]),
   ((PlutusV3, changPlus1PV), Set.fromList [
           AndByteString, OrByteString, XorByteString, ComplementByteString,
-          ReadBit, ReplicateByte,
+          ReadBit, WriteBits, ReplicateByte,
           ShiftByteString, RotateByteString, CountSetBits, FindFirstSetBit,
           Ripemd_160
           ]),
   ((PlutusV3, futurePV), Set.fromList [
-          WriteBits, ExpModInteger
+          ExpModInteger
           ])
   ]
 

plutus-ledger-api/src/PlutusLedgerApi/V3/ParamName.hs

@@ -288,6 +288,10 @@ data ParamName =
   | ComplementByteString'memory'arguments'slope
   | ReadBit'cpu'arguments
   | ReadBit'memory'arguments
+  | WriteBits'cpu'arguments'intercept
+  | WriteBits'cpu'arguments'slope
+  | WriteBits'memory'arguments'intercept
+  | WriteBits'memory'arguments'slope
   | ReplicateByte'cpu'arguments'intercept
   | ReplicateByte'cpu'arguments'slope
   | ReplicateByte'memory'arguments'intercept
@@ -311,10 +315,6 @@ data ParamName =
   | Ripemd_160'memory'arguments
 
 --  not enabled yet:
---    WriteBits'cpu'arguments'intercept
---    WriteBits'cpu'arguments'slope
---    WriteBits'memory'arguments'intercept
---    WriteBits'memory'arguments'slope
 --    ExpModInteger'cpu'arguments
 --    ExpModInteger'memory'arguments
     deriving stock (Eq, Ord, Enum, Ix, Bounded, Generic)

plutus-ledger-api/test/Spec/CostModelParams.hs

@@ -28,7 +28,7 @@ tests =
     [ testCase "length" $ do
             166 @=? length v1_ParamNames
             185 @=? length v2_ParamNames
-            293 @=? length v3_ParamNames
+            297 @=? length v3_ParamNames
     , testCase "tripping paramname" $ do
             for_ v1_ParamNames $ \ p ->
                 assertBool "tripping v1 cm params failed" $ Just p == readParamName (showParamName p)

plutus-ledger-api/test/Spec/Data/CostModelParams.hs

@@ -26,7 +26,7 @@ tests =
     [ testCase "length" $ do
             166 @=? length v1_ParamNames
             185 @=? length v2_ParamNames
-            293 @=? length v3_ParamNames
+            297 @=? length v3_ParamNames
     , testCase "tripping paramname" $ do
             for_ v1_ParamNames $ \ p ->
                 assertBool "tripping v1 cm params failed" $ Just p == readParamName (showParamName p)

plutus-ledger-api/testlib/PlutusLedgerApi/Test/V3/Data/EvaluationContext.hs

@@ -76,13 +76,13 @@ clearBuiltinCostModel r = r
                , paramXorByteString = mempty
                , paramComplementByteString = mempty
                , paramReadBit = mempty
+               , paramWriteBits = mempty
                , paramReplicateByte = mempty
                , paramShiftByteString = mempty
                , paramRotateByteString = mempty
                , paramCountSetBits = mempty
                , paramFindFirstSetBit = mempty
                , paramRipemd_160 = mempty
-               , paramWriteBits = mempty
                , paramExpModInteger = mempty
                }
 
@@ -93,6 +93,5 @@ clearBuiltinCostModel' :: (m ~ MBuiltinCostModel) => m -> m
 clearBuiltinCostModel' r = r
                { -- , paramIntegerToByteString = mempty -- Required for V2
                -- , paramByteStringToInteger = mempty -- Required for V2
-                 paramWriteBits = mempty
-               , paramExpModInteger = mempty
+                 paramExpModInteger = mempty
                }

plutus-ledger-api/testlib/PlutusLedgerApi/Test/V3/EvaluationContext.hs

@@ -77,13 +77,13 @@ clearBuiltinCostModel r = r
                , paramXorByteString = mempty
                , paramComplementByteString = mempty
                , paramReadBit = mempty
+               , paramWriteBits = mempty
                , paramReplicateByte = mempty
                , paramShiftByteString = mempty
                , paramRotateByteString = mempty
                , paramCountSetBits = mempty
                , paramFindFirstSetBit = mempty
                , paramRipemd_160 = mempty
-               , paramWriteBits = mempty
                , paramExpModInteger = mempty
                }
 
@@ -94,6 +94,5 @@ clearBuiltinCostModel' :: (m ~ MBuiltinCostModel) => m -> m
 clearBuiltinCostModel' r = r
                { -- , paramIntegerToByteString = mempty -- Required for V2
                -- , paramByteStringToInteger = mempty -- Required for V2
-                 paramWriteBits = mempty
-               , paramExpModInteger = mempty
+                 paramExpModInteger = mempty
                }