Fix typos in Plutus Core Spec of Batch 5 builtins#6760
Merged
kwxm merged 3 commits intoIntersectMBO:masterfrom Dec 23, 2024
Merged
Fix typos in Plutus Core Spec of Batch 5 builtins#6760kwxm merged 3 commits intoIntersectMBO:masterfrom
kwxm merged 3 commits intoIntersectMBO:masterfrom
Conversation
Contributor
|
Thanks for the corrections! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plutus core spec Builtins Batch 5 Note 1 mentions that for the extending case of and/xor/orByteString, the bytestrings are extended with 0/1/1 respectively. This contradicts conformance test andByteString/case-06 and the statement a few sentences later that "In both cases, the otuput is the same as the input when 𝑘 = 0". Moreover the formular later also contradicts this. I assume this is a simple case of flipped bit in the first mention.
Further: