Skip to content

Comments

Fix typos in Plutus Core Spec of Batch 5 builtins#6760

Merged
kwxm merged 3 commits intoIntersectMBO:masterfrom
nielstron:patch-2
Dec 23, 2024
Merged

Fix typos in Plutus Core Spec of Batch 5 builtins#6760
kwxm merged 3 commits intoIntersectMBO:masterfrom
nielstron:patch-2

Conversation

@nielstron
Copy link
Contributor

@nielstron nielstron commented Dec 20, 2024

The plutus core spec Builtins Batch 5 Note 1 mentions that for the extending case of and/xor/orByteString, the bytestrings are extended with 0/1/1 respectively. This contradicts conformance test andByteString/case-06 and the statement a few sentences later that "In both cases, the otuput is the same as the input when 𝑘 = 0". Moreover the formular later also contradicts this. I assume this is a simple case of flipped bit in the first mention.

Further:

  • fix typo otuput -> output
  • fix typo in return type of readBit: bytestring -> bool

@nielstron nielstron changed the title Fix flipped bits for and/or/xorbytestring True case Fix flipped bits in Spec of and/or/xorByteString Dec 20, 2024
@nielstron nielstron changed the title Fix flipped bits in Spec of and/or/xorByteString Fix typos in Plutus Core Spec of Batch 5 builtins Dec 20, 2024
@kwxm kwxm added Specification No Changelog Required Add this to skip the Changelog Check labels Dec 23, 2024
@kwxm
Copy link
Contributor

kwxm commented Dec 23, 2024

Thanks for the corrections!

@kwxm kwxm merged commit 5952b30 into IntersectMBO:master Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Changelog Required Add this to skip the Changelog Check Specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants