Add active model callbacks around assign_form_attributes and submit

Author: Intrepidd

lib/hyper_active_form/base.rb

@@ -8,6 +8,9 @@ class Base
     include ActiveModel::Model
     include ActiveModel::Attributes
     include ActiveModel::Validations
+    extend ActiveModel::Callbacks
+
+    define_model_callbacks :assign_form_attributes, :submit
 
     def self.proxy_for(klass, object)
       delegate :new_record?, :persisted?, :id, to: object
@@ -26,16 +29,20 @@ def perform
     end
 
     def assign_form_attributes(params)
-      params = ActionController::Parameters.new(params) unless params.is_a?(ActionController::Parameters)
-      attribute_names.each do |attribute|
-        default_value = self.class._default_attributes[attribute]&.value_before_type_cast
-        public_send(:"#{attribute}=", params&.dig(attribute) || default_value)
+      run_callbacks :assign_form_attributes do
+        params = ActionController::Parameters.new(params) unless params.is_a?(ActionController::Parameters)
+        attribute_names.each do |attribute|
+          default_value = self.class._default_attributes[attribute]&.value_before_type_cast
+          public_send(:"#{attribute}=", params&.dig(attribute) || default_value)
+        end
       end
     end
 
     def submit(params)
-      assign_form_attributes(params)
-      !!(valid? && perform)
+      run_callbacks :submit do
+        assign_form_attributes(params)
+        !!(valid? && perform)
+      end
     rescue HyperActiveForm::CancelFormSubmit
       false
     end

spec/hyper_active_form/base_spec.rb

@@ -51,6 +51,12 @@ def perform
       expect(form.age).to eq(nil)
       expect(form.hobbies).to eq([])
     end
+
+    it "runs the assign_form_attributes callback" do
+      form = dummy_class.new(name: "John", age: 20)
+      expect(form).to receive(:run_callbacks).with(:assign_form_attributes)
+      form.assign_form_attributes(name: "Mike")
+    end
   end
 
   describe "#submit" do
@@ -61,6 +67,12 @@ def perform
         expect(form.submit(name: "Fred", age: 19)).to eq(true)
       end
 
+      it "runs the submit callback" do
+        form = dummy_class.new(name: "John", age: 20, callable:)
+        expect(form).to receive(:run_callbacks).with(:submit)
+        form.submit(name: "Fred", age: 19)
+      end
+
     end
 
     context "when the form is invalid" do