fixed dummy thread

Author: ealon-r7

sergeant/slave.py

@@ -99,7 +99,7 @@ def kill_running_background_threads() -> bool:
         if thread is threading.main_thread():
             continue
 
-        if thread.ident:
+        if thread.ident and not isinstance(thread, threading._DummyThread):
             ctypes.pythonapi.PyThreadState_SetAsyncExc(
                 ctypes.c_ulong(thread.ident),
                 ctypes.py_object(SystemExit),

tests/docker-compose.yml

@@ -11,13 +11,29 @@ services:
             - 6380:6379
     mongo-node-one:
         image: mongo
+        restart: always
         ports:
             - 27017:27017
         command: >
-            mongod --port 27017 --replSet test_replica_set --bind_ip_all
+            mongod --replSet test_replica_set --bind_ip_all
+        container_name: mongo-one
+        volumes:
+            - mongo1_data:/data/db
+
     mongo-node-two:
         image: mongo
+        restart: always
         ports:
-            - 27018:27018
+            - 27018:27017
         command: >
-            mongod --port 27018 --replSet test_replica_set --bind_ip_all
+            mongod --replSet test_replica_set --bind_ip_all
+        container_name: mongo-two
+        volumes:
+            - mongo2_data:/data/db
+
+
+volumes:
+    mongo1_data:
+        driver: local
+    mongo2_data:
+        driver: local

tests/supervisor/test_slave_dummy_thread.py

@@ -0,0 +1,36 @@
+import ctypes
+import pytest
+import threading
+import time
+
+import sergeant.slave
+
+
+def dummy_thread():
+    while True:
+        time.sleep(0.1)
+
+
+@pytest.fixture
+def background_threads():
+    threads = [threading.Thread(target=dummy_thread, daemon=False) for _ in range(3)]
+    
+    for thread in threads:
+        thread.start()
+    
+    yield threads
+    
+    for thread in threads:
+        if thread.is_alive():
+            ctypes.pythonapi.PyThreadState_SetAsyncExc(
+                ctypes.c_ulong(thread.ident),
+                ctypes.py_object(SystemExit),
+            )
+            thread.join()
+
+
+def test_kill_running_background_threads(background_threads):
+    assert sergeant.slave.kill_running_background_threads() is True
+    
+    for thread in background_threads:
+        assert not thread.is_alive()