Skip to content

Commit 4d61da0

Browse files
author
zhengbw
committed
keep with "UserName"/"Password"
1 parent 8023b08 commit 4d61da0

File tree

8 files changed

+29
-17
lines changed

8 files changed

+29
-17
lines changed

sample/Startup.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ public void ConfigureServices(IServiceCollection services)
4646
authenticationOptions.AuthScheme = CookieAuthenticationDefaults.AuthenticationScheme;
4747
authenticationOptions.SilkierQuartzClaim = "Silkier";
4848
authenticationOptions.SilkierQuartzClaimValue = "Quartz";
49-
49+
authenticationOptions.UserName = "root";
50+
authenticationOptions.Password = "password";
5051
authenticationOptions.AccessRequirement = SilkierQuartzAuthenticationOptions.SimpleAccessRequirement.AllowOnlyUsersWithClaim;
5152
}
5253
#else

src/SilkierQuartz/Authorization/SilkierQuartzAuthenticationOptions.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,15 @@ public enum SimpleAccessRequirement
2121

2222
public const string AuthorizationPolicyName = "SilkierQuartz";
2323

24-
public const string DefaultUserName = "admin";
25-
public const string DefaultPassword = "password";
24+
public string UserName { get; set; } = "admin";
25+
public string Password { get; set; } = "password";
2626

27-
public Func<string, string, bool> Authenticate = (userName, password) =>
27+
public Func<string, string, string, string, bool> Authenticate = (reqUserName,
28+
reqPassword, verifyUserName, verifyPassword) =>
2829
{
2930
return
30-
string.Compare(userName, SilkierQuartzAuthenticationOptions.DefaultUserName, StringComparison.InvariantCulture) == 0 &&
31-
string.Compare(password, SilkierQuartzAuthenticationOptions.DefaultPassword, StringComparison.InvariantCulture) == 0;
31+
string.Compare(reqUserName, verifyUserName, StringComparison.InvariantCulture) == 0 &&
32+
string.Compare(reqPassword, verifyPassword, StringComparison.InvariantCulture) == 0;
3233
};
3334

3435
/// <summary>

src/SilkierQuartz/Controllers/AuthenticateController.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public async Task<IActionResult> Login([FromServices] IAuthenticationSchemeProvi
4141
!HttpContext.User.HasClaim(authenticationOptions.SilkierQuartzClaim,
4242
authenticationOptions.SilkierQuartzClaimValue))
4343
{
44-
await SignIn(false, SilkierQuartzAuthenticationOptions.DefaultUserName, SilkierQuartzAuthenticationOptions.DefaultPassword);
44+
await SignIn(false, authenticationOptions.UserName, authenticationOptions.Password);
4545
return RedirectToAction(nameof(SchedulerController.Index), nameof(Scheduler));
4646
}
4747
else
@@ -68,7 +68,9 @@ public async Task<IActionResult> Login([FromServices] IAuthenticationSchemeProvi
6868
public async Task<IActionResult> Login([FromForm] AuthenticateViewModel request)
6969
{
7070
var form = HttpContext.Request.Form;
71-
if (!authenticationOptions.Authenticate(request.UserName, request.Password))
71+
if (!authenticationOptions.Authenticate(request.UserName,
72+
request.Password, authenticationOptions.UserName,
73+
authenticationOptions.Password))
7274
{
7375
request.IsLoginError = true;
7476
return View(request);
@@ -94,11 +96,11 @@ private async Task SignIn(bool isPersistentSignIn, string userName, string passw
9496
{
9597
new Claim(ClaimTypes.NameIdentifier, string.IsNullOrEmpty(userName)
9698
? "SilkierQuartzAdmin"
97-
: SilkierQuartzAuthenticationOptions.DefaultUserName),
99+
: authenticationOptions.UserName),
98100

99101
new Claim(ClaimTypes.Name, string.IsNullOrEmpty(password)
100102
? "SilkierQuartzPassword"
101-
: SilkierQuartzAuthenticationOptions.DefaultPassword),
103+
: authenticationOptions.Password),
102104

103105
new Claim(authenticationOptions.SilkierQuartzClaim, authenticationOptions.SilkierQuartzClaimValue)
104106
};

src/SilkierQuartz/Helpers/HandlebarsHelpers.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ void footer(EncodedTextWriter writer, BlockHelperOptions options, Context contex
281281
options.Template(writer, (object)context);
282282
}
283283
}
284+
284285
void SilkierQuartzVersion(EncodedTextWriter output, Context context, Arguments arguments)
285286
{
286287
var v = GetType().Assembly.GetCustomAttributes<AssemblyInformationalVersionAttribute>().FirstOrDefault();
@@ -295,11 +296,13 @@ void ProductName(EncodedTextWriter output, Context context, Arguments arguments)
295296
{
296297
output.Write(_services.Options.ProductName);
297298
}
298-
void CustomStyleSheet(TextWriter output, dynamic context, params object[] arguments)
299+
300+
void CustomStyleSheet(EncodedTextWriter output, Context context, Arguments arguments)
299301
{
300302
output.Write(_services.Options.CustomStyleSheet);
301303
}
302-
void CustomFavicon(TextWriter output, dynamic context, params object[] arguments)
304+
305+
void CustomFavicon(EncodedTextWriter output, Context context, Arguments arguments)
303306
{
304307
output.Write(_services.Options.CustomFavicon);
305308
}

src/SilkierQuartz/SilkierQuartzAttribute.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ public SilkierQuartzAttribute(double hours, double minutes, double seconds, stri
2222
public SilkierQuartzAttribute(double minutes, double seconds, string _identity, string? _group, string _desciption) : this(0, 0, minutes, seconds, 0, 0, _identity, _group, _desciption)
2323
{
2424
}
25+
2526
public SilkierQuartzAttribute(double seconds, string _identity, string? _group, string _desciption) : this(0, 0, 0, seconds, 0, 0, _identity, _group, _desciption)
2627
{
2728
}
@@ -37,6 +38,7 @@ public SilkierQuartzAttribute(double hours, double minutes, double seconds) : th
3738
public SilkierQuartzAttribute(double minutes, double seconds) : this(0, 0, minutes, seconds, 0, 0, null, null, null)
3839
{
3940
}
41+
4042
public SilkierQuartzAttribute(double seconds) : this(0, 0, 0, seconds, 0, 0, null, null, null)
4143
{
4244
}
@@ -55,6 +57,7 @@ public SilkierQuartzAttribute(double days, double hours, double minutes, double
5557
+ seconds * TimeSpan.TicksPerSecond
5658
+ milliseconds + TimeSpan.TicksPerMillisecond));
5759
}
60+
5861
public string Desciption { get; set; } = null;
5962
public string Identity { get; set; } = null;
6063
public string Group { get; set; } = null;

src/SilkierQuartz/Views/Calendars/Index.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<input type="text" placeholder="Search Calendar..." id="search-calendar">
77
<i class="search icon"></i>
88
</div>
9-
{{#if ViewBag.EnableEdit }}
9+
{{#if ViewBag.EnableEdit}}
1010
<a class="ui right floated primary button" href="{{ActionUrl 'New'}}">
1111
<i class="plus icon"></i>New
1212
</a>

src/SilkierQuartz/Views/Jobs/Index.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
{{/each}}
2222
</div>
2323
</div>
24-
{{#if ViewBag.EnableEdit }}
24+
{{#if ViewBag.EnableEdit}}
2525
<a class="ui right floated primary button" href="{{ActionUrl 'New'}}">
2626
<i class="plus icon"></i>New
2727
</a>
@@ -65,12 +65,12 @@
6565

6666
<div style="display:none">
6767
<div class="ui small vertical menu borderless" id="job-context-menu">
68-
{{#if ViewBag.EnableEdit }}
68+
{{#if ViewBag.EnableEdit}}
6969
<a class="item menu-edit"><i class="left large blue pencil alternate icon"></i>Edit</a>
7070
<a class="item menu-copy"><i class="left large clone outline icon"></i>Copy</a>
7171
{{/if}}
7272
<a class="item menu-trigger"><i class="left large green play icon"></i>Trigger</a>
73-
{{#if ViewBag.EnableEdit }}
73+
{{#if ViewBag.EnableEdit}}
7474
<a class="item menu-delete"><i class="left large red trash alternate outline icon"></i>Delete</a>
7575
{{/if}}
7676
</div>

src/SilkierQuartz/Views/Triggers/Index.hbs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
{{/each}}
2222
</div>
2323
</div>
24-
{{#if ViewBag.EnableEdit }}
24+
{{#if ViewBag.EnableEdit}}
2525
<a class="ui right floated primary button" href="{{ActionUrl 'New'}}">
2626
<i class="plus icon"></i>New
2727
</a>
@@ -51,8 +51,10 @@
5151
</td>
5252
<td class="job-group">{{JobGroup}}</td>
5353
<td colspan="6" style="text-align: right">
54+
{{#if EnableEdit}}
5455
<a href="{{ActionUrl 'PauseJob' 'Triggers'}}" class="ui super tiny button btn-pause-all"><i class="pause icon"></i>Pause All</a>
5556
<a href="{{ActionUrl 'ResumeJob' 'Triggers'}}" class="ui super tiny button btn-resume-all"><i class="play icon"></i>Resume All</a>
57+
{{/if}}
5658
</td>
5759
</tr>
5860
{{/if}}

0 commit comments

Comments
 (0)