Skip to content

Commit 7674da0

Browse files
committed
refactor(common, matcher): extract sample text
1 parent 423ff6f commit 7674da0

File tree

18 files changed

+135
-189
lines changed

18 files changed

+135
-189
lines changed

application/src/androidMain/kotlin/com/neoutils/neoregex/NeoAndroidApp.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import com.neoutils.neoregex.core.datasource.di.dataSourceModule
2525
import com.neoutils.neoregex.core.dispatcher.di.dispatcherModule
2626
import com.neoutils.neoregex.core.manager.di.managerModule
2727
import com.neoutils.neoregex.core.repository.di.repositoryModule
28-
import com.neoutils.neoregex.di.appModule
2928
import com.neoutils.neoregex.feature.matcher.di.matcherModule
3029
import com.neoutils.neoregex.feature.saved.di.savedModule
3130
import com.neoutils.neoregex.feature.validator.di.validatorModule
@@ -52,7 +51,6 @@ class NeoAndroidApp : Application() {
5251
matcherModule,
5352
validatorModule,
5453
savedModule,
55-
appModule
5654
)
5755
}
5856
}

application/src/commonMain/kotlin/com/neoutils/neoregex/App.kt

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,10 @@ import androidx.compose.runtime.LaunchedEffect
2323
import androidx.compose.runtime.rememberCoroutineScope
2424
import androidx.compose.ui.Modifier
2525
import cafe.adriel.voyager.core.annotation.InternalVoyagerApi
26-
import cafe.adriel.voyager.koin.koinNavigatorScreenModel
2726
import cafe.adriel.voyager.navigator.Navigator
2827
import cafe.adriel.voyager.navigator.internal.BackHandler
2928
import cafe.adriel.voyager.transitions.FadeTransition
3029
import com.neoutils.neoregex.core.designsystem.theme.NeoBackground
31-
import com.neoutils.neoregex.core.dispatcher.control.Controller
32-
import com.neoutils.neoregex.core.dispatcher.event.Command
3330
import com.neoutils.neoregex.core.dispatcher.model.Navigation
3431
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManager
3532
import com.neoutils.neoregex.feature.about.screen.AboutScreen
@@ -45,7 +42,6 @@ import org.koin.compose.koinInject
4542
fun App(
4643
modifier: Modifier = Modifier,
4744
navigation: NavigationManager = koinInject(),
48-
controller: Controller = koinInject()
4945
) = NeoBackground(modifier) {
5046

5147
val coroutine = rememberCoroutineScope()
@@ -54,8 +50,6 @@ fun App(
5450
screen = MatcherScreen(),
5551
) { navigator ->
5652

57-
val viewModel = navigator.koinNavigatorScreenModel<AppViewModel>()
58-
5953
BackHandler(enabled = true) {
6054
coroutine.launch {
6155
navigation.emit(
@@ -107,25 +101,6 @@ fun App(
107101
}
108102
}
109103

110-
LaunchedEffect(Unit) {
111-
controller.event.collect { event ->
112-
when (event) {
113-
Command.New -> {
114-
viewModel.clear()
115-
navigator.replaceAll(
116-
navigator.items.map {
117-
when (it) {
118-
is MatcherScreen -> MatcherScreen()
119-
is ValidatorScreen -> ValidatorScreen()
120-
else -> it
121-
}
122-
}
123-
)
124-
}
125-
}
126-
}
127-
}
128-
129104
FadeTransition(navigator) {
130105
it.Content()
131106
}

application/src/commonMain/kotlin/com/neoutils/neoregex/AppViewModel.kt

Lines changed: 0 additions & 42 deletions
This file was deleted.

application/src/desktopMain/kotlin/com/neoutils/neoregex/App.desktop.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ import com.neoutils.neoregex.core.datasource.remember.rememberWindowState
5353
import com.neoutils.neoregex.core.designsystem.theme.NeoTheme
5454
import com.neoutils.neoregex.core.designsystem.theme.NeoTheme.dimensions
5555
import com.neoutils.neoregex.core.dispatcher.di.dispatcherModule
56-
import com.neoutils.neoregex.core.dispatcher.model.Navigation
57-
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManager
5856
import com.neoutils.neoregex.core.manager.di.managerModule
5957
import com.neoutils.neoregex.core.manager.salvage.SalvageManager
6058
import com.neoutils.neoregex.core.repository.di.repositoryModule
@@ -64,7 +62,6 @@ import com.neoutils.neoregex.core.sharedui.component.*
6462
import com.neoutils.neoregex.core.sharedui.di.WithKoin
6563
import com.neoutils.neoregex.core.sharedui.remember.WindowFocus
6664
import com.neoutils.neoregex.core.sharedui.remember.rememberWindowFocus
67-
import com.neoutils.neoregex.di.appModule
6865
import com.neoutils.neoregex.feature.matcher.di.matcherModule
6966
import com.neoutils.neoregex.feature.saved.di.savedModule
7067
import com.neoutils.neoregex.feature.validator.di.validatorModule
@@ -83,7 +80,6 @@ fun ApplicationScope.DesktopApp() = WithKoin(
8380
matcherModule,
8481
validatorModule,
8582
savedModule,
86-
appModule
8783
) {
8884

8985
val preferencesDataSource = koinInject<PreferencesDataSource>()
@@ -182,6 +178,7 @@ private fun FrameWindowScope.HeaderImpl(
182178
//navigation.emit(Navigation.Event.Invalidate())
183179
}
184180
}
181+
185182
SalvageAction.Update -> {
186183
coroutine.launch {
187184
salvageManager.update()

application/src/webMain/kotlin/com/neoutils/neoregex/App.web.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ import androidx.compose.ui.unit.Dp
4646
import androidx.compose.ui.unit.dp
4747
import androidx.compose.ui.unit.sp
4848
import androidx.lifecycle.compose.collectAsStateWithLifecycle
49-
import com.neoutils.neoregex.feature.validator.di.validatorModule
5049
import com.neoutils.neoregex.core.common.extension.toCss
5150
import com.neoutils.neoregex.core.common.util.ColorTheme
5251
import com.neoutils.neoregex.core.common.util.rememberColorTheme
@@ -66,8 +65,8 @@ import com.neoutils.neoregex.core.sharedui.component.Controller
6665
import com.neoutils.neoregex.core.sharedui.component.Options
6766
import com.neoutils.neoregex.core.sharedui.di.WithKoin
6867
import com.neoutils.neoregex.core.sharedui.extension.surface
69-
import com.neoutils.neoregex.di.appModule
7068
import com.neoutils.neoregex.feature.matcher.di.matcherModule
69+
import com.neoutils.neoregex.feature.validator.di.validatorModule
7170
import kotlinx.browser.document
7271
import org.jetbrains.compose.resources.stringResource
7372
import org.koin.compose.koinInject
@@ -81,13 +80,12 @@ fun WebApp() = WithKoin(
8180
dispatcherModule,
8281
matcherModule,
8382
validatorModule,
84-
appModule
8583
) {
8684

8785
val preferencesDataSource = koinInject<PreferencesDataSource>()
8886

8987
val preferences by preferencesDataSource.flow.collectAsStateWithLifecycle()
90-
88+
9189
NeoTheme(
9290
colorTheme = when (preferences.colorTheme) {
9391
Preferences.ColorTheme.SYSTEM -> rememberColorTheme()
@@ -125,6 +123,7 @@ fun WebApp() = WithKoin(
125123
}
126124
}
127125

126+
@OptIn(ExperimentalMaterial3Api::class)
128127
@Composable
129128
private fun Header(
130129
modifier: Modifier = Modifier,

core/dispatcher/src/androidMain/kotlin/com/neoutils/neoregex/core/dispatcher/di/NavigationModule.android.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,11 @@
1818

1919
package com.neoutils.neoregex.core.dispatcher.di
2020

21-
import com.neoutils.neoregex.core.dispatcher.control.Controller
22-
import com.neoutils.neoregex.core.dispatcher.control.ControllerImpl
2321
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManager
2422
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManagerImpl
2523
import org.koin.dsl.bind
2624
import org.koin.dsl.module
2725

2826
actual val dispatcherModule = module {
2927
single { NavigationManagerImpl() } bind NavigationManager::class
30-
single { ControllerImpl() } bind Controller::class
3128
}

core/dispatcher/src/commonMain/kotlin/com/neoutils/neoregex/core/dispatcher/control/ControllerImpl.kt

Lines changed: 0 additions & 34 deletions
This file was deleted.

core/dispatcher/src/commonMain/kotlin/com/neoutils/neoregex/core/dispatcher/event/Command.kt

Lines changed: 0 additions & 23 deletions
This file was deleted.

core/dispatcher/src/desktopMain/kotlin/com/neoutils/neoregex/core/dispatcher/di/NavigationModule.desktop.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,11 @@
1818

1919
package com.neoutils.neoregex.core.dispatcher.di
2020

21-
import com.neoutils.neoregex.core.dispatcher.control.Controller
22-
import com.neoutils.neoregex.core.dispatcher.control.ControllerImpl
2321
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManager
2422
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManagerImpl
2523
import org.koin.dsl.bind
2624
import org.koin.dsl.module
2725

2826
actual val dispatcherModule = module {
2927
single { NavigationManagerImpl() } bind NavigationManager::class
30-
single { ControllerImpl() } bind Controller::class
3128
}

core/dispatcher/src/webMain/kotlin/com/neoutils/neoregex/core/dispatcher/di/NavigationModule.web.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,11 @@
1818

1919
package com.neoutils.neoregex.core.dispatcher.di
2020

21-
import com.neoutils.neoregex.core.dispatcher.control.Controller
22-
import com.neoutils.neoregex.core.dispatcher.control.ControllerImpl
23-
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManager
2421
import com.neoutils.neoregex.core.dispatcher.impl.NavigationManagerWeb
22+
import com.neoutils.neoregex.core.dispatcher.navigator.NavigationManager
2523
import org.koin.dsl.bind
2624
import org.koin.dsl.module
2725

2826
actual val dispatcherModule = module {
2927
single { NavigationManagerWeb() } bind NavigationManager::class
30-
single { ControllerImpl() } bind Controller::class
3128
}

0 commit comments

Comments
 (0)