Skip to content

Commit f8316b7

Browse files
committed
update gradle to 8.13, update snapshot library to 4+, update java to 21
remove equals sign from snapshot hash
1 parent 595a0b3 commit f8316b7

File tree

9 files changed

+86
-80
lines changed

9 files changed

+86
-80
lines changed

glsl-preprocessor/build.gradle

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ plugins {
55
id 'signing'
66
id 'org.danilopianini.publish-on-central' version '0.7.5' // a newer version 2.0.6 exists but it's annoying to use
77
id 'jacoco'
8-
id 'com.adarshr.test-logger' version '3.2.0'
9-
// id "com.github.spotbugs" version "5.0.13"
8+
id 'com.adarshr.test-logger' version '3.2.0'
9+
// id "com.github.spotbugs" version "5.0.13"
1010
}
1111

1212
repositories {
@@ -18,23 +18,18 @@ group = "io.github.douira"
1818
version = '1.0.0'
1919

2020
dependencies {
21-
implementation group: 'org.slf4j', name: 'slf4j-api', version: '2.0.6'
21+
implementation group: 'org.slf4j', name: 'slf4j-api', version: '2.0.+'
2222
implementation group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: '4.7.3'
2323

24-
testImplementation group: 'io.github.origin-energy', name:'java-snapshot-testing-junit5', version: '3.2.+'
25-
}
24+
testImplementation group: 'io.github.origin-energy', name:'java-snapshot-testing-junit5', version: '4.+'
2625

27-
testing {
28-
suites {
29-
// Configure the built-in test suite
30-
test {
31-
// Use JUnit Jupiter test framework
32-
useJUnitJupiter('5.9.0')
33-
}
34-
}
26+
testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
27+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
3528
}
3629

3730
test {
31+
useJUnitPlatform()
32+
3833
// report is always generated after tests run
3934
finalizedBy jacocoTestReport
4035
testLogging.showStandardStreams = true
@@ -57,8 +52,6 @@ jacocoTestReport {
5752
}
5853
}
5954

60-
sourceCompatibility = 17
61-
6255
publishOnCentral {
6356
configureMavenCentral.set(true)
6457
projectDescription.set('GLSL Preprocessing with the C Preprocessor in Java - based on JCPP')

glsl-preprocessor/src/test/java/io/github/douira/glsl_preprocessor/VaArgsPastingTest.java

Lines changed: 32 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -19,25 +19,25 @@ public class VaArgsPastingTest {
1919

2020
@Test
2121
public void testWhitespacePasting() {
22-
String input = "#define REGULAR_ARGS(x, y) foo(x, y)\n"
23-
+ "#define REGULAR_ELLIPSIS(x, y...) foo(x, y)\n"
24-
+ "#define REGULAR_VAARGS(x, ...) foo(x, __VA_ARGS__)\n"
25-
+ "#define PASTE_ARGS(x, y) foo(x, ## y)\n"
26-
+ "#define PASTE_ELLIPSIS(x, y...) foo(x, ## y)\n"
27-
+ "#define PASTE_VAARGS(x, ...) foo(x, ## __VA_ARGS__)\n"
28-
+ ""
29-
+ "REGULAR_ARGS(a, b) // REGULAR_ARGS 2\n"
30-
+ "REGULAR_ELLIPSIS(a, b) // REGULAR_ELLIPSIS 2\n"
31-
+ "REGULAR_ELLIPSIS(a) // REGULAR_ELLIPSIS 1\n"
32-
+ "REGULAR_VAARGS(a, b) // REGULAR_VAARGS 2\n"
33-
+ "REGULAR_VAARGS(a) // REGULAR_VAARGS 1\n"
34-
+ ""
35-
+ "PASTE_ARGS(a, b) // PASTE_ARGS 2\n"
36-
+ "PASTE_ELLIPSIS(a, b) // PASTE_ELLIPSIS 2\n"
37-
+ "PASTE_ELLIPSIS(a) // PASTE_ELLIPSIS 1\n"
38-
+ "PASTE_VAARGS(a, b) // PASTE_VAARGS 2\n"
39-
+ "PASTE_VAARGS(a) // PASTE_VAARGS 1\n";
40-
LOG.info("Input is:\n" + input);
22+
String input = """
23+
#define REGULAR_ARGS(x, y) foo(x, y)
24+
#define REGULAR_ELLIPSIS(x, y...) foo(x, y)
25+
#define REGULAR_VAARGS(x, ...) foo(x, __VA_ARGS__)
26+
#define PASTE_ARGS(x, y) foo(x, ## y)
27+
#define PASTE_ELLIPSIS(x, y...) foo(x, ## y)
28+
#define PASTE_VAARGS(x, ...) foo(x, ## __VA_ARGS__)
29+
REGULAR_ARGS(a, b) // REGULAR_ARGS 2
30+
REGULAR_ELLIPSIS(a, b) // REGULAR_ELLIPSIS 2
31+
REGULAR_ELLIPSIS(a) // REGULAR_ELLIPSIS 1
32+
REGULAR_VAARGS(a, b) // REGULAR_VAARGS 2
33+
REGULAR_VAARGS(a) // REGULAR_VAARGS 1
34+
PASTE_ARGS(a, b) // PASTE_ARGS 2
35+
PASTE_ELLIPSIS(a, b) // PASTE_ELLIPSIS 2
36+
PASTE_ELLIPSIS(a) // PASTE_ELLIPSIS 1
37+
PASTE_VAARGS(a, b) // PASTE_VAARGS 2
38+
PASTE_VAARGS(a) // PASTE_VAARGS 1
39+
""";
40+
LOG.info("Input is:\n{}", input);
4141
Preprocessor pp = new Preprocessor();
4242
pp.addFeature(Feature.KEEPCOMMENTS);
4343
pp.addInput(new StringLexerSource(input, true));
@@ -49,16 +49,18 @@ public void testWhitespacePasting() {
4949
} finally {
5050
pp.close();
5151
}
52-
LOG.info("Output is:\n" + output);
53-
assertEquals("foo(a, b) // REGULAR_ARGS 2\n"
54-
+ "foo(a, b) // REGULAR_ELLIPSIS 2\n"
55-
+ "foo(a, ) // REGULAR_ELLIPSIS 1\n"
56-
+ "foo(a, b) // REGULAR_VAARGS 2\n"
57-
+ "foo(a, ) // REGULAR_VAARGS 1\n"
58-
+ "foo(a,b) // PASTE_ARGS 2\n" // cpp outputs a warning and a space after the comma, similar below.
59-
+ "foo(a,b) // PASTE_ELLIPSIS 2\n"
60-
+ "foo(a) // PASTE_ELLIPSIS 1\n"
61-
+ "foo(a,b) // PASTE_VAARGS 2\n"
62-
+ "foo(a) // PASTE_VAARGS 1", output);
52+
LOG.info("Output is:\n{}", output);
53+
// cpp outputs a warning and a space after the comma, similar below.
54+
assertEquals("""
55+
foo(a, b) // REGULAR_ARGS 2
56+
foo(a, b) // REGULAR_ELLIPSIS 2
57+
foo(a, ) // REGULAR_ELLIPSIS 1
58+
foo(a, b) // REGULAR_VAARGS 2
59+
foo(a, ) // REGULAR_VAARGS 1
60+
foo(a,b) // PASTE_ARGS 2
61+
foo(a,b) // PASTE_ELLIPSIS 2
62+
foo(a) // PASTE_ELLIPSIS 1
63+
foo(a,b) // PASTE_VAARGS 2
64+
foo(a) // PASTE_VAARGS 1""", output);
6365
}
6466
}

glsl-preprocessor/src/test/java/io/github/douira/glsl_preprocessor/__snapshots__/IntegrationTest.snap

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
testPreprocessor[GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH,ARBITRARY_PRAGMAS_uO+aZa+FgyCVAejH6nxTkTt0CWQ=]=[
1+
testPreprocessor[GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH,ARBITRARY_PRAGMAS_uO+aZa+FgyCVAejH6nxTkTt0CWQ]=[
22
#custom fdsaflsj 43lk j43kljgkld "fds" +,--,fds
33
#version 330 core
44
#pragma foo bar fdafds a
@@ -11,7 +11,7 @@ testPreprocessor[GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH,ARBITRARY_PRAGMAS_uO+a
1111
]
1212

1313

14-
testPreprocessor[GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH_WD5wCCQXiHxE57nVQkXoycdQjks=]=[
14+
testPreprocessor[GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH_WD5wCCQXiHxE57nVQkXoycdQjks]=[
1515
#version
1616
#extension
1717
#custom
@@ -24,7 +24,7 @@ testPreprocessor[GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH_WD5wCCQXiHxE57nVQkXoyc
2424
]
2525

2626

27-
testPreprocessor[GLSL_PASSTHROUGH_ORQdau2vuA/2h/xeXX1yjDgBKng=]=[
27+
testPreprocessor[GLSL_PASSTHROUGH_ORQdau2vuA/2h/xeXX1yjDgBKng]=[
2828
#version 330 core
2929
foo bar
3030
#extension foo : bar
@@ -41,7 +41,7 @@ int a = 4;
4141
]
4242

4343

44-
testPreprocessor[GLSL_PASSTHROUGH_bB149WHJMXASfFOJUlrhhdjem24=]=[
44+
testPreprocessor[GLSL_PASSTHROUGH_bB149WHJMXASfFOJUlrhhdjem24]=[
4545
#line 5 324
4646
#version 330 core
4747
int a = 4;
@@ -76,7 +76,7 @@ foo bar
7676
]
7777

7878

79-
testPreprocessor[GLSL_PASSTHROUGH_wyy4x0OaDgyEmuM7w5N5SLtVji8=]=[
79+
testPreprocessor[GLSL_PASSTHROUGH_wyy4x0OaDgyEmuM7w5N5SLtVji8]=[
8080
#extension GL_ARB_texture_rectangle : enable
8181
#extension GL_ARB_texture_rectangle : enable
8282
#version 330 fjdsal fjsda fisda jfiojfdsaflkds
@@ -109,39 +109,39 @@ if (a == 4) {
109109
]
110110

111111

112-
testPreprocessor[errors,ARBITRARY_PRAGMAS_tkMavAFBAxEG3RtCGFwG7STeCK4=]=[
112+
testPreprocessor[errors,ARBITRARY_PRAGMAS_tkMavAFBAxEG3RtCGFwG7STeCK4]=[
113113
#pragma
114114

115115
<><><><><><><><><><><><><><><><><><><><><><><><><>
116116
io.github.douira.glsl_preprocessor.LexerException: Warning at 1:7: Empty #pragma
117117
]
118118

119119

120-
testPreprocessor[errors,GLSL_CUSTOM_PASSTHROUGH_LiielybpiPYMDUxz8pc85kwvnAI=]=[
120+
testPreprocessor[errors,GLSL_CUSTOM_PASSTHROUGH_LiielybpiPYMDUxz8pc85kwvnAI]=[
121121
#custom fdskalfjk#fdsfldsj
122122

123123
<><><><><><><><><><><><><><><><><><><><><><><><><>
124124
io.github.douira.glsl_preprocessor.InternalException: Bad token [#@1,17]:"#"
125125
]
126126

127127

128-
testPreprocessor[errors,GLSL_CUSTOM_PASSTHROUGH_aDv7vwg7JM7S15pnkSb2Vvu1P7U=]=[
128+
testPreprocessor[errors,GLSL_CUSTOM_PASSTHROUGH_aDv7vwg7JM7S15pnkSb2Vvu1P7U]=[
129129
#version
130130

131131
<><><><><><><><><><><><><><><><><><><><><><><><><>
132132
io.github.douira.glsl_preprocessor.LexerException: GLSL passthrough not enabled
133133
]
134134

135135

136-
testPreprocessor[errors,GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH_SkPEvQvuleWLKW47WWP78/taGeU=]=[
136+
testPreprocessor[errors,GLSL_PASSTHROUGH,GLSL_CUSTOM_PASSTHROUGH_SkPEvQvuleWLKW47WWP78/taGeU]=[
137137
#pragma foo bar fdafds a
138138

139139
<><><><><><><><><><><><><><><><><><><><><><><><><>
140140
io.github.douira.glsl_preprocessor.LexerException: Warning at 1:8: Unknown #pragma: foo
141141
]
142142

143143

144-
testPreprocessor[errors,GLSL_PASSTHROUGH_qT/RZ9gQ4GE2a78x7LH4SKT2FWo=]=[
144+
testPreprocessor[errors,GLSL_PASSTHROUGH_qT/RZ9gQ4GE2a78x7LH4SKT2FWo]=[
145145
#custom fds
146146

147147
<><><><><><><><><><><><><><><><><><><><><><><><><>

glsl-preprocessor/src/test/java/io/github/douira/glsl_preprocessor/test_util/AssertUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ public static String getBase64Hash(String content) {
1212
throw new RuntimeException(e);
1313
}
1414
digest.update(content.getBytes());
15-
return Base64.getEncoder().encodeToString(digest.digest());
15+
return Base64.getEncoder().encodeToString(digest.digest()).replace("=", "");
1616
}
1717
}

glsl-preprocessor/src/test/resources/snapshot.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ reporters=au.com.origin.snapshots.reporters.PlainTextSnapshotReporter
44
snapshot-dir=__snapshots__
55
output-dir=src/test/java
66
ci-env-var=CI
7+
update-snapshot=none

gradle/wrapper/gradle-wrapper.jar

-17.5 KB
Binary file not shown.
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
44
networkTimeout=10000
5+
validateDistributionUrl=true
56
zipStoreBase=GRADLE_USER_HOME
67
zipStorePath=wrapper/dists

gradlew

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
# See the License for the specific language governing permissions and
1616
# limitations under the License.
1717
#
18+
# SPDX-License-Identifier: Apache-2.0
19+
#
1820

1921
##############################################################################
2022
#
@@ -55,7 +57,7 @@
5557
# Darwin, MinGW, and NonStop.
5658
#
5759
# (3) This script is generated from the Groovy template
58-
# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
60+
# https://github.com/gradle/gradle/blob/HEAD/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
5961
# within the Gradle project.
6062
#
6163
# You can find Gradle at https://github.com/gradle/gradle/.
@@ -83,10 +85,8 @@ done
8385
# This is normally unused
8486
# shellcheck disable=SC2034
8587
APP_BASE_NAME=${0##*/}
86-
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
87-
88-
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
89-
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
88+
# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036)
89+
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) || exit
9090

9191
# Use the maximum available, or set MAX_FD != -1 to use that value.
9292
MAX_FD=maximum
@@ -133,26 +133,29 @@ location of your Java installation."
133133
fi
134134
else
135135
JAVACMD=java
136-
which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
136+
if ! command -v java >/dev/null 2>&1
137+
then
138+
die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
137139
138140
Please set the JAVA_HOME variable in your environment to match the
139141
location of your Java installation."
142+
fi
140143
fi
141144

142145
# Increase the maximum file descriptors if we can.
143146
if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
144147
case $MAX_FD in #(
145148
max*)
146149
# In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
147-
# shellcheck disable=SC3045
150+
# shellcheck disable=SC2039,SC3045
148151
MAX_FD=$( ulimit -H -n ) ||
149152
warn "Could not query maximum file descriptor limit"
150153
esac
151154
case $MAX_FD in #(
152155
'' | soft) :;; #(
153156
*)
154157
# In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
155-
# shellcheck disable=SC3045
158+
# shellcheck disable=SC2039,SC3045
156159
ulimit -n "$MAX_FD" ||
157160
warn "Could not set maximum file descriptor limit to $MAX_FD"
158161
esac
@@ -197,11 +200,15 @@ if "$cygwin" || "$msys" ; then
197200
done
198201
fi
199202

200-
# Collect all arguments for the java command;
201-
# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
202-
# shell script including quotes and variable substitutions, so put them in
203-
# double quotes to make sure that they get re-expanded; and
204-
# * put everything else in single quotes, so that it's not re-expanded.
203+
204+
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
205+
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
206+
207+
# Collect all arguments for the java command:
208+
# * DEFAULT_JVM_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
209+
# and any embedded shellness will be escaped.
210+
# * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be
211+
# treated as '${Hostname}' itself on the command line.
205212

206213
set -- \
207214
"-Dorg.gradle.appname=$APP_BASE_NAME" \

gradlew.bat

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
@rem See the License for the specific language governing permissions and
1414
@rem limitations under the License.
1515
@rem
16+
@rem SPDX-License-Identifier: Apache-2.0
17+
@rem
1618

1719
@if "%DEBUG%"=="" @echo off
1820
@rem ##########################################################################
@@ -43,11 +45,11 @@ set JAVA_EXE=java.exe
4345
%JAVA_EXE% -version >NUL 2>&1
4446
if %ERRORLEVEL% equ 0 goto execute
4547

46-
echo.
47-
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
48-
echo.
49-
echo Please set the JAVA_HOME variable in your environment to match the
50-
echo location of your Java installation.
48+
echo. 1>&2
49+
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2
50+
echo. 1>&2
51+
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
52+
echo location of your Java installation. 1>&2
5153

5254
goto fail
5355

@@ -57,11 +59,11 @@ set JAVA_EXE=%JAVA_HOME%/bin/java.exe
5759

5860
if exist "%JAVA_EXE%" goto execute
5961

60-
echo.
61-
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
62-
echo.
63-
echo Please set the JAVA_HOME variable in your environment to match the
64-
echo location of your Java installation.
62+
echo. 1>&2
63+
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2
64+
echo. 1>&2
65+
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
66+
echo location of your Java installation. 1>&2
6567

6668
goto fail
6769

0 commit comments

Comments
 (0)