Skip to content

Commit 01c8e4c

Browse files
committed
Re-comment test-docker, update toolchain?
1 parent 2214e44 commit 01c8e4c

File tree

2 files changed

+33
-32
lines changed

2 files changed

+33
-32
lines changed

.github/workflows/typescript-napi-ci.yaml

Lines changed: 32 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -53,34 +53,35 @@ jobs:
5353
run: yarn run compile
5454
- name: Run tests
5555
run: yarn run test
56-
57-
test-docker:
58-
runs-on: ${{ matrix.os }}
59-
container:
60-
image: node:${{ matrix.node_version }}-alpine
61-
strategy:
62-
matrix:
63-
rust_version:
64-
- stable
65-
- beta
66-
node_version:
67-
- 20
68-
- 22
69-
- 24
70-
os:
71-
- ubuntu-24.04
72-
- ubuntu-24.04-arm
73-
fail-fast: false
74-
steps:
75-
- run: apk add build-base git python3 wget
76-
- run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
77-
- uses: actions/checkout@v5
78-
- uses: IronCoreLabs/rust-toolchain@v1
79-
with:
80-
toolchain: ${{ matrix.rust_version }}
81-
- name: Install modules
82-
run: yarn install --ignore-scripts
83-
- name: Compile
84-
run: yarn run compile
85-
- name: Run tests
86-
run: yarn run test
56+
57+
# broken now that node20 is forced even for checkout@v3, which doesn't work using the # WORKAROUND below any more.
58+
# test-docker:
59+
# runs-on: ${{ matrix.os }}
60+
# container:
61+
# image: node:${{ matrix.node_version }}-alpine
62+
# strategy:
63+
# matrix:
64+
# rust_version:
65+
# - stable
66+
# - beta
67+
# node_version:
68+
# - 20
69+
# - 22
70+
# - 24
71+
# os:
72+
# - ubuntu-24.04
73+
# - ubuntu-24.04-arm
74+
# fail-fast: false
75+
# steps:
76+
# - run: apk add build-base git python3 wget
77+
# - run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
78+
# - uses: actions/checkout@v5
79+
# - uses: IronCoreLabs/rust-toolchain@v1
80+
# with:
81+
# toolchain: ${{ matrix.rust_version }}
82+
# - name: Install modules
83+
# run: yarn install --ignore-scripts
84+
# - name: Compile
85+
# run: yarn run compile
86+
# - name: Run tests
87+
# run: yarn run test

rust-toolchain.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[toolchain]
22
profile = "default"
3-
channel = "1.87.0"
3+
channel = "1.89.0"

0 commit comments

Comments
 (0)