Skip to content

Commit 88370c7

Browse files
committed
Fix test failures
1 parent 83689ee commit 88370c7

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

Src/IronPython/Runtime/Operations/StringOps.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1219,7 +1219,8 @@ private static void AppendValueForTranslate(this StringBuilder ret, object? mapp
12191219
return;
12201220
case int mappedInt:
12211221
if (mappedInt > 0xFFFF) {
1222-
throw PythonOps.ValueError("character mapping must be in range(0x10000)");
1222+
// TODO: change to a ValueError in Python 3.5
1223+
throw PythonOps.TypeError("character mapping must be in range(0x10000)");
12231224
}
12241225
ret.Append((char)mappedInt);
12251226
break;

Tests/test_codeccallbacks_stdlib.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ def load_tests(loader, standard_tests, pattern):
1515

1616
if is_ironpython:
1717
failing_tests = [
18-
test.test_codeccallbacks.CodecCallbackTest('test_backslashescape'), # UTF-16 vs. UTF-32
1918
test.test_codeccallbacks.CodecCallbackTest('test_badandgoodbackslashreplaceexceptions'), # UTF-16 vs. UTF-32
2019
test.test_codeccallbacks.CodecCallbackTest('test_badandgoodreplaceexceptions'), # UTF-16 vs. UTF-32
2120
test.test_codeccallbacks.CodecCallbackTest('test_badandgoodxmlcharrefreplaceexceptions'), # UTF-16 vs. UTF-32

Tests/test_struct_stdlib.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ def load_tests(loader, standard_tests, pattern):
1515

1616
if is_ironpython:
1717
failing_tests = [
18-
test.test_struct.StructTest('test_705836'), # AssertionError: OverflowError not raised by pack
1918
test.test_struct.StructTest('test_bool'), # struct.error: expected bool value got IronPython.NewTypes.System.Object_1$1
2019
test.test_struct.StructTest('test_calcsize'), # AssertionError: 4 not greater than or equal to 8
2120
test.test_struct.StructTest('test_count_overflow'), # AssertionError: error not raised by calcsize

0 commit comments

Comments
 (0)