Merge pull request emscripten-forge#2360 from anutosh491/add_xeus_shared

Add support for shared build for xeus

Author: SylvainCorlay

recipes/recipes_emscripten/xeus/build.sh

@@ -2,23 +2,14 @@
 mkdir build
 cd build
 
-if [[ $target_platform == "emscripten-wasm32" ]]; then
-    export USE_WASM=ON
-else
-    export USE_WASM=OFF
-fi
-
 # Configure step
-cmake ${CMAKE_ARGS} ..             \
-    -GNinja                        \
-    -DCMAKE_BUILD_TYPE=Release     \
-    -DCMAKE_PREFIX_PATH=$PREFIX    \
+emcmake cmake .. \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DCMAKE_PREFIX_PATH=$PREFIX \
     -DCMAKE_INSTALL_PREFIX=$PREFIX \
-    -DXEUS_EMSCRIPTEN_WASM_BUILD=$USE_WASM \
-    -DCMAKE_FIND_DEBUG_MODE=OFF \
-
-    # -Dnlohmann_json_DIR=$PREFIX/lib/cmake/nlohmann_json \
-    # -Dxtl_DIR=$PREFIX/share/cmake/xtl \
+    -DCMAKE_FIND_ROOT_PATH=$PREFIX \
+    -DXEUS_BUILD_SHARED_LIBS=ON \
+    -DXEUS_BUILD_STATIC_LIBS=ON
 
-# Build step
-ninja install
+# Build & Install step
+emmake make -j8 install

recipes/recipes_emscripten/xeus/patches/shared.patch

@@ -0,0 +1,29 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index a8147d3..12cee40 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -59,8 +59,12 @@ option(XEUS_BUILD_TESTS "xeus test suite" OFF)
+ # ===================================
+ 
+ if(EMSCRIPTEN)
+-    SET(XEUS_BUILD_SHARED_LIBS OFF)
+-    SET(XEUS_BUILD_STATIC_LIBS ON)
++    if (XEUS_BUILD_SHARED_LIBS)
++        set_property(GLOBAL PROPERTY TARGET_SUPPORTS_SHARED_LIBS TRUE)
++        set(CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "-s SIDE_MODULE=1")
++        set(CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS "-s SIDE_MODULE=1")
++        set(CMAKE_STRIP FALSE)
++    endif ()
+ endif()
+ 
+ # Print build configuration
+@@ -258,6 +262,9 @@ macro(xeus_create_target target_name linkage output_name)
+ 
+     if (EMSCRIPTEN)
+        target_compile_definitions(${target_name} PRIVATE XEUS_EMSCRIPTEN_WASM_BUILD)
++        if (XEUS_BUILD_SHARED_LIBS)
++            set_target_properties(${target_name} PROPERTIES NO_SONAME 1)
++        endif ()
+        xeus_wasm_compile_options(${target_name})
+     endif()
+ endmacro()

recipes/recipes_emscripten/xeus/recipe.yaml

@@ -8,21 +8,24 @@ package:
 source:
   url: https://github.com/jupyter-xeus/xeus/archive/refs/tags/${{ version }}.tar.gz
   sha256: c94008416ae5a54b1fee80a004ecea70cd041e6bd5942e6acebcb878b96c1ec1
+  patches:
+  - patches/shared.patch
 
 build:
-  number: 0
+  number: 1
 
 requirements:
   build:
   - ${{ compiler("cxx") }}
   - cmake
-  - ninja
+  - make
   host:
   - nlohmann_json
 
 tests:
 - script:
   - test -f $PREFIX/lib/libxeus.a
+  - test -f $PREFIX/lib/libxeus.so
   - test -f $PREFIX/include/xeus/xeus.hpp
 about:
   license: BSD-3-Clause