Skip to content

Commit 08e3ea0

Browse files
author
“Akshay
committed
[MOB-9211] - InApp resizing fix
Removing treeobserver as the html would keep calling this callback even after the page was finished loading. This method was used as an additional measure to make sure inapps are resized in situation when inapps were still not displayed after finished loading. This fix adds delay of 100ms which seems to resolve inapps on Pixel 6pro and still making it all work on Pixel 8 device, needing the SDK to not rely on tree observers.
1 parent d099e27 commit 08e3ea0

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import android.view.OrientationEventListener;
2323
import android.view.View;
2424
import android.view.ViewGroup;
25-
import android.view.ViewTreeObserver;
2625
import android.view.Window;
2726
import android.view.WindowManager;
2827
import android.view.animation.Animation;
@@ -168,14 +167,6 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
168167
webView.setId(R.id.webView);
169168
webView.createWithHtml(this, htmlString);
170169

171-
webView.getViewTreeObserver().addOnPreDrawListener(new ViewTreeObserver.OnPreDrawListener() {
172-
@Override
173-
public boolean onPreDraw() {
174-
runResizeScript();
175-
return true;
176-
}
177-
});
178-
179170
if (orientationListener == null) {
180171
orientationListener = new OrientationEventListener(getContext(), SensorManager.SENSOR_DELAY_NORMAL) {
181172
// Resize the webView on device rotation

iterableapi/src/main/java/com/iterable/iterableapi/IterableWebViewClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ public boolean shouldOverrideUrlLoading(WebView view, String url) {
1919
@Override
2020
public void onPageFinished(WebView view, String url) {
2121
inAppHTMLNotification.setLoaded(true);
22-
inAppHTMLNotification.runResizeScript();
22+
view.postDelayed(inAppHTMLNotification::runResizeScript, 100);
2323
}
2424
}

0 commit comments

Comments
 (0)