Skip to content

Commit 0cfa9e4

Browse files
Merge branch 'stable'
# Conflicts: # README.md # sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m
2 parents 6b75b9b + f3a4ff5 commit 0cfa9e4

File tree

7 files changed

+11
-13
lines changed

7 files changed

+11
-13
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
osx_image: xcode10.2
1+
osx_image: xcode10
22
language: swift
33

44
before_install:

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ See the Iterable guide on how to setup your Iterable push integration and obtain
106106
107107
### 3. Set userId or email.
108108
Once you know the email or userId of the user, set the value.
109-
109+
> ⚠ Don't specify both email and userId in the same session, as they will be treated as different users by the SDK. Only use one type of identifier, email or userId, to identify the user.
110110
*Swift*
111111
112112
```swift
@@ -417,7 +417,7 @@ To do this, Iterable sends a silent push notification some time (currently, twel
417417

418418
# Rich Push Notifications
419419

420-
Push notifications may contain media attachments with images, animated gifs or video, and with an upcoming update, there will be a way to create action buttons. For this to work within your app, you need to create a Notification Service Extension. More instructions here: [Rich Push Notifications in iOS 10 and Android - Media Attachments](https://support.iterable.com/hc/en-us/articles/115003982203-Rich-Push-Notifications-in-iOS-10-and-Android-Media-Attachments).
420+
Push notifications may contain media attachments with images, animated gifs or video, and action buttons. For this to work within your app, you need to create a Notification Service Extension. More instructions here: [Rich Push Notifications in iOS 10 and Android - Media Attachments](https://support.iterable.com/hc/en-us/articles/115003982203-Rich-Push-Notifications-in-iOS-10-and-Android-Media-Attachments).
421421

422422
Iterable SDK provides an implementation that handles media attachments and action buttons.
423423

sample-apps/objc-sample-app/Podfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@ platform :ios, '11.0'
22

33
# Comment the next line if you're not using Swift and don't want to use dynamic frameworks
44
use_frameworks!
5-
swift_version = '4.0'
65

76
target 'objc-sample-app' do
8-
pod 'Iterable-iOS-SDK', :path => '../../../swift-sdk'
7+
pod 'Iterable-iOS-SDK'
98
end
109

1110
target 'objc-sample-app-notification-extension' do
12-
pod 'Iterable-iOS-AppExtensions', :path => '../../../swift-sdk'
11+
pod 'Iterable-iOS-AppExtensions'
1312
end

sample-apps/objc-sample-app/objc-sample-app.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@
353353
files = (
354354
);
355355
inputPaths = (
356-
"${SRCROOT}/Pods/Target Support Files/Pods-objc-sample-app/Pods-objc-sample-app-frameworks.sh",
356+
"${PODS_ROOT}/Target Support Files/Pods-objc-sample-app/Pods-objc-sample-app-frameworks.sh",
357357
"${BUILT_PRODUCTS_DIR}/Iterable-iOS-SDK/IterableSDK.framework",
358358
"${BUILT_PRODUCTS_DIR}/Iterable-iOS-AppExtensions/IterableAppExtensions.framework",
359359
);
@@ -364,7 +364,7 @@
364364
);
365365
runOnlyForDeploymentPostprocessing = 0;
366366
shellPath = /bin/sh;
367-
shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-objc-sample-app/Pods-objc-sample-app-frameworks.sh\"\n";
367+
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-objc-sample-app/Pods-objc-sample-app-frameworks.sh\"\n";
368368
showEnvVarsInLog = 0;
369369
};
370370
459DDAFDFA23308D87287385 /* [CP] Check Pods Manifest.lock */ = {

sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ - (void)application:(UIApplication *)application didReceiveRemoteNotification:(N
9898

9999
#pragma mark - Url handling
100100
- (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void (^)(NSArray<id<UIUserActivityRestoring>> * _Nullable))restorationHandler {
101-
102101
//ITBL:
103102
NSURL *url = userActivity.webpageURL;
104103
if (url == nil) {

sample-apps/swift-sample-app/swift-sample-app.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@
322322
files = (
323323
);
324324
inputPaths = (
325-
"${SRCROOT}/Pods/Target Support Files/Pods-swift-sample-app/Pods-swift-sample-app-frameworks.sh",
325+
"${PODS_ROOT}/Target Support Files/Pods-swift-sample-app/Pods-swift-sample-app-frameworks.sh",
326326
"${BUILT_PRODUCTS_DIR}/Iterable-iOS-SDK/IterableSDK.framework",
327327
"${BUILT_PRODUCTS_DIR}/Iterable-iOS-AppExtensions/IterableAppExtensions.framework",
328328
);
@@ -333,7 +333,7 @@
333333
);
334334
runOnlyForDeploymentPostprocessing = 0;
335335
shellPath = /bin/sh;
336-
shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-swift-sample-app/Pods-swift-sample-app-frameworks.sh\"\n";
336+
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-swift-sample-app/Pods-swift-sample-app-frameworks.sh\"\n";
337337
showEnvVarsInLog = 0;
338338
};
339339
37DFA1A5B0E68594B76BF513 /* [CP] Check Pods Manifest.lock */ = {

scripts/build-target-module-framework.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ UNIVERSAL_OUTPUTFOLDER=${BUILD_DIR}/${CONFIGURATION}-universal
1919
mkdir -p "${UNIVERSAL_OUTPUTFOLDER}"
2020

2121
# Step 1. Build Device and Simulator versions
22-
xcodebuild -target "${TARGET}" ONLY_ACTIVE_ARCH=NO -configuration ${CONFIGURATION} -sdk iphoneos BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_DIR}" clean build
23-
xcodebuild -target "${TARGET}" -configuration ${CONFIGURATION} -sdk iphonesimulator ONLY_ACTIVE_ARCH=NO BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_DIR}" clean build
22+
xcodebuild -target "${TARGET}" ONLY_ACTIVE_ARCH=NO -configuration ${CONFIGURATION} -sdk iphoneos BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_DIR}" BITCODE_GENERATION_MODE=bitcode clean build
23+
xcodebuild -target "${TARGET}" -configuration ${CONFIGURATION} -sdk iphonesimulator ONLY_ACTIVE_ARCH=NO BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_DIR}" BITCODE_GENERATION_MODE=bitcode clean build
2424

2525
# Step 2. Copy the framework structure (from iphoneos build) to the universal folder
2626
cp -R "${BUILD_DIR}/${CONFIGURATION}-iphoneos/${MODULE_NAME}.framework" "${UNIVERSAL_OUTPUTFOLDER}/"

0 commit comments

Comments
 (0)