Merge pull request #54 from Iterable/feature/mob-94-current-user-id

[MOB-94] - Update email with userId

Author: tapashmajumder

Tests/swift-sdk-swift-tests/IterableAPITests.swift

@@ -127,8 +127,8 @@ class IterableAPITests: XCTestCase {
         wait(for: [expectation], timeout: testExpectationTimeout)
     }
 
-    func testUpdateEmail() {
-        let expectation = XCTestExpectation(description: "testUpdateEmail")
+    func testUpdateEmailWithEmail() {
+        let expectation = XCTestExpectation(description: "testUpdateEmailWithEmail")
 
         let newEmail = "[email protected]"
         let networkSession = MockNetworkSession(statusCode: 200)
@@ -158,6 +158,40 @@ class IterableAPITests: XCTestCase {
 
         wait(for: [expectation], timeout: testExpectationTimeout)
     }
+
+    func testUpdateEmailWithUserId() {
+        let expectation = XCTestExpectation(description: "testUpdateEmailWithUserId")
+        
+        let currentUserId = IterableUtil.generateUUID()
+        let newEmail = "[email protected]"
+        let networkSession = MockNetworkSession(statusCode: 200)
+        IterableAPI.initializeForTesting(apiKey: IterableAPITests.apiKey, networkSession: networkSession)
+        IterableAPI.userId = currentUserId
+        IterableAPI.updateEmail(newEmail,
+                                onSuccess: {json in
+                                    TestUtils.validate(request: networkSession.request!,
+                                                       requestType: .post,
+                                                       apiEndPoint: .ITBL_ENDPOINT_API,
+                                                       path: .ITBL_PATH_UPDATE_EMAIL,
+                                                       queryParams: [(name: "api_key", value: IterableAPITests.apiKey)])
+                                    let body = networkSession.getRequestBody()
+                                    TestUtils.validateElementPresent(withName: AnyHashable.ITBL_KEY_NEW_EMAIL, andValue: newEmail, inDictionary: body)
+                                    TestUtils.validateElementPresent(withName: AnyHashable.ITBL_KEY_CURRENT_USER_ID, andValue: currentUserId, inDictionary: body)
+                                    XCTAssertEqual(IterableAPI.email, newEmail)
+                                    expectation.fulfill()
+        },
+                                onFailure: {(reason, _) in
+                                    expectation.fulfill()
+                                    if let reason = reason {
+                                        XCTFail("encountered error: \(reason)")
+                                    } else {
+                                        XCTFail("encountered error")
+                                    }
+        })
+        
+        wait(for: [expectation], timeout: testExpectationTimeout)
+    }
+
 
     func testRegisterTokenNilAppName() {
         let expectation = XCTestExpectation(description: "testRegisterToken")

swift-sdk/ITBConsts.swift

@@ -39,6 +39,7 @@ public extension AnyHashable {
     public static let ITBL_KEY_CAMPAIGN_ID = "campaignId"
     public static let ITBL_KEY_COUNT = "count"
     public static let ITBL_KEY_CURRENT_EMAIL = "currentEmail"
+    public static let ITBL_KEY_CURRENT_USER_ID = "currentUserId"
     public static let ITBL_KEY_DATA_FIELDS = "dataFields"
     public static let ITBL_KEY_DEVICE = "device"
     public static let ITBL_KEY_EMAIL = "email"

swift-sdk/Internal/IterableAPIInternal.swift

@@ -218,16 +218,20 @@ final class IterableAPIInternal : NSObject, PushTrackerProtocol {
     }
 
     func updateEmail(_ newEmail: String, onSuccess: OnSuccessHandler?, onFailure: OnFailureHandler?) {
-        guard let email = email else {
-            onFailure?("updateEmail should not be called with a userId. Init SDK with email instead of userId.", nil)
-            return
-        }
-        
-        let args: [String : Any] = [
-            AnyHashable.ITBL_KEY_CURRENT_EMAIL: email,
+        var args: [String : Any] = [
             AnyHashable.ITBL_KEY_NEW_EMAIL: newEmail
         ]
 
+        if let email = email {
+            args[AnyHashable.ITBL_KEY_CURRENT_EMAIL] = email
+        } else if let userId = userId {
+            args[AnyHashable.ITBL_KEY_CURRENT_USER_ID] = userId
+        } else {
+            ITBError("Both email and userId are nil")
+            onFailure?("Both email and userId are nil", nil)
+            return
+        }
+
         if let request = createPostRequest(forPath: .ITBL_PATH_UPDATE_EMAIL, withBody: args) {
             sendRequest(request,
                         onSuccess: { data in