Merge pull request #66 from Iterable/bugfix/mob-261

tapashmajumder · web-flow · commit 95e6bcff8a41 · 2019-03-28T19:06:17.000-07:00
[MOB-261] - Rename parameter
diff --git a/Tests/swift-sdk-swift-tests/IterableInAppNotificationTests.swift b/Tests/swift-sdk-swift-tests/IterableInAppNotificationTests.swift
@@ -180,7 +180,7 @@ class IterableInAppNotificationTests: XCTestCase {
                 ])
             let body = networkSession.getRequestBody() as! [String : Any]
             TestUtils.validateMatch(keyPath: KeyPath("messageId"), value: messageId, inDictionary: body)
-            TestUtils.validateMatch(keyPath: KeyPath("urlClick"), value: buttonUrl, inDictionary: body)
+            TestUtils.validateMatch(keyPath: KeyPath("clickedUrl"), value: buttonUrl, inDictionary: body)
             TestUtils.validateMatch(keyPath: KeyPath("userId"), value: IterableInAppNotificationTests.userId, inDictionary: body)
             expectation1.fulfill()
         }
diff --git a/swift-sdk/ITBConsts.swift b/swift-sdk/ITBConsts.swift
@@ -138,7 +138,7 @@ public extension AnyHashable {
 
 //In-App Constants
 public extension AnyHashable {
-    public static let ITBL_IN_APP_CLICK_URL = "urlClick"
+    public static let ITBL_IN_APP_CLICKED_URL = "clickedUrl"
     
     public static let ITBL_IN_APP_BUTTON_INDEX = "buttonIndex"
     public static let ITBL_IN_APP_MESSAGE = "inAppMessages"
diff --git a/swift-sdk/Internal/IterableAPIInternal.swift b/swift-sdk/Internal/IterableAPIInternal.swift
@@ -448,7 +448,7 @@ final class IterableAPIInternal : NSObject, PushTrackerProtocol {
     func trackInAppClick(_ messageId: String, buttonURL: String) {
         var args: [AnyHashable : Any] = [
             .ITBL_KEY_MESSAGE_ID: messageId,
-            .ITBL_IN_APP_CLICK_URL: buttonURL
+            .ITBL_IN_APP_CLICKED_URL: buttonURL
         ]
         addEmailOrUserId(args: &args)
         

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ class IterableInAppNotificationTests: XCTestCase {`
`180`	`180`	`])`
`181`	`181`	`let body = networkSession.getRequestBody() as! [String : Any]`
`182`	`182`	`TestUtils.validateMatch(keyPath: KeyPath("messageId"), value: messageId, inDictionary: body)`
`183`		`- TestUtils.validateMatch(keyPath: KeyPath("urlClick"), value: buttonUrl, inDictionary: body)`
	`183`	`+ TestUtils.validateMatch(keyPath: KeyPath("clickedUrl"), value: buttonUrl, inDictionary: body)`
`184`	`184`	`TestUtils.validateMatch(keyPath: KeyPath("userId"), value: IterableInAppNotificationTests.userId, inDictionary: body)`
`185`	`185`	`expectation1.fulfill()`
`186`	`186`	`}`
Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,7 @@ final class IterableAPIInternal : NSObject, PushTrackerProtocol {`
`448`	`448`	`func trackInAppClick(_ messageId: String, buttonURL: String) {`
`449`	`449`	`var args: [AnyHashable : Any] = [`
`450`	`450`	`.ITBL_KEY_MESSAGE_ID: messageId,`
`451`		`- .ITBL_IN_APP_CLICK_URL: buttonURL`
	`451`	`+ .ITBL_IN_APP_CLICKED_URL: buttonURL`
`452`	`452`	`]`
`453`	`453`	`addEmailOrUserId(args: &args)`
`454`	`454`