Code review fixes

1. check for either email or userId
2. return result of DeeplinkHandler.handleURL

Author: tapashmajumder

sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m

@@ -16,14 +16,16 @@ @interface AppDelegate ()
 @end
 
 @implementation AppDelegate
+// IMP: Either email or userId must be set.
 NSString *apiKey = @""; // set iterable api key here
 NSString *email = @""; // set iterable email here
+NSString *userId = @"";// set iterable userId here, either email or userId must be set
 
 
 - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
     // initial check
-    if (apiKey.length == 0 || email.length == 0) {
-        [NSException raise:@"Not Initialized" format:@"Iterable API key and email must be set."];
+    if (apiKey.length == 0 || (email.length == 0 && userId.length == 0)) {
+        [NSException raise:@"Not Initialized" format:@"Iterable API key and either email or userId must be set."];
     }
 
     //ITBL: Setup Notifications
@@ -115,7 +117,7 @@ - (BOOL)handleIterableCustomAction:(IterableAction *)action context:(IterableAct
         if (action.userInput != nil) {
             NSString *urlString = [[NSString alloc] initWithFormat:@"https://majumder.me/coffee?q=%@", action.userInput];
             NSURL *url = [[NSURL alloc] initWithString:urlString];
-            [DeeplinkHandler handleURL:url];
+            return [DeeplinkHandler handleURL:url];
         }
     }
 

sample-apps/swift-sample-app/swift-sample-app/AppDelegate.swift

@@ -14,15 +14,17 @@ import IterableSDK
 @UIApplicationMain
 class AppDelegate: UIResponder, UIApplicationDelegate {
     // ITBL: replace with your api key and email.
+    // IMP: Either userId or email must be set.
     let apiKey = "" // set Iterable api key here
     let email = "" // set Iterable user email here.
+    let userId = "" // set iterable userId here. Either email or userId must be set.
 
     var window: UIWindow?
 
     func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
         // Initial check
-        if apiKey.isEmpty || email.isEmpty {
-            fatalError("Iterable API Key and email need to be set.")
+        if apiKey.isEmpty || (email.isEmpty && userId.isEmpty) {
+            fatalError("Iterable API Key and either email or userId need to be set.")
         }
 
         //ITBL: Setup Notification
@@ -138,7 +140,7 @@ extension AppDelegate : IterableCustomActionDelegate {
     func handle(iterableCustomAction action: IterableAction, inContext context: IterableActionContext) -> Bool {
         if action.type == "handleFindCoffee" {
             if let query = action.userInput {
-                _ = DeeplinkHandler.handle(url: URL(string: "https://majumder.me/coffee?q=\(query)")!)
+                return DeeplinkHandler.handle(url: URL(string: "https://majumder.me/coffee?q=\(query)")!)
             }
         }
         return false