Merge pull request #507 from Iterable/tapash/mob-2832-network-session

[MOB-2832] - Do not expose networkSession from InternalAPI.

Author: tapashmajumder

swift-sdk/Internal/InboxViewControllerViewModel.swift

@@ -134,7 +134,7 @@ class InboxViewControllerViewModel: InboxViewControllerViewModelProtocol {
     }
 
     private func loadImage(forMessageId messageId: String, fromUrl url: URL) {
-        if let networkSession = internalAPI?.networkSession {
+        if let networkSession = internalAPI?.dependencyContainer.networkSession {
             NetworkHelper.getData(fromUrl: url, usingSession: networkSession).onSuccess { [weak self] in
                 self?.setImageData($0, forMessageId: messageId)
             }.onError {

swift-sdk/Internal/InternalIterableAPI.swift

@@ -58,6 +58,8 @@ final class InternalIterableAPI: NSObject, PushTrackerProtocol, AuthProvider {
     var auth: Auth {
         Auth(userId: userId, email: email, authToken: authManager.getAuthToken())
     }
+
+    var dependencyContainer: DependencyContainerProtocol
 
     lazy var inAppManager: IterableInternalInAppManagerProtocol = {
         self.dependencyContainer.createInAppManager(config: self.config,
@@ -376,9 +378,8 @@ final class InternalIterableAPI: NSObject, PushTrackerProtocol, AuthProvider {
     private let inAppDisplayer: InAppDisplayerProtocol
     private var notificationStateProvider: NotificationStateProviderProtocol
     private var localStorage: LocalStorageProtocol
-    var networkSession: NetworkSessionProtocol
+    private var networkSession: NetworkSessionProtocol
     private var urlOpener: UrlOpenerProtocol
-    private var dependencyContainer: DependencyContainerProtocol
 
     private var deepLinkManager: IterableDeepLinkManager
 

tests/common/CommonMocks.swift

@@ -561,10 +561,6 @@ class MockWebView: WebViewProtocol {
     }
 }
 
-struct MockInjectedDependencyModule {
-    let webView: WebViewProtocol
-}
-
 class MockLocalStorage: LocalStorageProtocol {
     var userId: String? = nil
 

tests/offline-events-tests/TaskProcessorTests.swift

@@ -47,7 +47,7 @@ class TaskProcessorTests: XCTestCase {
         let found = try persistenceProvider.mainQueueContext().findTask(withId: taskId)!
 
         // process data
-        let processor = IterableAPICallTaskProcessor(networkSession: internalAPI.networkSession)
+        let processor = IterableAPICallTaskProcessor(networkSession: networkSession)
         try processor.process(task: found).onSuccess { _ in
             let request = networkSession.getRequest(withEndPoint: Const.Path.trackEvent)!
             let body = request.httpBody!.json() as! [String: Any]